- Issue created by @pdureau
- 🇫🇷France G4MBINI Bègles
For information, DSFR 1.9 has been released. May be we want to update this issue ... ?
- 🇫🇷France mh_nichts
I'm willing to work on the content-media pattern (with transcription), which is the main change in v1.8.
I think it will be easier to create separate issues for the other changes (one issue per minor version at least), because there are too many !
Changes for 1.8.0 : https://github.com/GouvernementFR/dsfr/releases/tag/v1.8.0
Changes for 1.8.1 : https://github.com/GouvernementFR/dsfr/releases/tag/v1.8.1 (nothing for us, it seems)
Changes for 1.8.2 : https://github.com/GouvernementFR/dsfr/releases/tag/v1.8.2
Changes for 1.8.4 : https://github.com/GouvernementFR/dsfr/releases/tag/v1.8.4
Changes for 1.8.5 : https://github.com/GouvernementFR/dsfr/releases/tag/v1.8.5 (nothing for us, it seems)Changes for 1.9.0 : https://github.com/GouvernementFR/dsfr/releases/tag/v1.9.0
Changes for 1.9.1 : https://github.com/GouvernementFR/dsfr/releases/tag/v1.9.1
Changes for 1.9.2 : https://github.com/GouvernementFR/dsfr/releases/tag/v1.9.2 (nothing for us, it seems)
Changes for 1.9.3 : https://github.com/GouvernementFR/dsfr/releases/tag/v1.9.3Changes for 1.10.0 : https://github.com/GouvernementFR/dsfr/releases/tag/v1.10.0
Changes for 1.10.1 : https://github.com/GouvernementFR/dsfr/releases/tag/v1.10.1 - @mh_nichts opened merge request.
- Status changed to Needs review
over 1 year ago 4:22pm 26 September 2023 - 🇫🇷France mh_nichts
I added the new "transcription" pattern, to use it in content-media.
I also made small fixes for accessibility in content-media (as mentioned in DSFR documentation) :- use figure also for image (previously only for video)
- role group on figure only if there is an associated caption or transcription
- add aria-label on figure for caption
I will see for creating separate issues for the other changes.
Maybe we will have to change the title of this issue ? - 🇫🇷France mh_nichts
I've created tickets for the other changes :
- https://www.drupal.org/project/ui_suite_dsfr/issues/3390150 🐛 Replace fielset__content with fieldset__element system (1.8 changelog) Active (1.8)
- https://www.drupal.org/project/ui_suite_dsfr/issues/3390160 ✨ Handle status/error messages in form wuth messages-group (1.8 changelog) Active (1.8)
- https://www.drupal.org/project/ui_suite_dsfr/issues/3390145 🐛 Update default title levels (1.8 changelog) Active (1.8)
- https://www.drupal.org/project/ui_suite_dsfr/issues/3390166 🐛 Side-menu : replace aria-label by aria-labelledby (1.8 changelog) Active (1.8)
- https://www.drupal.org/project/ui_suite_dsfr/issues/3390173 ✨ Upload : new modifiers (1.8 changelog) Active (1.8)
- https://www.drupal.org/project/ui_suite_dsfr/issues/3390174 ✨ [1.1.0] Password input (1.8 changelog) Active (1.8)
- https://www.drupal.org/project/ui_suite_dsfr/issues/3390179 ✨ New icons (1.9 & 1.10 changelogs) Active (1.9 & 1.10)
- https://www.drupal.org/project/ui_suite_dsfr/issues/3390189 ✨ Replace download-block/download-link with card--download/link--donwload/tile--download (1.10 changelog) Active (1.10)
- https://www.drupal.org/project/ui_suite_dsfr/issues/3390190 ✨ Tile adjustments (1.10 changelog) Active (1.10)
- Status changed to Needs work
over 1 year ago 4:29pm 28 September 2023 - 🇫🇷France pdureau Paris
So, this issue will be a breaking change for content_media component, because transcription_link is becoming transcription, I add ⚠️ to the title.
First feedbacks.
<div class="fr-transcription">
The attributes object is missing.
<h1 id="fr-transcription__modal-transcription-{{ transcription_id }}-title" class="fr-modal__title"> {{ title }} </h1>
Do we need to put the h1 into a "if" condition to not print empty HTML element if title is empty?
- 🇫🇷France mh_nichts
I've fixed the attributes, thanks.
For the title, it must always be present (it's used to label the modal) and it has a default('Transcription') so I don't think we need a condition ? - Status changed to Fixed
over 1 year ago 9:33am 4 October 2023 - 🇫🇷France pdureau Paris
For the title, it must always be present (it's used to label the modal) and it has a default('Transcription') so I don't think we need a condition ?
indeed, there is a default value :) I have missed it.
I've fixed the attributes, thanks.
Great, I will merge.
-
pdureau →
committed 66f4a44d on 1.0.x authored by
mh_nichts →
Issue #3340340 by mh_nichts: New transcription component
-
pdureau →
committed 66f4a44d on 1.0.x authored by
mh_nichts →
Automatically closed - issue fixed for 2 weeks with no activity.