- Issue created by @mh_nichts
- First commit to issue fork.
- Assigned to spryah
- Status changed to Needs review
about 1 year ago 10:25am 3 November 2023 - @spryah opened merge request.
- Issue was unassigned.
- Status changed to Fixed
about 1 year ago 2:44pm 3 November 2023 - 🇫🇷France pdureau Paris
Hello Sorya,
I am not very comfortable with implementing some variants as proper variants:
variants: default: label: Vertical horizontal: label: Horizontal sm: label: Vertical small horizontal__sm: label: Horizontal small
And other variants as boolean props:
background: type: select options: default: Default (default) grey: Grey no-background: None icon: type: boolean border: type: boolean shadow: type: boolean
But they are not mutually exclusive, so I understand why you did that.
So I have merged
⚠️ icon added to issue title, because the removal of grey_hover is a breaking change.
Automatically closed - issue fixed for 2 weeks with no activity.