Week and day filter javascript error

Created on 8 February 2023, over 1 year ago
Updated 17 February 2023, over 1 year ago

Problem/Motivation

When I click on the week or day tabs, the following javascript error appears and the view does not change.

πŸ› Bug report
Status

Fixed

Version

5.1

Component

Code

Created by

πŸ‡ͺπŸ‡ΈSpain saesa

Live updates comments and jobs are added and updated live.
Sign in to follow issues

Comments & Activities

  • Issue created by @saesa
  • πŸ‡¬πŸ‡§United Kingdom darren.fisher

    I am also seeing this issue when using the next and previous month arrows.

  • πŸ‡¬πŸ‡§United Kingdom darren.fisher

    The issue does not occur in module version 5.1.9 so for now you can roll back to that in your composer.json until there is progress on this issue.

  • πŸ‡¨πŸ‡¦Canada rellis

    We see this too. 5.1.8 (which we rolled back to) also doesn't have the problem.

  • Reconfigure display format in view, fixes error

  • First commit to issue fork.
  • @mingsong opened merge request.
  • πŸ‡¦πŸ‡ΊAustralia mingsong πŸ‡¦πŸ‡Ί

    Here is the patch to test.

    https://git.drupalcode.org/project/fullcalendar_view/-/merge_requests/47...

    Let me know if it is fixed by this patch.

  • Status changed to Needs review over 1 year ago
  • πŸ‡¦πŸ‡ΊAustralia mingsong πŸ‡¦πŸ‡Ί
  • πŸ‡ͺπŸ‡ΈSpain saesa

    #6 πŸ› Week and day filter javascript error Fixed of @parzno this arrangement works for me, thanks!

  • πŸ‡ΊπŸ‡ΈUnited States momow

    #6 and patch #9 don't work for me. I also get the problem after searching a keyword and not getting any search result.

    I noticed that this problem disappeared when I changed the following code on the FullCalendarDsplay.php

    protected function defineOptions() {
    .............
    $options['minTime'] = ['default' => '2000-01-01 00:00:00'];
    $options['maxTime'] = ['default' => '2000-01-01 23:59:59'];
    ..............
    to
    ..............
    $options['minTime'] = ['default' => '00:00:00'];
    $options['maxTime'] = ['default' => '23:59:59'];
    ..............

    I saw the following code on the FullCalendarViewPreprocess.php

    public function process(array &$variables) {
    ...............
    // Display time limit.
    $minTime = !empty($options['minTime']) ? $options['minTime'] : '00:00:00';
    $maxTime = !empty($options['maxTime']) ? $options['maxTime'] : '23:59:59';
    ................

    It looks that there is a kind of mismatch format.

  • πŸ‡ΊπŸ‡ΈUnited States momow

    #6 and patch #9 don't work for me. I also get the problem after searching a keyword and not getting any search result.

    I noticed that this problem disappeared when I changed the following code on the FullCalendarDsplay.php

    protected function defineOptions() {
    .............
    $options['minTime'] = ['default' => '2000-01-01 00:00:00'];
    $options['maxTime'] = ['default' => '2000-01-01 23:59:59'];
    ..............
    to
    ..............
    $options['minTime'] = ['default' => '00:00:00'];
    $options['maxTime'] = ['default' => '23:59:59'];
    ..............

    I saw the following code on the FullCalendarViewPreprocess.php

    public function process(array &$variables) {
    ...............
    // Display time limit.
    $minTime = !empty($options['minTime']) ? $options['minTime'] : '00:00:00';
    $maxTime = !empty($options['maxTime']) ? $options['maxTime'] : '23:59:59';
    ................

    It looks that there is a kind of mismatch format.

  • πŸ‡¦πŸ‡ΊAustralia mingsong πŸ‡¦πŸ‡Ί

    What is your core version?

    • Mingsong β†’ committed 5f39004d on 5.x
      Issue #3340293 by saesa, darren.fisher, rellis, parzno, Mingsong: Week...
  • Status changed to Fixed over 1 year ago
  • πŸ‡¦πŸ‡ΊAustralia mingsong πŸ‡¦πŸ‡Ί

    I believe it is fixed.

    You can download the develop version to test it.

    https://www.drupal.org/project/fullcalendar_view/releases/5.x-dev β†’

    If you are still having this problem, please provide following information:

    • Any error or warning in Drupal logs
    • Any error in your browser console.
    • Your core version.
    • The Fullcalendar View module version.
    • PHP version.
    • Any other module provides the start or end date field. For example smart_date module.
  • Automatically closed - issue fixed for 2 weeks with no activity.

Production build 0.71.5 2024