- Issue created by @Anybody
- Status changed to Needs review
about 2 years ago 11:40pm 9 February 2023 - πΊπΈUnited States altagrade
Could you please uninstall the module, remove its files and give a new try to 2.0.x-dev as the last changes should address the issue.
- π©πͺGermany Anybody Porta Westfalica
Thanks for your feedback @AltaGrade but please note you already made a stable release. Having to uninstall the module and reinstall it again is not expected after beta phase anymore. If it works without re-installing, everything is fine. Otherwise it needs an update hook.
- π©πͺGermany Anybody Porta Westfalica
Just had a try with the latest dev and here's the status:
With AND Without reinstalling (even after clearing caches) the translatable field does not appear!
Here's a screenshot of the translation page:
- π©πͺGermany Anybody Porta Westfalica
My guess is, that this part of the schema isn't correct:
mapping: allowed_scripts: type: sequence label: 'Allowed language scripts:' translatable: true sequence: type: string label: 'Allowed language script:'
Instead the same logic as here should be used:
reject_message: type: text label: 'Reject message:' translatable: true
and it should be split later.
Alternatively perhaps
sequence: type: string label: 'Allowed language script:'
may need "translatable" or type: label:
sequence: type: label label: 'Allowed language script:'
?
- π©πͺGermany Anybody Porta Westfalica
And please let me say: GREAT module, thank you. No bad intentions here, just trying to help making this even better and more robust :)
- Status changed to Needs work
about 2 years ago 5:50pm 14 February 2023 - πΊπΈUnited States altagrade
Please make necessary changes on your local environment, test them well and if everything is working to your expectations, then file a PR. Thank you!
- π©πͺGermany Anybody Porta Westfalica
Thanks for your feedback, my hope was that you can instantly see what has to be done here.
But okay, we'll have a look at it asap.
- πΊπΈUnited States altagrade
Unfortunately, no time for even minor changes. As explained on https://www.drupal.org/project/protected_forms/issues/3340780#comment-14... β¨ Needs schema check and tests for all functionality Needs work we do not have any running Drupal 10 website with the module as our upstream branch is the Backdrop version on https://github.com/backdrop-contrib/protected_forms/