Allowed patterns are not translatable

Created on 8 February 2023, about 2 years ago
Updated 14 February 2023, about 2 years ago

Problem/Motivation

Allowed patterns are not translatable, while the others are.

They should be, as the patterns may differ per language.

Steps to reproduce

Proposed resolution

Remaining tasks

User interface changes

API changes

Data model changes

πŸ› Bug report
Status

Needs work

Version

2.0

Component

Code

Created by

πŸ‡©πŸ‡ͺGermany Anybody Porta Westfalica

Live updates comments and jobs are added and updated live.
Sign in to follow issues

Comments & Activities

  • Issue created by @Anybody
  • Status changed to Needs review about 2 years ago
  • πŸ‡ΊπŸ‡ΈUnited States altagrade

    Could you please uninstall the module, remove its files and give a new try to 2.0.x-dev as the last changes should address the issue.

  • πŸ‡©πŸ‡ͺGermany Anybody Porta Westfalica

    Thanks for your feedback @AltaGrade but please note you already made a stable release. Having to uninstall the module and reinstall it again is not expected after beta phase anymore. If it works without re-installing, everything is fine. Otherwise it needs an update hook.

  • πŸ‡©πŸ‡ͺGermany Anybody Porta Westfalica

    Just had a try with the latest dev and here's the status:

    With AND Without reinstalling (even after clearing caches) the translatable field does not appear!
    Here's a screenshot of the translation page:

  • πŸ‡©πŸ‡ͺGermany Anybody Porta Westfalica

    My guess is, that this part of the schema isn't correct:

     mapping:
            allowed_scripts:
              type: sequence
              label: 'Allowed language scripts:'
              translatable: true
              sequence:
                type: string
                label: 'Allowed language script:'
    

    Instead the same logic as here should be used:

    reject_message:
              type: text
              label: 'Reject message:'
              translatable: true

    and it should be split later.

    Alternatively perhaps

              sequence:
                type: string
                label: 'Allowed language script:'

    may need "translatable" or type: label:

              sequence:
                type: label
                label: 'Allowed language script:'

    ?

  • πŸ‡©πŸ‡ͺGermany Anybody Porta Westfalica

    And please let me say: GREAT module, thank you. No bad intentions here, just trying to help making this even better and more robust :)

  • Status changed to Needs work about 2 years ago
  • πŸ‡ΊπŸ‡ΈUnited States altagrade

    Please make necessary changes on your local environment, test them well and if everything is working to your expectations, then file a PR. Thank you!

  • πŸ‡©πŸ‡ͺGermany Anybody Porta Westfalica

    Thanks for your feedback, my hope was that you can instantly see what has to be done here.

    But okay, we'll have a look at it asap.

  • πŸ‡ΊπŸ‡ΈUnited States altagrade

    Unfortunately, no time for even minor changes. As explained on https://www.drupal.org/project/protected_forms/issues/3340780#comment-14... ✨ Needs schema check and tests for all functionality Needs work we do not have any running Drupal 10 website with the module as our upstream branch is the Backdrop version on https://github.com/backdrop-contrib/protected_forms/

Production build 0.71.5 2024