- Issue created by @volkerk
- @volkerk opened merge request.
- Status changed to Needs review
almost 2 years ago 9:36am 8 February 2023 - Status changed to RTBC
almost 2 years ago 12:52am 10 February 2023 - Status changed to Postponed: needs info
almost 2 years ago 9:54pm 10 February 2023 - 🇨🇭Switzerland saschaeggi Zurich
The close button appears to be correct. When I check out this branch locally it gets misplaced.
Does this issue appear with specific modules? As I seem not to be able to reproduce it. Do we need to add an additional
position: relative;to.ui-dialog .ui-dialog-titlebar {} - Status changed to Needs review
almost 2 years ago 5:03pm 8 March 2023 - 🇩🇪Germany volkerk
I tested again with drupal 9.5, drupal 10 using standard profile, with chrome latest and firefox esr on macos.
Strange enough positioning of the dialog close icon is too low for me under all of these conditions.I did a different solution now, similar to what claro is doing.
-
saschaeggi →
committed 0b83d23c on 8.x-3.x authored by
volkerk →
Issue #3340160: Fix dialog close icon pos
-
saschaeggi →
committed 0b83d23c on 8.x-3.x authored by
volkerk →
- Status changed to Fixed
almost 2 years ago 12:08pm 12 March 2023 - 🇨🇭Switzerland saschaeggi Zurich
This approach seems to work! Merged, thanks 🤝
Automatically closed - issue fixed for 2 weeks with no activity.