Drupal Coding Standards Issues | phpcs

Created on 2 February 2023, almost 2 years ago
Updated 8 July 2023, over 1 year ago

Problem/Motivation

Getting following error/warnings.

FILE: /var/www/html/modules/contrib/views_data_export_phpspreadsheet/README.md
------------------------------------------------------------------------------
FOUND 1 ERROR AND 1 WARNING AFFECTING 2 LINES
------------------------------------------------------------------------------
13 | WARNING | [ ] Line exceeds 80 characters; contains 84 characters
52 | ERROR | [x] Expected 1 newline at end of file; 2 found
------------------------------------------------------------------------------
PHPCBF CAN FIX THE 1 MARKED SNIFF VIOLATIONS AUTOMATICALLY
------------------------------------------------------------------------------

FILE: /var/www/html/modules/contrib/views_data_export_phpspreadsheet/views_data_export_phpspreadsheet.module
------------------------------------------------------------------------------------------------------------
FOUND 2 ERRORS AFFECTING 2 LINES
------------------------------------------------------------------------------------------------------------
11 | ERROR | [x] Namespaced classes/interfaces/traits should be referenced with use statements
15 | ERROR | [x] Case breaking statements must be followed by a single blank line
------------------------------------------------------------------------------------------------------------
PHPCBF CAN FIX THE 2 MARKED SNIFF VIOLATIONS AUTOMATICALLY
------------------------------------------------------------------------------------------------------------

FILE: /var/www/html/modules/contrib/views_data_export_phpspreadsheet/src/Encoder/XlsEncoder.php
-----------------------------------------------------------------------------------------------
FOUND 0 ERRORS AND 3 WARNINGS AFFECTING 3 LINES
-----------------------------------------------------------------------------------------------
109 | WARNING | \Drupal calls should be avoided in classes, use dependency injection instead
110 | WARNING | \Drupal calls should be avoided in classes, use dependency injection instead
348 | WARNING | \Drupal calls should be avoided in classes, use dependency injection instead
-----------------------------------------------------------------------------------------------

Time: 3.09 secs; Memory: 6MB

Steps to reproduce

Run following command

phpcs --standard=Drupal,DrupalPractice --extensions=php,module,inc,install,test,profile,theme,css,info,txt,md,yml modules/contrib/views_data_export_phpspreadsheet/

Proposed resolution

Above error/warnings need to be fixed.

📌 Task
Status

Fixed

Version

1.0

Component

Code

Created by

🇮🇳India samit.310@gmail.com

Live updates comments and jobs are added and updated live.
  • Coding standards

    It involves compliance with, or the content of coding standards. Requires broad community agreement.

Sign in to follow issues

Comments & Activities

Production build 0.71.5 2024