- Issue created by @Charchil Khandelwal
- Merge request !3Issue #3338270: Drupal Coding Standards Issues | phpcs → (Open) created by Charchil Khandelwal
- Issue was unassigned.
- Status changed to Needs review
almost 2 years ago 1:21pm 1 February 2023 - 🇮🇳India Charchil Khandelwal
Some errors and warnings are fixed now.
Created MR !3 for same, please review.Thank You.
- Assigned to gaurav-mathur
- Status changed to Needs work
almost 2 years ago 1:24pm 1 February 2023 FILE: ...\drupal\modules\nameday_skhu\src\Plugin\Block\NamedayBlockHu.php
----------------------------------------------------------------------
FOUND 3 ERRORS AFFECTING 3 LINES
----------------------------------------------------------------------
32 | ERROR | Missing parameter type
34 | ERROR | Missing parameter type
36 | ERROR | Missing parameter type
----------------------------------------------------------------------FILE: ...\drupal\modules\nameday_skhu\src\Plugin\Block\NamedayBlockSk.php
----------------------------------------------------------------------
FOUND 3 ERRORS AFFECTING 3 LINES
----------------------------------------------------------------------
32 | ERROR | Missing parameter type
34 | ERROR | Missing parameter type
36 | ERROR | Missing parameter type
----------------------------------------------------------------------Need to fix these errors.
- Issue was unassigned.
- Assigned to nitin_lama
- Status changed to Needs review
about 1 year ago 9:47am 4 December 2023 - 🇮🇳India nitin_lama India
Re-based and fixed conflicts in the MR.
Please review. Thanks. - Issue was unassigned.
- 🇮🇳India riddhi.addweb
I have applied the latest patch but still, there are some errors.
Please check the screenshot for the same.FILE: /var/www/html/web/drupal10/web/modules/contrib/nameday_skhu/src/Plugin/Block/NamedayBlockHu.php
---------------------------------------------------------------------------------------------------------------------------------------------
FOUND 2 ERRORS AFFECTING 2 LINES
---------------------------------------------------------------------------------------------------------------------------------------------
8 | ERROR | [x] Use statements should be sorted alphabetically. The first wrong one is Drupal\Core\Plugin\ContainerFactoryPluginInterface.
78 | ERROR | [x] @inheritDoc found. Did you mean {@inheritDoc}?
---------------------------------------------------------------------------------------------------------------------------------------------
PHPCBF CAN FIX THE 2 MARKED SNIFF VIOLATIONS AUTOMATICALLY
---------------------------------------------------------------------------------------------------------------------------------------------FILE: /var/www/html/web/drupal10/web/modules/contrib/nameday_skhu/src/Plugin/Block/NamedayBlockSk.php
---------------------------------------------------------------------------------------------------------------------------------------------
FOUND 2 ERRORS AFFECTING 2 LINES
---------------------------------------------------------------------------------------------------------------------------------------------
8 | ERROR | [x] Use statements should be sorted alphabetically. The first wrong one is Drupal\Core\Plugin\ContainerFactoryPluginInterface.
78 | ERROR | [x] @inheritDoc found. Did you mean {@inheritDoc}?
---------------------------------------------------------------------------------------------------------------------------------------------
PHPCBF CAN FIX THE 2 MARKED SNIFF VIOLATIONS AUTOMATICALLY
--------------------------------------------------------------------------------------------------------------------------------------------- - Status changed to Needs work
6 months ago 8:21am 8 July 2024