Drupal Coding Standards Issues | phpcs

Open on Drupal.org →

Created on 1 February 2023, over 1 year ago

Updated 4 December 2023, 7 months ago

Problem/Motivation

Getting following error/warnings.

FILE: C:\xampp\htdocs\abc\drupal\modules\nameday_skhu\README.md
----------------------------------------------------------------------
FOUND 0 ERRORS AND 1 WARNING AFFECTING 1 LINE
----------------------------------------------------------------------
18 | WARNING | Line exceeds 80 characters; contains 129 characters
----------------------------------------------------------------------

FILE: ...ampp\htdocs\abc\drupal\modules\nameday_skhu\src\NamedayClass.php
----------------------------------------------------------------------
FOUND 10 ERRORS AFFECTING 7 LINES
----------------------------------------------------------------------
10 | ERROR | Missing short description in doc comment
11 | ERROR | Missing parameter comment
12 | ERROR | Missing parameter comment
12 | ERROR | Missing parameter type
13 | ERROR | Missing parameter comment
13 | ERROR | Missing parameter type
14 | ERROR | Missing parameter comment
14 | ERROR | Missing parameter type
15 | ERROR | Description for the @return value is missing
211 | ERROR | Doc comment is empty
----------------------------------------------------------------------

FILE: ...\drupal\modules\nameday_skhu\src\Plugin\Block\NamedayBlockHu.php
----------------------------------------------------------------------
FOUND 9 ERRORS AFFECTING 8 LINES
----------------------------------------------------------------------
20 | ERROR | Missing short description in doc comment
25 | ERROR | Missing short description in doc comment
26 | ERROR | Missing parameter comment
26 | ERROR | Missing parameter name
33 | ERROR | Missing short description in doc comment
34 | ERROR | Missing parameter comment
35 | ERROR | Missing parameter comment
36 | ERROR | Missing parameter comment
37 | ERROR | Missing parameter comment
----------------------------------------------------------------------

FILE: ...\drupal\modules\nameday_skhu\src\Plugin\Block\NamedayBlockSk.php
----------------------------------------------------------------------
FOUND 9 ERRORS AFFECTING 8 LINES
----------------------------------------------------------------------
20 | ERROR | Missing short description in doc comment
25 | ERROR | Missing short description in doc comment
26 | ERROR | Missing parameter comment
26 | ERROR | Missing parameter name
33 | ERROR | Missing short description in doc comment
34 | ERROR | Missing parameter comment
35 | ERROR | Missing parameter comment
36 | ERROR | Missing parameter comment
37 | ERROR | Missing parameter comment
----------------------------------------------------------------------

Steps to reproduce

Run following command

phpcs --standard=Drupal,DrupalPractice --extensions=php,module,inc,install,test,profile,theme,css,info,txt,md,yml modules/contrib/nameday_skhu/

Proposed resolution

Above error/warnings need to be fixed.

🐛 Bug report

Status

Needs review

Version

1.0

Component

Code

Created by

🇮🇳India Charchil Khandelwal

Live updates comments and jobs are added and updated live.

Sign in to follow issues

Merge Requests

!3Drupal Coding Standards Issues | phpcs
Open
🇮🇳India Charchil Khandelwal
updated 7 months ago

Comments & Activities

Issue created by @Charchil Khandelwal
Merge request !3Issue #3338270: Drupal Coding Standards Issues | phpcs → (Open) created by Charchil Khandelwal
Issue was unassigned.
Status changed to Needs review over 1 year ago1:21pm 1 February 2023
Comment over 1 year ago →
🇮🇳India Charchil Khandelwal
Some errors and warnings are fixed now.
Created MR !3 for same, please review.

Thank You.
Assigned to gaurav-mathur
Comment over 1 year ago →
gaurav-mathur
I will review this MR.
Status changed to Needs work over 1 year ago1:24pm 1 February 2023
Comment over 1 year ago →
gaurav-mathur
FILE: ...\drupal\modules\nameday_skhu\src\Plugin\Block\NamedayBlockHu.php
----------------------------------------------------------------------
FOUND 3 ERRORS AFFECTING 3 LINES
----------------------------------------------------------------------
32 | ERROR | Missing parameter type
34 | ERROR | Missing parameter type
36 | ERROR | Missing parameter type
----------------------------------------------------------------------

FILE: ...\drupal\modules\nameday_skhu\src\Plugin\Block\NamedayBlockSk.php
----------------------------------------------------------------------
FOUND 3 ERRORS AFFECTING 3 LINES
----------------------------------------------------------------------
32 | ERROR | Missing parameter type
34 | ERROR | Missing parameter type
36 | ERROR | Missing parameter type
----------------------------------------------------------------------

Need to fix these errors.
Issue was unassigned.
Comment over 1 year ago →
gaurav-mathur
Comment 7 months ago →
bindu r
bindu r → made their first commit to this issue’s fork.
Assigned to nitin_lama
Comment 7 months ago →
🇮🇳India nitin_lama
Status changed to Needs review 7 months ago9:47am 4 December 2023
Comment 7 months ago →
🇮🇳India nitin_lama
Re-based and fixed conflicts in the MR.
Please review. Thanks.
Issue was unassigned.
Comment 7 months ago →
🇮🇳India nitin_lama

contrib.social Blog FAQ Discussions

Production build 0.69.0 2024