- Issue created by @jay jangid
- Merge request !4Issue #3338205: Update README.md file according to "README.md template" → (Closed) created by jay jangid
- Issue was unassigned.
- Status changed to Needs review
almost 2 years ago 10:19am 1 February 2023 - 🇮🇳India Nupur Badola
There are issue of whitespaces:
git.drupalcode.org_project_straw_-_merge_requests_4.diff.txt:71: trailing whitespace. Install this module via composer by running the git.drupalcode.org_project_straw_-_merge_requests_4.diff.txt:101: trailing whitespace. "`Travel >> Tourist Destinations`" will create two terms, "`Travel`" warning: 2 lines add whitespace errors.
- Status changed to Needs work
over 1 year ago 9:57am 12 September 2023 - Assigned to nitin_lama
- Open on Drupal.org →Core: 10.0.7 + Environment: PHP 7.4 & MySQL 5.7last update
over 1 year ago Waiting for branch to pass - Issue was unassigned.
- Status changed to Needs review
over 1 year ago 10:00am 14 September 2023 - Status changed to RTBC
about 1 year ago 11:00pm 25 September 2023 - 🇵🇭Philippines kenyoOwen
Hi nitin_lama
I applied and reviewed your MR!4 but it is not following the README.md template. In the requirements section, it should be "This module requires no modules outside of Drupal core." since the module doesn't need any module outside or before they install the module. Please also remove this "Install this module via composer by running the following command: `composer require drupal/straw`" in the installation section. Please look at the screenshot I attached for your reference
Thank you
- Status changed to Needs work
about 1 year ago 12:49am 26 September 2023 - Assigned to nitin_lama
- Open on Drupal.org →Core: 10.0.7 + Environment: PHP 7.4 & MySQL 5.7last update
about 1 year ago Waiting for branch to pass - Issue was unassigned.
- Status changed to Needs review
about 1 year ago 7:22am 26 September 2023 - Status changed to RTBC
about 1 year ago 7:27am 11 October 2023 - 🇮🇳India Nupur Badola
Reviewed MR!4, File is updated as per readme.md file template. Hence, marking it to RTBC.
- 0459fee7 committed on 2.x
Issue #3338205: Update README.md file according to "README.md template"
- 0459fee7 committed on 2.x
- Status changed to Fixed
11 months ago 5:48pm 19 January 2024 - 🇵🇹Portugal jcnventura
Fixed. No credit given to anyone, since this type of issue is a frequent target of credit harvesting.
Automatically closed - issue fixed for 2 weeks with no activity.