Fix the issues reported by phpcs

$ phpcs --standard=Drupal time_field FILE: C:\Users\Admin\Desktop\task\time_field\src\Element\TimeElement.php -------------------------------------------------------------------------------- FOUND 2 ERRORS AFFECTING 2 LINES -------------------------------------------------------------------------------- 1 | ERROR | [x] End of line character is invalid; expected "\n" but found | | "\r\n" 16 | ERROR | [ ] Long array syntax must not be used in doc comment code | | annotations -------------------------------------------------------------------------------- PHPCBF CAN FIX THE 1 MARKED SNIFF VIOLATIONS AUTOMATICALLY -------------------------------------------------------------------------------- FILE: ...\Desktop\task\time_field\src\Plugin\Field\FieldFormatter\TimeFormatter.php -------------------------------------------------------------------------------- FOUND 1 ERROR AFFECTING 1 LINE -------------------------------------------------------------------------------- 1 | ERROR | [x] End of line character is invalid; expected "\n" but found | | "\r\n" -------------------------------------------------------------------------------- PHPCBF CAN FIX THE 1 MARKED SNIFF VIOLATIONS AUTOMATICALLY -------------------------------------------------------------------------------- FILE: ...top\task\time_field\src\Plugin\Field\FieldFormatter\TimeRangeFormatter.php -------------------------------------------------------------------------------- FOUND 1 ERROR AFFECTING 1 LINE -------------------------------------------------------------------------------- 1 | ERROR | [x] End of line character is invalid; expected "\n" but found | | "\r\n" -------------------------------------------------------------------------------- PHPCBF CAN FIX THE 1 MARKED SNIFF VIOLATIONS AUTOMATICALLY -------------------------------------------------------------------------------- FILE: ...Admin\Desktop\task\time_field\src\Plugin\Field\FieldType\TimeRangeType.php -------------------------------------------------------------------------------- FOUND 1 ERROR AFFECTING 1 LINE -------------------------------------------------------------------------------- 1 | ERROR | [x] End of line character is invalid; expected "\n" but found | | "\r\n" -------------------------------------------------------------------------------- PHPCBF CAN FIX THE 1 MARKED SNIFF VIOLATIONS AUTOMATICALLY -------------------------------------------------------------------------------- FILE: ...sers\Admin\Desktop\task\time_field\src\Plugin\Field\FieldType\TimeType.php -------------------------------------------------------------------------------- FOUND 1 ERROR AFFECTING 1 LINE -------------------------------------------------------------------------------- 1 | ERROR | [x] End of line character is invalid; expected "\n" but found | | "\r\n" -------------------------------------------------------------------------------- PHPCBF CAN FIX THE 1 MARKED SNIFF VIOLATIONS AUTOMATICALLY -------------------------------------------------------------------------------- FILE: ...n\Desktop\task\time_field\src\Plugin\Field\FieldWidget\TimeRangeWidget.php -------------------------------------------------------------------------------- FOUND 1 ERROR AFFECTING 1 LINE -------------------------------------------------------------------------------- 1 | ERROR | [x] End of line character is invalid; expected "\n" but found | | "\r\n" -------------------------------------------------------------------------------- PHPCBF CAN FIX THE 1 MARKED SNIFF VIOLATIONS AUTOMATICALLY -------------------------------------------------------------------------------- FILE: ...\Admin\Desktop\task\time_field\src\Plugin\Field\FieldWidget\TimeWidget.php -------------------------------------------------------------------------------- FOUND 1 ERROR AFFECTING 1 LINE -------------------------------------------------------------------------------- 1 | ERROR | [x] End of line character is invalid; expected "\n" but found | | "\r\n" -------------------------------------------------------------------------------- PHPCBF CAN FIX THE 1 MARKED SNIFF VIOLATIONS AUTOMATICALLY -------------------------------------------------------------------------------- FILE: ...esktop\task\time_field\src\Plugin\Validation\Constraint\TimeConstraint.php -------------------------------------------------------------------------------- FOUND 1 ERROR AFFECTING 1 LINE -------------------------------------------------------------------------------- 1 | ERROR | [x] End of line character is invalid; expected "\n" but found | | "\r\n" -------------------------------------------------------------------------------- PHPCBF CAN FIX THE 1 MARKED SNIFF VIOLATIONS AUTOMATICALLY -------------------------------------------------------------------------------- FILE: ...sk\time_field\src\Plugin\Validation\Constraint\TimeConstraintValidator.php -------------------------------------------------------------------------------- FOUND 1 ERROR AND 1 WARNING AFFECTING 2 LINES -------------------------------------------------------------------------------- 1 | ERROR | [x] End of line character is invalid; expected "\n" but found | | "\r\n" 13 | WARNING | [ ] The class short comment should describe what the class does | | and not simply repeat the class name -------------------------------------------------------------------------------- PHPCBF CAN FIX THE 1 MARKED SNIFF VIOLATIONS AUTOMATICALLY -------------------------------------------------------------------------------- FILE: C:\Users\Admin\Desktop\task\time_field\src\Time.php -------------------------------------------------------------------------------- FOUND 2 ERRORS AFFECTING 2 LINES -------------------------------------------------------------------------------- 1 | ERROR | [x] End of line character is invalid; expected "\n" but found | | "\r\n" 168 | ERROR | [x] list(...) is forbidden, use [...] instead. -------------------------------------------------------------------------------- PHPCBF CAN FIX THE 2 MARKED SNIFF VIOLATIONS AUTOMATICALLY -------------------------------------------------------------------------------- FILE: C:\Users\Admin\Desktop\task\time_field\tests\src\Unit\TimeTest.php -------------------------------------------------------------------------------- FOUND 1 ERROR AFFECTING 1 LINE -------------------------------------------------------------------------------- 1 | ERROR | [x] End of line character is invalid; expected "\n" but found | | "\r\n" -------------------------------------------------------------------------------- PHPCBF CAN FIX THE 1 MARKED SNIFF VIOLATIONS AUTOMATICALLY -------------------------------------------------------------------------------- FILE: C:\Users\Admin\Desktop\task\time_field\time_field.tokens.inc -------------------------------------------------------------------------------- FOUND 1 ERROR AFFECTING 1 LINE -------------------------------------------------------------------------------- 1 | ERROR | [x] End of line character is invalid; expected "\n" but found | | "\r\n" -------------------------------------------------------------------------------- PHPCBF CAN FIX THE 1 MARKED SNIFF VIOLATIONS AUTOMATICALLY -------------------------------------------------------------------------------- Time: 568ms; Memory: 8MB

Comments & Activities

Issue created by @jay jangid
@jay-jangid opened merge request.
Issue was unassigned.
Status changed to Needs review over 2 years ago11:32am 31 January 2023
Comment over 2 years ago →
🇮🇳India jay jangid Jaipur
Created MR , please review.

Thank you.
Assigned to Sonal Gyanani
Comment over 2 years ago →
🇮🇳India Sonal Gyanani
Issue was unassigned.
Status changed to RTBC over 2 years ago12:34pm 31 January 2023
Comment over 2 years ago →
🇮🇳India Sonal Gyanani
Thanks @Jay Jangid, MR looks good to me so moving it to RTBC
Comment over 2 years ago →
🇧🇪Belgium BramDriesen Belgium 🇧🇪
This is not ok. Why would the removal of usage example pass review?

@Sonal Gyanani I know what you and your team are doing. But please perform actual code reviews.
Status changed to Needs work about 2 years ago7:38pm 1 May 2023
Comment about 2 years ago →
🇮🇹Italy apaderno Brescia, 🇮🇹
/** - * TimeConstraintValidator. - * - * @package Drupal\time_field\Plugin\Validation\Constraint + * Summary of TimeConstraintValidator. */ class TimeConstraintValidator extends ConstraintValidator {
Furthermore, the short description for a class does not start with Summary of.
That description does not even make sense. Is a class a summary of itself?
Status changed to Closed: duplicate over 1 year ago9:12pm 5 December 2023
Comment over 1 year ago →
🇧🇪Belgium BramDriesen Belgium 🇧🇪
Closing as duplicate as I'm fixing this as part of the GitLab CI adoption.

Fix the issues reported by phpcs

Problem/Motivation

Proposed resolution

Comments & Activities