Drupal Coding Standards Issues | phpcs

$ phpcs --standard=Drupal choices FILE: C:\Users\Admin\Desktop\task\choices\css\choices.css -------------------------------------------------------------------------------- FOUND 1 ERROR AFFECTING 1 LINE -------------------------------------------------------------------------------- 1 | ERROR | [x] End of line character is invalid; expected "\n" but found | | "\r\n" -------------------------------------------------------------------------------- PHPCBF CAN FIX THE 1 MARKED SNIFF VIOLATIONS AUTOMATICALLY -------------------------------------------------------------------------------- FILE: C:\Users\Admin\Desktop\task\choices\js\choices_global.js -------------------------------------------------------------------------------- FOUND 2 ERRORS AFFECTING 2 LINES -------------------------------------------------------------------------------- 1 | ERROR | [x] End of line character is invalid; expected "\n" but found | | "\r\n" 35 | ERROR | [x] Expected 1 space after FUNCTION keyword; 0 found -------------------------------------------------------------------------------- PHPCBF CAN FIX THE 2 MARKED SNIFF VIOLATIONS AUTOMATICALLY -------------------------------------------------------------------------------- FILE: C:\Users\Admin\Desktop\task\choices\js\choices_widget.js -------------------------------------------------------------------------------- FOUND 2 ERRORS AFFECTING 2 LINES -------------------------------------------------------------------------------- 1 | ERROR | [x] End of line character is invalid; expected "\n" but found | | "\r\n" 25 | ERROR | [x] Expected 1 space after FUNCTION keyword; 0 found -------------------------------------------------------------------------------- PHPCBF CAN FIX THE 2 MARKED SNIFF VIOLATIONS AUTOMATICALLY -------------------------------------------------------------------------------- FILE: ...ers\Admin\Desktop\task\choices\modules\choices_facets\js\choices-widget.js -------------------------------------------------------------------------------- FOUND 2 ERRORS AFFECTING 2 LINES -------------------------------------------------------------------------------- 1 | ERROR | [x] End of line character is invalid; expected "\n" but found | | "\r\n" 26 | ERROR | [x] TRUE, FALSE and NULL must be uppercase; expected "FALSE" but | | found "false" -------------------------------------------------------------------------------- PHPCBF CAN FIX THE 2 MARKED SNIFF VIOLATIONS AUTOMATICALLY -------------------------------------------------------------------------------- FILE: ...\choices\modules\choices_facets\src\Plugin\facets\widget\ChoicesWidget.php -------------------------------------------------------------------------------- FOUND 1 ERROR AFFECTING 1 LINE -------------------------------------------------------------------------------- 1 | ERROR | [x] End of line character is invalid; expected "\n" but found | | "\r\n" -------------------------------------------------------------------------------- PHPCBF CAN FIX THE 1 MARKED SNIFF VIOLATIONS AUTOMATICALLY -------------------------------------------------------------------------------- FILE: C:\Users\Admin\Desktop\task\choices\src\ChoicesCallbacks.php -------------------------------------------------------------------------------- FOUND 1 ERROR AFFECTING 1 LINE -------------------------------------------------------------------------------- 1 | ERROR | [x] End of line character is invalid; expected "\n" but found | | "\r\n" -------------------------------------------------------------------------------- PHPCBF CAN FIX THE 1 MARKED SNIFF VIOLATIONS AUTOMATICALLY -------------------------------------------------------------------------------- FILE: C:\Users\Admin\Desktop\task\choices\src\Form\ConfigForm.php -------------------------------------------------------------------------------- FOUND 5 ERRORS AFFECTING 5 LINES -------------------------------------------------------------------------------- 1 | ERROR | [x] End of line character is invalid; expected "\n" but found | | "\r\n" 111 | ERROR | [x] Array indentation error, expected 8 spaces but found 0 112 | ERROR | [x] Array indentation error, expected 8 spaces but found 0 113 | ERROR | [x] Array indentation error, expected 8 spaces but found 0 114 | ERROR | [x] Array indentation error, expected 8 spaces but found 0 -------------------------------------------------------------------------------- PHPCBF CAN FIX THE 5 MARKED SNIFF VIOLATIONS AUTOMATICALLY -------------------------------------------------------------------------------- FILE: ...\Admin\Desktop\task\choices\src\Plugin\Field\FieldWidget\ChoicesWidget.php -------------------------------------------------------------------------------- FOUND 5 ERRORS AFFECTING 5 LINES -------------------------------------------------------------------------------- 1 | ERROR | [x] End of line character is invalid; expected "\n" but found | | "\r\n" 52 | ERROR | [x] Array indentation error, expected 8 spaces but found 0 53 | ERROR | [x] Array indentation error, expected 8 spaces but found 0 54 | ERROR | [x] Array indentation error, expected 8 spaces but found 0 55 | ERROR | [x] Array indentation error, expected 8 spaces but found 0 -------------------------------------------------------------------------------- PHPCBF CAN FIX THE 5 MARKED SNIFF VIOLATIONS AUTOMATICALLY -------------------------------------------------------------------------------- FILE: ...\Admin\Desktop\task\choices\tests\src\Functional\ChoicesFunctionalTest.php -------------------------------------------------------------------------------- FOUND 1 ERROR AFFECTING 1 LINE -------------------------------------------------------------------------------- 1 | ERROR | [x] End of line character is invalid; expected "\n" but found | | "\r\n" -------------------------------------------------------------------------------- PHPCBF CAN FIX THE 1 MARKED SNIFF VIOLATIONS AUTOMATICALLY -------------------------------------------------------------------------------- FILE: ...k\choices\tests\src\FunctionalJavascript\ChoicesGlobalFunctionalJsTest.php -------------------------------------------------------------------------------- FOUND 1 ERROR AFFECTING 1 LINE -------------------------------------------------------------------------------- 1 | ERROR | [x] End of line character is invalid; expected "\n" but found | | "\r\n" -------------------------------------------------------------------------------- PHPCBF CAN FIX THE 1 MARKED SNIFF VIOLATIONS AUTOMATICALLY -------------------------------------------------------------------------------- FILE: ...sk\choices\tests\src\FunctionalJavascript\ChoicesMixedFunctionalJsTest.php -------------------------------------------------------------------------------- FOUND 1 ERROR AFFECTING 1 LINE -------------------------------------------------------------------------------- 1 | ERROR | [x] End of line character is invalid; expected "\n" but found | | "\r\n" -------------------------------------------------------------------------------- PHPCBF CAN FIX THE 1 MARKED SNIFF VIOLATIONS AUTOMATICALLY -------------------------------------------------------------------------------- FILE: ...k\choices\tests\src\FunctionalJavascript\ChoicesWidgetFunctionalJsTest.php -------------------------------------------------------------------------------- FOUND 1 ERROR AFFECTING 1 LINE -------------------------------------------------------------------------------- 1 | ERROR | [x] End of line character is invalid; expected "\n" but found | | "\r\n" -------------------------------------------------------------------------------- PHPCBF CAN FIX THE 1 MARKED SNIFF VIOLATIONS AUTOMATICALLY -------------------------------------------------------------------------------- FILE: ...:\Users\Admin\Desktop\task\choices\tests\src\Traits\ChoicesHelperTrait.php -------------------------------------------------------------------------------- FOUND 1 ERROR AFFECTING 1 LINE -------------------------------------------------------------------------------- 1 | ERROR | [x] End of line character is invalid; expected "\n" but found | | "\r\n" -------------------------------------------------------------------------------- PHPCBF CAN FIX THE 1 MARKED SNIFF VIOLATIONS AUTOMATICALLY -------------------------------------------------------------------------------- Time: 643ms; Memory: 10MB

Comments & Activities

Issue created by @jay jangid
@jay-jangid opened merge request.
Issue was unassigned.
Status changed to Needs review about 2 years ago10:25am 31 January 2023
Comment about 2 years ago →
🇮🇳India jay jangid Jaipur
Created MR , please review.

Thank you.
Assigned to Grevil
Comment about 2 years ago →
🇩🇪Germany Anybody Porta Westfalica
Status changed to RTBC about 2 years ago2:25pm 31 January 2023
Comment about 2 years ago →
🇩🇪Germany Grevil
Nice! LGTM!
Status changed to Fixed about 2 years ago2:25pm 31 January 2023
Comment about 2 years ago →
🇩🇪Germany Grevil
Comment about 2 years ago →
System Message

Jay Jangid → committed f4c985ed on 2.x
Issue #3337851: Drupal Coding Standards Issues | phpcs
Comment about 2 years ago →
System Message
Automatically closed - issue fixed for 2 weeks with no activity.
Status changed to Fixed about 2 years ago10:33pm 18 March 2023

Comment about 2 years ago →

🇩🇪Germany tobiasb Berlin

This should be reverted. It change JS false to FALSE, json placeholder, which results into:

{
    "allowHTML": true,
    "delimiter": ",",
    "searchFields": ["label", "value"]
        }

and not into:

{
    "allowHTML": true,
    "delimiter": ",",
    "searchFields": ["label", "value"]
}

Comment about 2 years ago →
🇩🇪Germany Anybody Porta Westfalica
@tobiasb thank you! Sorry I didn't see this.
@Grevil could you please just fix that single line in modules/choices_facets/js/choices-widget.js and create a new release?

@Jay Jangid NEVER write TRUE in JavaScript! It's just a Drupal constant for PHP! I already said that in another issue where someone switched off his brain just to get the credits and even having his tools configured wrong... This makes me angry. Then just better leave it as-is and stop wasting everyones time...
Comment about 2 years ago →
🇩🇪Germany Anybody Porta Westfalica
Status changed to Needs work about 2 years ago9:00am 19 March 2023
Comment about 2 years ago →
🇩🇪Germany Anybody Porta Westfalica
Comment about 2 years ago →
🇩🇪Germany Anybody Porta Westfalica

Comment about 2 years ago →

System Message

Anybody → committed 861bccb1 on 2.x

Fixed regression from Issue #3337851 by Anybody, Grevil, tobiasb: Drupal...

Issue was unassigned.
Status changed to Fixed about 2 years ago9:09am 19 March 2023
Comment about 2 years ago →
🇩🇪Germany Anybody Porta Westfalica
Fixed in 2.1.4 - thank you @tobiasb
Comment about 2 years ago →
System Message
Automatically closed - issue fixed for 2 weeks with no activity.

Drupal Coding Standards Issues | phpcs

Problem/Motivation

Proposed resolution

Comments & Activities