- Issue created by @samit.310@gmail.com
- Issue was unassigned.
- Status changed to Needs review
almost 2 years ago 4:36am 30 January 2023 - ๐ฎ๐ณIndia Charchil Khandelwal
Charchil Khandelwal โ made their first commit to this issueโs fork.
- Assigned to Charchil Khandelwal
- ๐ฎ๐ณIndia Charchil Khandelwal
Patch #2 tested and appied successfully. All the errors and warnings are fixed now.
- @charchil-khandelwal opened merge request.
- Issue was unassigned.
- ๐ฎ๐ณIndia Charchil Khandelwal
Created MR for same.
Please review.Thank You.
- Status changed to RTBC
almost 2 years ago 10:39am 31 January 2023 Thanks, its looks good now.
So, moving to RTBC.Thank You.
- Status changed to Needs work
about 1 year ago 12:32am 14 December 2023 - ๐บ๐ธUnited States mark_fullmer Tucson
The current code shows additional coding standards problems and deprecation notices. These should be included in this fix:
Line src/Plugin/Block/UpdatedDateBlock.php
------ ------------------------------------------------------------------------------
86 Unsafe usage of new static().
๐ก See:
https://phpstan.org/blog/solving-phpstan-error-unsafe-usage-of-new-static
177 Call to deprecated function system_time_zones():
in drupal:10.1.0 and is removed from drupal:11.0.0. This function
is no longer used in Drupal core. Use
\Drupal\Core\Datetime\TimeZoneFormHelper::getOptionsList() or
\DateTimeZone::listIdentifiers() instead.FILE: ...ect/updated/web/modules/custom/updated/tests/src/Functional/EntityTest.php
--------------------------------------------------------------------------------
FOUND 1 ERROR AFFECTING 1 LINE
--------------------------------------------------------------------------------
6 | ERROR | [x] Use statements should be sorted alphabetically. The first
| | wrong one is Drupal\Tests\BrowserTestBase.
| | (SlevomatCodingStandard.Namespaces.AlphabeticallySortedUses.IncorrectlyOrderedUses)
-------------------------------------------------------------------------------- -
mark_fullmer โ
committed b93b1631 on 1.x
Issue #3337438 by Charchil Khandelwal, samit.310@gmail.com, mark_fullmer...
-
mark_fullmer โ
committed b93b1631 on 1.x
- Status changed to Fixed
about 1 year ago 12:53am 14 December 2023 Automatically closed - issue fixed for 2 weeks with no activity.