- Assigned to Grevil
- Status changed to Needs review
almost 2 years ago 2:03pm 20 January 2023 - Status changed to Needs work
almost 2 years ago 7:16am 23 January 2023 - 🇩🇪Germany Grevil
As of #6, I'll put this back to needs work, so @thomas.frobieter can decide how to continue here?!
@thomas.frobieter would it instead make sense to inherit the attributes from the core template?
As mentioned in the issue description, there are no classes/attributes in the core template, so there is nothing to inherit.
So best would be to extend the currently active theme twig files implementation?
This direction doesnt make any sense to me in context of this module. Fences Blocks provides the "base block template", it simply won't work in the other direction and I have no idea how it should (technicaly).
- Status changed to Fixed
almost 2 years ago 8:17am 23 January 2023 - 🇩🇪Germany Grevil
Created a new rc2 release with the fixes from this issue!
Should we also commit this change to the 8.x branch?
Yes, is think this is an improvement for the 8.x block.html.twig too and mhm.. yeah, seems very unlikely to break things.
- @anybody opened merge request.
- 🇩🇪Germany Anybody Porta Westfalica
To sum things up here finally, after discussing this with @thomas.frobieter:
Due to logical and technical reasons, we'll leave things as-is for now!
- fences_blocks needs to overwrite the basic block implementation as it makes heavy changes, so extending the active template won't be helpful in most cases (but still discussable)
- It's not that easy in the override order to extend things as we'd like to. See related issues.
Perhaps we'll come to solutions and ideas later in a follow-up or if there are heavy issues. Currently this seems most robust way.
Automatically closed - issue fixed for 2 weeks with no activity.