- Status changed to Needs review
almost 2 years ago 3:50pm 19 January 2023 - Status changed to Needs work
almost 2 years ago 8:08pm 19 January 2023 - Status changed to Needs review
almost 2 years ago 9:30pm 19 January 2023 - π§πͺBelgium wim leers Ghent π§πͺπͺπΊ
Ran into this problem too over at #3334243-12: CDN 4.x requires PHP >=8.1 but composer does not respect it due to bug in d.o composer facade β . Pity that tweaking
drupalci.yml
does not work at all per #10, but at least I don't have to experiment with that now thanks to @alexpott in #10 πApparently nobody reported the need for
allow-plugins
support at: https://www.drupal.org/project/issues/project_issue_file_test?text=allow... β π€―Then discovered that #3265092: [META] Define a default .gitlab-ci.yml template that projects can inherit β has been silent for >11 months β¦ so not very hopeful about the GitLab CI approach either. But trying it anyway: #3334243-14: CDN 4.x requires PHP >=8.1 but composer does not respect it due to bug in d.o composer facade β .
- π¨πSwitzerland berdir Switzerland
FWIW, the drupalspoons template which seems to be pretty much the only thing out there at the moment only just hardcodes a bunch of specific plugins: https://gitlab.com/drupalspoons/composer-plugin/-/raw/master/bin/setup. To customize that, you would need to copy that whole file and add your own?
I think the only reason that "works" for you Wim is that it doesn't include any of the magic that DrupalCI does and does not actually automatically include require-dev dependencies.
Changing to a feature request, as commented in #3265092: [META] Define a default .gitlab-ci.yml template that projects can inherit β , can't we just allow all plugins and move on? The security aspect of that seems irrelevant, as we're running literally any PHP code that's in the repository that's being tested.
- @berdir opened merge request.
- π¨πSwitzerland berdir Switzerland
If I understand this correctly, we'd need to add the allow-all plugins to https://git.drupalcode.org/project/drupalci_testbot/-/blob/dev/src/Drupa..., before the composer require of the project.
so, run this command there:
composer config allow-plugins true
Created that as a merge request, but the integration doesn't seem to fully work here, so I did that manually, directly in Gitlab and its Web IDE. Obviously entirely untested :)
https://git.drupalcode.org/project/drupalci_testbot/-/merge_requests/9
- πΊπΈUnited States moshe weitzman Boston, MA
FWIW, the drupalspoons template which seems to be pretty much the only thing out there at the moment only just hardcodes a bunch of specific plugins: https://gitlab.com/drupalspoons/composer-plugin/-/raw/master/bin/setup. To customize that, you would need to copy that whole file and add your own?
You an allow whatever plugins you want in your project's composer.json and those will be honored/used by DrupalSpoons. The nones you saw there are auto-allowed so that projects dont *have* to explicitly allow them.
- First commit to issue fork.
- πΊπΈUnited States hestenet Portland, OR πΊπΈ
Merged into drupalci_testbot:production - sorry for such a long delay on a straightforward change. Many different priorities swirling around and I simply lost track. Thanks to those who pinged in Slack for an update.
Before marking fixed - would someone please test this on an affected issue and confirm it is resolved?
- @berdir opened merge request.
- πΊπΈUnited States cmlara
Note it appears this might have broken testing on PHP 7.4 images, due to a bug in composer, see #3381247: Composer config failure when running functional tests β