- Issue was unassigned.
- Status changed to Needs review
almost 2 years ago 9:32am 19 January 2023 - 🇧🇪Belgium michaelsoetaert
I've tested the proposed solution and can confirm that it works with
drupal/token 1.11.0
. - Status changed to Needs work
over 1 year ago 10:49pm 19 May 2023 - 🇦🇺Australia darvanen Sydney, Australia
It mostly works, however
drupalSettings.tokenFocusedCkeditor5
doesn't get updated when the text_format is changed (found this while testing for ✨ [PP-1] Support CKEditor 5 Postponed .I'm looking into ways to improve this. I think I could override that setting from within the token_filter module when a user clicks the browser button using a CKEditor5 emitter, but I'd rather take a more holistic approach if possible.
Any ideas?
- 🇦🇺Australia darvanen Sydney, Australia
I decided to work around #6 within the token_filter plugin like this:
this.listenTo(buttonView, "execute", () => { drupalSettings.tokenFocusedCkeditor5 = this.editor; this.editor.execute("tokenBrowser") });
This change for token now looks good to me from manual testing.
- Status changed to RTBC
over 1 year ago 10:44pm 23 May 2023 - 🇳🇴Norway zaporylie
Perhaps Token module could adapt to CKEditor's Content Placeholder feature, currently (awaiting) support via ✨ Ckeditor5 readiness Needs review ?
- 🇯🇵Japan tyler36 Osaka
Confirming: MR!36 fixes issue for me on Drupal
10.1
- 🇺🇸United States BenStallings
I must be missing something... I've got MR!36 in place, but I don't see any interface element available to browse and insert tokens. Is there another step required to make this available?
- last update
about 1 year ago 77 pass - 🇮🇳India vakulrai
Uploading the patch diff from : https://git.drupalcode.org/project/token/-/merge_requests/36/diffs for visibility.
Hi.
Like BenStellings #11 I've applied the patch to 1.12 on D10.1.4.
The patch applies cleanly however there is no available button relating to Tokens in the CKEditor available list.
Is there a step needed to make this button available to drag to the toolbar?
Many thanks
- 🇦🇺Australia darvanen Sydney, Australia
@a_nut the CKEditor button is provided by token_filter in a related issue which is postponed on this one.
✨ [PP-1] Support CKEditor 5 Postponed
- First commit to issue fork.
- last update
about 1 year ago 77 pass - last update
about 1 year ago 77 pass -
Berdir →
committed 52942ecc on 8.x-1.x authored by
tgauges →
Issue #3334784 by vakulrai: Implement Token-Click-Insert for CKEditor 5
-
Berdir →
committed 52942ecc on 8.x-1.x authored by
tgauges →
- Status changed to Fixed
about 1 year ago 10:08am 21 October 2023 Automatically closed - issue fixed for 2 weeks with no activity.
- Status changed to Fixed
7 months ago 1:20pm 16 April 2024 - 🇺🇦Ukraine tarazingo Kyiv
Hi everyone,
There is a small issue when you edit the node with paragraphs inside. If the paragraphs with the CKEditor field already exist, it works correctly, but when you add a new paragraph with the CKEditor field, the token insertion does not work.
Due to the presence of drupalSettings.tokenFocusedField and drupalSettings.tokenFocusedCkeditor5 in the same scope, the insertion is made to the hidden textarea field instead of the CKEditor widget. I've attached a patch that resolves this issue.