Handle valid words from other languages consistently in cspell

Created on 13 January 2023, about 2 years ago
Updated 16 February 2024, about 1 year ago

Problem/Motivation

There are parts of the code in French and Dutch, and maybe other languages.
Overall, real words in foreign languages should be handled on a per-sentence or per-test basis, not on a per-word basis.
So the objective is to look for all the foreign languages in the dictionary and treat them separately from other issues.

Proposed resolution

Review the dictionary.txt and list the foreign words.
decide how to proceed about ignoring, changing or creating a separated dictionary?

Remaining tasks

Make a patch. There is no need to test just yet.

User interface changes

API changes

Data model changes

Release notes snippet

๐Ÿ“Œ Task
Status

Closed: works as designed

Version

11.0 ๐Ÿ”ฅ

Component
Otherย  โ†’

Last updated 1 day ago

Created by

๐Ÿ‡ง๐Ÿ‡ทBrazil lucienchalom

Live updates comments and jobs are added and updated live.
Sign in to follow issues

Comments & Activities

Not all content is available!

It's likely this issue predates Contrib.social: some issue and comment data are missing.

  • Status changed to Needs review about 1 year ago
  • ๐Ÿ‡ณ๐Ÿ‡ฟNew Zealand quietone

    First, a fact. Currently, the dictionary has about 15 valid non English words. That is a small number of the 943 words in the dictionary today, which is less that half of what it was when it was first committed.

    After working on spelling issue for a while now I don't think it is possible to handle valid word from other languages consistently. Such words can easily be retained in a few files with a cspell:ignore line. That gets these words out of the dictionary and only associated with the files or subsystems where they are used. This is what is done for many words in the dictionary whether they are valid non English words, valid technical term, or incorrect spellings of English words.

    What makes a standard approach not possible is that Umami uses valid non English words in csv files, which can't have a cspell:ignore line. These words will always have to be maintained in the a dictionary.

    I don't think there is anything to do here. I suggest we close this a works as designed and continue to do our best to be respectful of multiple languages.

  • ๐Ÿ‡บ๐Ÿ‡ธUnited States smustgrave

    +1 to closing out per explanation in #8

  • ๐Ÿ‡ฎ๐Ÿ‡ณIndia Nitin shrivastava

    Nitin shrivastava โ†’ made their first commit to this issueโ€™s fork.

  • Status changed to Closed: works as designed about 1 year ago
  • ๐Ÿ‡บ๐Ÿ‡ธUnited States smustgrave

    If anyone full disagrees please reopen leaving a comment as to why but still agree with @quietone's assessment in #8

Production build 0.71.5 2024