coding standard issue

Created on 11 January 2023, almost 2 years ago
Updated 21 August 2024, 4 months ago

Problem/Motivation

Steps to reproduce

Proposed resolution

Remaining tasks

User interface changes

API changes

Data model changes

šŸ“Œ Task
Status

Needs work

Version

1.0

Component

Code

Created by

šŸ‡®šŸ‡³India dineshkumarbollu

Live updates comments and jobs are added and updated live.
  • Coding standards

    It involves compliance with, or the content of coding standards. Requires broad community agreement.

Sign in to follow issues

Comments & Activities

Not all content is available!

It's likely this issue predates Contrib.social: some issue and comment data are missing.

  • šŸ‡µšŸ‡­Philippines cleavinjosh

    Hi @dineshkumarbollu,

    I applied patch#1, it was not applied smoothly but fixed most of the phpcs issues.

    These are the remaining issue after I ran phpcs --standard=Drupal,DrupalPractice --extensions=php,module,inc,install,test,profile,theme,css,info,txt,md,yml:

    āžœ  image_with_title git:(8.x-1.x) curl https://www.drupal.org/files/issues/2023-01-11/removed-all-coding-standard-issues-3332556-1.patch | patch -p1
      % Total    % Received % Xferd  Average Speed   Time    Time     Time  Current
                                     Dload  Upload   Total   Spent    Left  Speed
    100   932  100   932    0     0   2388      0 --:--:-- --:--:-- --:--:--  2383
    patching file image_with_title.info.yml
    Hunk #1 FAILED at 2.
    1 out of 1 hunk FAILED -- saving rejects to file image_with_title.info.yml.rej
    patching file image_with_title.module
    Hunk #1 succeeded at 7 with fuzz 2.
    āžœ  image_with_title git:(8.x-1.x) āœ— ..
    āžœ  contrib phpcs --standard=Drupal,DrupalPractice --extensions=php,module,inc,install,test,profile,theme,css,info,txt,md,yml,twig image_with_title
    
    FILE: /Users/interns/Demo-site/drupal-org-issues/web/modules/contrib/image_with_title/image_with_title.info.yml
    ---------------------------------------------------------------------------------------------------------------
    FOUND 0 ERRORS AND 1 WARNING AFFECTING 1 LINE
    ---------------------------------------------------------------------------------------------------------------
     1 | WARNING | "core_version_requirement" property is missing in the info.yml file
    ---------------------------------------------------------------------------------------------------------------
    
    Time: 167ms; Memory: 10MB
    
    āžœ  contrib

    Thank you.

Production build 0.71.5 2024