- 🇳🇱Netherlands daffie
-
+++ b/core/modules/pgsql/src/Driver/Database/pgsql/Schema.php @@ -956,7 +956,7 @@ public function changeField($table, $field, $field_new, $spec, $new_keys = []) { // not when altering. Because of that, the sequence needs to be created ... + $this->connection->query("CREATE SEQUENCE " . $seq . " OWNED BY {" . $table . "}." . $field_new);
Can we put the $field_new in normal brackets. The brackets will be replaced by quotes by Drupal.
-
+++ b/core/modules/pgsql/src/Driver/Database/pgsql/Schema.php @@ -1062,6 +1062,80 @@ public function extensionExists($name): bool { + $table_name = $this->connection->prefixTables('{' . $table . '}'); + $this->connection->query('ALTER SEQUENCE IF EXISTS ' . $seq . ' OWNED BY ' . $table_name . '.' . $column);
Can we change this into a single line. Like:'ALTER SEQUENCE IF EXISTS ' . $seq . ' OWNED BY {' . $table_name . '}.[' . $column . ']'
-
+++ b/core/modules/pgsql/src/Driver/Database/pgsql/Schema.php @@ -1062,6 +1062,80 @@ public function extensionExists($name): bool { + $args = [ + ':table' => $this->connection->getPrefix() . $table, + ':column' => $column, + ]; + return $this->connection + ->query("SELECT pg_get_serial_sequence(:table, :column)", $args) + ->fetchField();
Can we change this to:
return $this->connection ->query("SELECT pg_get_serial_sequence(:table, :column)", ':table' => $this->connection->getPrefix() . $table, ':column' => $column, ) ->fetchField();
-
+++ b/core/modules/pgsql/tests/src/Functional/Database/PostgreSqlSequenceUpdateTest.php @@ -0,0 +1,45 @@ + // Run the updates. + $this->runUpdates();
Can we check that the table does not own the sequence before we run the updates.
-
+++ b/core/modules/system/system.install @@ -1755,5 +1756,124 @@ function system_update_10100(&$sandbox = NULL) { +function system_update_10101(&$sandbox) {
This function needs to be moved to the pgsql module.
-
+++ b/core/modules/pgsql/tests/src/Kernel/pgsql/SchemaTest.php @@ -243,4 +243,49 @@ public function testPgsqlExtensionExists(): void { + public function testPgsqlSequences(): void {
This does not test what we need to test. What we need to test are the methods: getSequenceName() and sequenceExists().
-
- 🇳🇱Netherlands arantxio Dordrecht
@daffie i forgot to add the new files in this patch, so here they are.
- 🇳🇱Netherlands arantxio Dordrecht
Also a interdiff for issue #3028706 comparing this one with the #70 from andypost.
- last update
over 1 year ago 29,369 pass - last update
over 1 year ago 29,369 pass - last update
over 1 year ago 29,369 pass - last update
over 1 year ago 29,369 pass - last update
over 1 year ago 29,369 pass - last update
over 1 year ago 29,369 pass - last update
over 1 year ago 29,368 pass - last update
over 1 year ago 29,368 pass - last update
over 1 year ago 29,368 pass 34:02 30:58 Running- last update
over 1 year ago 29,368 pass - last update
over 1 year ago 29,368 pass 8:01 6:38 Running7:38 5:08 Running- last update
over 1 year ago 29,367 pass - last update
over 1 year ago 29,370 pass - last update
over 1 year ago 29,370 pass - last update
over 1 year ago 29,370 pass - last update
over 1 year ago 29,379 pass, 2 fail - last update
over 1 year ago 29,390 pass - last update
over 1 year ago 29,390 pass - last update
over 1 year ago 29,388 pass, 2 fail - last update
over 1 year ago 29,334 pass, 24 fail - last update
over 1 year ago 29,388 pass, 2 fail - last update
over 1 year ago Custom Commands Failed - last update
over 1 year ago Custom Commands Failed - last update
over 1 year ago Custom Commands Failed - last update
over 1 year ago Custom Commands Failed - last update
over 1 year ago Custom Commands Failed - last update
over 1 year ago Custom Commands Failed - last update
over 1 year ago 29,335 pass, 23 fail - last update
over 1 year ago 29,390 pass - last update
over 1 year ago 29,390 pass - last update
over 1 year ago 29,390 pass - last update
over 1 year ago 29,390 pass - last update
over 1 year ago 29,389 pass, 2 fail - last update
over 1 year ago 29,379 pass, 1 fail - last update
over 1 year ago 29,390 pass - last update
over 1 year ago 29,390 pass - last update
over 1 year ago 29,390 pass - last update
over 1 year ago 29,390 pass - last update
over 1 year ago 19,777 pass, 5,925 fail - last update
over 1 year ago 19,777 pass, 5,925 fail - last update
over 1 year ago 19,777 pass, 5,925 fail - last update
over 1 year ago 29,797 pass - last update
over 1 year ago 29,773 pass, 2 fail - last update
over 1 year ago 29,797 pass - last update
over 1 year ago 29,797 pass - last update
over 1 year ago 29,810 pass - last update
over 1 year ago 29,809 pass, 1 fail - last update
over 1 year ago 29,810 pass - last update
over 1 year ago 29,810 pass - last update
over 1 year ago 29,810 pass - 🇳🇿New Zealand quietone
Updating the title per Special issue titles → .
- last update
over 1 year ago Custom Commands Failed - last update
over 1 year ago Custom Commands Failed - last update
over 1 year ago Custom Commands Failed - last update
over 1 year ago Custom Commands Failed - last update
over 1 year ago Custom Commands Failed - last update
over 1 year ago Custom Commands Failed - last update
over 1 year ago 29,912 pass - last update
over 1 year ago 29,911 pass, 2 fail - last update
over 1 year ago 29,911 pass, 2 fail - last update
over 1 year ago 29,912 pass - last update
over 1 year ago 29,912 pass - last update
over 1 year ago 29,912 pass