Drupal Coding Standards Issues | phpcs

Comment almost 2 years ago →
🇮🇳India Charchil Khandelwal
Charchil Khandelwal → made their first commit to this issue’s fork.
@charchil-khandelwal opened merge request.
Comment almost 2 years ago →
🇮🇳India Charchil Khandelwal
Created MR for this issue.
Please review.

Thank You
First commit to issue fork.
Open on Drupal.org →
Core: 9.5.x + Environment: PHP 8.1 & MySQL 5.7
last update about 1 year ago
Waiting for branch to pass
Issue was unassigned.

I've checked the MR and ran Coder → to check for other issues.

There were some warnings about the order of use statements. So, I fixed it and updated the MR.

FILE: /var/www/html/web/modules/contrib/user_expire/src/Form/UserExpireSettingsForm.php
--------------------------------------------------------------------------------------------------------------------
FOUND 1 ERROR AFFECTING 1 LINE
--------------------------------------------------------------------------------------------------------------------
 10 | ERROR | [x] Use statements should be sorted alphabetically. The first wrong one is Drupal\user\RoleInterface.
--------------------------------------------------------------------------------------------------------------------
PHPCBF CAN FIX THE 1 MARKED SNIFF VIOLATIONS AUTOMATICALLY
--------------------------------------------------------------------------------------------------------------------


FILE: /var/www/html/web/modules/contrib/user_expire/src/Controller/UserExpireReport.php
----------------------------------------------------------------------------------------------------------------------------------
FOUND 1 ERROR AFFECTING 1 LINE
----------------------------------------------------------------------------------------------------------------------------------
 10 | ERROR | [x] Use statements should be sorted alphabetically. The first wrong one is Drupal\Component\Datetime\TimeInterface.
----------------------------------------------------------------------------------------------------------------------------------
PHPCBF CAN FIX THE 1 MARKED SNIFF VIOLATIONS AUTOMATICALLY
----------------------------------------------------------------------------------------------------------------------------------


FILE: /var/www/html/web/modules/contrib/user_expire/src/Plugin/RulesAction/UserExpire.php
-------------------------------------------------------------------------------------------------------------------------
FOUND 1 ERROR AFFECTING 1 LINE
-------------------------------------------------------------------------------------------------------------------------
 6 | ERROR | [x] Use statements should be sorted alphabetically. The first wrong one is Drupal\Core\Database\Connection.
-------------------------------------------------------------------------------------------------------------------------
PHPCBF CAN FIX THE 1 MARKED SNIFF VIOLATIONS AUTOMATICALLY
-------------------------------------------------------------------------------------------------------------------------


FILE: /var/www/html/web/modules/contrib/user_expire/tests/src/Functional/UserExpireTest.php
----------------------------------------------------------------------------------------------------------------------------------------------
FOUND 1 ERROR AFFECTING 1 LINE
----------------------------------------------------------------------------------------------------------------------------------------------
 9 | ERROR | [x] Use statements should be sorted alphabetically. The first wrong one is Drupal\Core\StringTranslation\StringTranslationTrait.
----------------------------------------------------------------------------------------------------------------------------------------------
PHPCBF CAN FIX THE 1 MARKED SNIFF VIOLATIONS AUTOMATICALLY
----------------------------------------------------------------------------------------------------------------------------------------------

Time: 251ms; Memory: 10MB

First commit to issue fork.
Open on Drupal.org →
Core: 9.5.x + Environment: PHP 8.1 & MySQL 5.7
last update about 1 year ago
Waiting for branch to pass
Open in Jenkins → Open on Drupal.org →
Core: 9.5.x + Environment: PHP 8.1 & MySQL 5.7
last update about 1 year ago
1 pass
Open in Jenkins → Open on Drupal.org →
Core: 9.5.x + Environment: PHP 8.1 & MySQL 5.7
last update about 1 year ago
1 pass
Open in Jenkins → Open on Drupal.org →
Core: 9.5.x + Environment: PHP 8.1 & MySQL 5.7
last update about 1 year ago
1 pass
Comment about 1 year ago →
System Message

shelane → committed 07280473 on 8.x-1.x authored by Charchil Khandelwal →
Issue #3331472 by shelane, Charchil Khandelwal, samit.310@gmail.com,...
@shelane opened merge request.
@shelane opened merge request.
Open in Jenkins → Open on Drupal.org →
Core: 9.5.x + Environment: PHP 8.1 & MySQL 5.7
last update about 1 year ago
2 fail
Open in Jenkins → Open on Drupal.org →
Core: 9.5.x + Environment: PHP 8.1 & MySQL 5.7
last update about 1 year ago
2 fail
Comment about 1 year ago →
System Message

shelane → committed 08f6e6db on 8.x-1.x
Issue #3331472 by shelane: Drupal Coding Standards Issues | phpcs
Status changed to Fixed about 1 year ago6:58pm 13 November 2023
Comment about 1 year ago →
🇺🇸United States shelane
Comment about 1 year ago →
System Message

shelane → committed 81788b2e on 8.x-1.x
Issue #3331472 by shelane: Drupal Coding Standards Issues | phpcs
Comment 12 months ago →
System Message
Automatically closed - issue fixed for 2 weeks with no activity.

Drupal Coding Standards Issues | phpcs

Problem/Motivation

Steps to reproduce

Proposed resolution

Comments & Activities