Hi, Reviewed the patch #2, applies cleanly and fixes all the errors reported.
- Status changed to RTBC
4 months ago 12:50pm 15 August 2024 - šµšPhilippines cleavinjosh
Hi@_pratik_,
I applied patch #2, it was applied smoothly and fixed all of the phpcs issues.
ā contrib phpcs --standard=Drupal,DrupalPractice --extensions=php,module,inc,install,test,profile,theme,css,info,txt,md,yml fsk_frontend FILE: /Users/interns/Demo-site/drupal-org-issues/web/modules/contrib/fsk_frontend/css/base/variables.css -------------------------------------------------------------------------------------------------------- FOUND 59 ERRORS AFFECTING 49 LINES -------------------------------------------------------------------------------------------------------- 14 | ERROR | [x] Blank lines are not allowed in class definitions 23 | ERROR | [x] Blank lines are not allowed in class definitions 30 | ERROR | [x] Blank lines are not allowed in class definitions 32 | ERROR | [x] Line indented incorrectly; expected 2 spaces, found 0 33 | ERROR | [x] Line indented incorrectly; expected 2 spaces, found 0 35 | ERROR | [ ] Style definitions must end with a semicolon 36 | ERROR | [ ] Style definitions must end with a semicolon 37 | ERROR | [ ] Style definitions must end with a semicolon 38 | ERROR | [ ] Style definitions must end with a semicolon 39 | ERROR | [ ] Style definitions must end with a semicolon 40 | ERROR | [x] Blank lines are not allowed in class definitions 57 | ERROR | [x] Line indented incorrectly; expected 2 spaces, found 4 57 | ERROR | [ ] No style definition found on line; check for missing colon 58 | ERROR | [x] Line indented incorrectly; expected 2 spaces, found 6 58 | ERROR | [ ] No style definition found on line; check for missing colon 69 | ERROR | [x] Line indented incorrectly; expected 2 spaces, found 4 69 | ERROR | [ ] No style definition found on line; check for missing colon 70 | ERROR | [x] Line indented incorrectly; expected 2 spaces, found 6 70 | ERROR | [ ] No style definition found on line; check for missing colon 72 | ERROR | [x] Blank lines are not allowed in class definitions 77 | ERROR | [x] Blank lines are not allowed in class definitions 93 | ERROR | [x] Line indented incorrectly; expected 2 spaces, found 4 93 | ERROR | [ ] No style definition found on line; check for missing colon 97 | ERROR | [x] Line indented incorrectly; expected 2 spaces, found 4 97 | ERROR | [ ] No style definition found on line; check for missing colon 103 | ERROR | [x] Line indented incorrectly; expected 2 spaces, found 4 103 | ERROR | [ ] No style definition found on line; check for missing colon 104 | ERROR | [x] Blank lines are not allowed in class definitions 111 | ERROR | [x] Blank lines are not allowed in class definitions 117 | ERROR | [x] Blank lines are not allowed in class definitions 126 | ERROR | [x] Blank lines are not allowed in class definitions 147 | ERROR | [x] Line indented incorrectly; expected 2 spaces, found 4 147 | ERROR | [ ] No style definition found on line; check for missing colon 148 | ERROR | [x] Blank lines are not allowed in class definitions 150 | ERROR | [x] Line indented incorrectly; expected 2 spaces, found 0 151 | ERROR | [x] Line indented incorrectly; expected 2 spaces, found 0 165 | ERROR | [x] Blank lines are not allowed in class definitions 167 | ERROR | [x] Line indented incorrectly; expected 2 spaces, found 0 168 | ERROR | [x] Line indented incorrectly; expected 2 spaces, found 0 175 | ERROR | [x] Blank lines are not allowed in class definitions 177 | ERROR | [x] Line indented incorrectly; expected 2 spaces, found 0 178 | ERROR | [x] Line indented incorrectly; expected 2 spaces, found 0 196 | ERROR | [x] Line indented incorrectly; expected 2 spaces, found 6 196 | ERROR | [ ] No style definition found on line; check for missing colon 197 | ERROR | [x] Line indented incorrectly; expected 2 spaces, found 4 198 | ERROR | [x] Line indented incorrectly; expected 2 spaces, found 4 198 | ERROR | [ ] No style definition found on line; check for missing colon 200 | ERROR | [x] Blank lines are not allowed in class definitions 202 | ERROR | [x] Line indented incorrectly; expected 2 spaces, found 0 203 | ERROR | [x] Line indented incorrectly; expected 2 spaces, found 0 217 | ERROR | [x] Blank lines are not allowed in class definitions 219 | ERROR | [x] Line indented incorrectly; expected 2 spaces, found 0 220 | ERROR | [x] Line indented incorrectly; expected 2 spaces, found 0 229 | ERROR | [x] Blank lines are not allowed in class definitions 231 | ERROR | [x] Line indented incorrectly; expected 2 spaces, found 0 232 | ERROR | [x] Line indented incorrectly; expected 2 spaces, found 0 237 | ERROR | [x] Blank lines are not allowed in class definitions 239 | ERROR | [x] Line indented incorrectly; expected 2 spaces, found 0 240 | ERROR | [x] Line indented incorrectly; expected 2 spaces, found 0 -------------------------------------------------------------------------------------------------------- PHPCBF CAN FIX THE 44 MARKED SNIFF VIOLATIONS AUTOMATICALLY -------------------------------------------------------------------------------------------------------- FILE: /Users/interns/Demo-site/drupal-org-issues/web/modules/contrib/fsk_frontend/templates/form/input/input--checkbox/input--checkbox.css ------------------------------------------------------------------------------------------------------------------------------------------ FOUND 2 ERRORS AFFECTING 1 LINE ------------------------------------------------------------------------------------------------------------------------------------------ 30 | ERROR | [x] Line indented incorrectly; expected 2 spaces, found 4 30 | ERROR | [ ] No style definition found on line; check for missing colon ------------------------------------------------------------------------------------------------------------------------------------------ PHPCBF CAN FIX THE 1 MARKED SNIFF VIOLATIONS AUTOMATICALLY ------------------------------------------------------------------------------------------------------------------------------------------ FILE: /Users/interns/Demo-site/drupal-org-issues/web/modules/contrib/fsk_frontend/templates/form/input/input--radio/input--radio.css ------------------------------------------------------------------------------------------------------------------------------------ FOUND 2 ERRORS AFFECTING 1 LINE ------------------------------------------------------------------------------------------------------------------------------------ 31 | ERROR | [x] Line indented incorrectly; expected 2 spaces, found 4 31 | ERROR | [ ] No style definition found on line; check for missing colon ------------------------------------------------------------------------------------------------------------------------------------ PHPCBF CAN FIX THE 1 MARKED SNIFF VIOLATIONS AUTOMATICALLY ------------------------------------------------------------------------------------------------------------------------------------ FILE: /Users/interns/Demo-site/drupal-org-issues/web/modules/contrib/fsk_frontend/templates/form/vertical-tabs/vertical-tabs.css -------------------------------------------------------------------------------------------------------------------------------- FOUND 8 ERRORS AFFECTING 7 LINES -------------------------------------------------------------------------------------------------------------------------------- 84 | ERROR | [x] Selectors must be on a single line 85 | ERROR | [x] Line indented incorrectly; expected 0 spaces, found 2 97 | ERROR | [x] Selectors must be on a single line 98 | ERROR | [x] Line indented incorrectly; expected 0 spaces, found 2 195 | ERROR | [x] Selectors must be on a single line 196 | ERROR | [x] Line indented incorrectly; expected 0 spaces, found 2 196 | ERROR | [x] Selectors must be on a single line 197 | ERROR | [x] Line indented incorrectly; expected 0 spaces, found 2 -------------------------------------------------------------------------------------------------------------------------------- PHPCBF CAN FIX THE 8 MARKED SNIFF VIOLATIONS AUTOMATICALLY -------------------------------------------------------------------------------------------------------------------------------- FILE: /Users/interns/Demo-site/drupal-org-issues/web/modules/contrib/fsk_frontend/templates/form/dropbutton-wrapper/dropbutton-wrapper.css ------------------------------------------------------------------------------------------------------------------------------------------ FOUND 2 ERRORS AFFECTING 1 LINE ------------------------------------------------------------------------------------------------------------------------------------------ 56 | ERROR | [x] Line indented incorrectly; expected 2 spaces, found 4 56 | ERROR | [ ] No style definition found on line; check for missing colon ------------------------------------------------------------------------------------------------------------------------------------------ PHPCBF CAN FIX THE 1 MARKED SNIFF VIOLATIONS AUTOMATICALLY ------------------------------------------------------------------------------------------------------------------------------------------ Time: 301ms; Memory: 12MB ā contrib cd fsk_frontend ā fsk_frontend git:(1.0.x) curl https://www.drupal.org/files/issues/2023-01-05/3331249-2.patch | patch -p1 % Total % Received % Xferd Average Speed Time Time Time Current Dload Upload Total Spent Left Speed 100 10747 100 10747 0 0 24999 0 --:--:-- --:--:-- --:--:-- 25051 patching file css/base/variables.css patching file templates/form/dropbutton-wrapper/dropbutton-wrapper.css patching file templates/form/input/input--checkbox/input--checkbox.css patching file templates/form/input/input--radio/input--radio.css patching file templates/form/vertical-tabs/vertical-tabs.css ā fsk_frontend git:(1.0.x) ā .. ā contrib phpcs --standard=Drupal,DrupalPractice --extensions=php,module,inc,install,test,profile,theme,css,info,txt,md,yml fsk_frontend ā contribThank you.