Coding standards and best practices

Hi @Raghavendra A M ,
I've addressed coding standards and best practices issues in the module and created a patch for it.
Please refer to the attached patch, Thank you.

I tried to apply the Patch in the 10 version but after applying the patch, it still throws the error. Seems like the error is still not resolved. Please let me know if I should check it in any other version.

FILE: /var/www/html/web/drupal10/web/modules/contrib/login_destination/tests/src/Functional/UrlParameterTest.php
----------------------------------------------------------------------------------------------------------------
FOUND 1 ERROR AFFECTING 1 LINE
----------------------------------------------------------------------------------------------------------------
 6 | ERROR | [x] Use statements should be sorted alphabetically. The first wrong one is Drupal\Core\Url.
----------------------------------------------------------------------------------------------------------------
PHPCBF CAN FIX THE 1 MARKED SNIFF VIOLATIONS AUTOMATICALLY
----------------------------------------------------------------------------------------------------------------


FILE: /var/www/html/web/drupal10/web/modules/contrib/login_destination/tests/src/Functional/RedirectTest.php
----------------------------------------------------------------------------------------------------------------------
FOUND 1 ERROR AFFECTING 1 LINE
----------------------------------------------------------------------------------------------------------------------
 8 | ERROR | [x] Use statements should be sorted alphabetically. The first wrong one is Drupal\Tests\BrowserTestBase.
----------------------------------------------------------------------------------------------------------------------
PHPCBF CAN FIX THE 1 MARKED SNIFF VIOLATIONS AUTOMATICALLY
----------------------------------------------------------------------------------------------------------------------


FILE: /var/www/html/web/drupal10/web/modules/contrib/login_destination/src/LoginDestinationManager.php
----------------------------------------------------------------------------------------------------------------------------
FOUND 1 ERROR AFFECTING 1 LINE
----------------------------------------------------------------------------------------------------------------------------
 10 | ERROR | [x] Use statements should be sorted alphabetically. The first wrong one is Drupal\Core\Path\CurrentPathStack.
----------------------------------------------------------------------------------------------------------------------------
PHPCBF CAN FIX THE 1 MARKED SNIFF VIOLATIONS AUTOMATICALLY
----------------------------------------------------------------------------------------------------------------------------


FILE: /var/www/html/web/drupal10/web/modules/contrib/login_destination/login_destination.module
-----------------------------------------------------------------------------------------------------------
FOUND 1 ERROR AFFECTING 1 LINE
-----------------------------------------------------------------------------------------------------------
 13 | ERROR | [x] Use statements should be sorted alphabetically. The first wrong one is Drupal\Core\Link.
-----------------------------------------------------------------------------------------------------------
PHPCBF CAN FIX THE 1 MARKED SNIFF VIOLATIONS AUTOMATICALLY
-----------------------------------------------------------------------------------------------------------

Hi @rsvelko ,

Thanks for merging the MR.

I noticed that I wasn't credited for resolving this issue. Could you let me know if there's something I might have missed?

Hi, @atul_ghate.

Hi, actually, you were credited. Look into the commit author, do a git pull first. Then look closely into the commit msg.
Am I missing sth?

I've now given credit via the checkbox in this comments thread too.
Before that credit was given only in commit msgs and git author.
Cheers.

Automatically closed - issue fixed for 2 weeks with no activity.