Account created on 16 July 2008, over 16 years ago
#

Merge Requests

Recent comments

πŸ‡¦πŸ‡ΉAustria rsvelko

Done.
Just released 8.x-2.0-beta8.

πŸ‡¦πŸ‡ΉAustria rsvelko

marking as fixed then.
@tyapchyc, thanks!

πŸ‡¦πŸ‡ΉAustria rsvelko

Giving credit. Thanks everyone.

πŸ‡¦πŸ‡ΉAustria rsvelko

I've now given credit via the checkbox in this comments thread too.
Before that credit was given only in commit msgs and git author.
Cheers.

πŸ‡¦πŸ‡ΉAustria rsvelko

Hi, @atul_ghate.

Hi, actually, you were credited. Look into the commit author, do a git pull first. Then look closely into the commit msg.
Am I missing sth?

πŸ‡¦πŸ‡ΉAustria rsvelko

I've taken the good bits of your patch and tested against latest 8.x-2.x dev branch codebase in drupal 9.x with PHP 8.1.
After some more fixing - all is good now. Tests passed.

πŸ‡¦πŸ‡ΉAustria rsvelko

updated the merge request branch, then merged PR/MR.
Tada!

πŸ‡¦πŸ‡ΉAustria rsvelko

rsvelko β†’ created an issue.

πŸ‡¦πŸ‡ΉAustria rsvelko

duplicate of a recently fixed issue/MR.
Closing this one now.

πŸ‡¦πŸ‡ΉAustria rsvelko

rsvelko β†’ made their first commit to this issue’s fork.

πŸ‡¦πŸ‡ΉAustria rsvelko

patch #8 and MR13 have same changes.
Just merged MR13.
All good now - just tested and after latest changes, we can delete rules again.

πŸ‡¦πŸ‡ΉAustria rsvelko

rsvelko β†’ made their first commit to this issue’s fork.

πŸ‡¦πŸ‡ΉAustria rsvelko

Thanks all for the report and MR.
I've just merged and it's now into the dev branch.
My next step is to look for other RTBC-s, test them and group them into new release 8.x-2.0-beta7.

πŸ‡¦πŸ‡ΉAustria rsvelko

rsvelko β†’ made their first commit to this issue’s fork.

πŸ‡¦πŸ‡ΉAustria rsvelko

rsvelko β†’ made their first commit to this issue’s fork.

Production build 0.71.5 2024