Done.
Just released 8.x-2.0-beta8.
marking as fixed then.
@tyapchyc, thanks!
Giving credit. Thanks everyone.
I've now given credit via the checkbox in this comments thread too.
Before that credit was given only in commit msgs and git author.
Cheers.
Hi, @atul_ghate.
Hi, actually, you were credited. Look into the commit author, do a git pull first. Then look closely into the commit msg.
Am I missing sth?
I've taken the good bits of your patch and tested against latest 8.x-2.x dev branch codebase in drupal 9.x with PHP 8.1.
After some more fixing - all is good now. Tests passed.
updated the merge request branch, then merged PR/MR.
Tada!
rsvelko β made their first commit to this issueβs fork.
rsvelko β created an issue.
duplicate of a recently fixed issue/MR.
Closing this one now.
Thanks all. Merged.
rsvelko β made their first commit to this issueβs fork.
patch #8 and MR13 have same changes.
Just merged MR13.
All good now - just tested and after latest changes, we can delete rules again.
rsvelko β made their first commit to this issueβs fork.
Thanks all for the report and MR.
I've just merged and it's now into the dev branch.
My next step is to look for other RTBC-s, test them and group them into new release 8.x-2.0-beta7.
rsvelko β made their first commit to this issueβs fork.
rsvelko β made their first commit to this issueβs fork.