- Merge request !2Issue #3330260: Drupal Coding Standards Issues | phpcs โ (Merged) created by Charchil Khandelwal
- ๐ฎ๐ณIndia Charchil Khandelwal
Thanks @samit.310@gmail.com, patch #2 applied cleanly, all errors and warnings are fixed.
I also created MR for same.
Please review.
Thank You. - ๐ฎ๐ณIndia dev16.addweb
Hello,
I have tested MR !2 and found no errors or warnings. - Status changed to RTBC
6 months ago 7:49am 13 June 2024 - Status changed to Needs work
6 months ago 1:36am 14 June 2024 - ๐ฆ๐บAustralia kim.pepper ๐โโ๏ธ๐ฆ๐บSydney, Australia
Can you please rebase this onto the latest 2.x branch so we get gitlab ci codesniffer validation running? Thanks.
- First commit to issue fork.
- Status changed to Needs review
6 months ago 4:41am 14 June 2024 - ๐ฎ๐ณIndia manish-31
MR rebased, Gitlab CI ran PHPCS validation ran successfully. Needs review.
-
kim.pepper โ
committed 36688711 on 2.x authored by
Charchil Khandelwal โ
Issue #3330260 by samit.310@gmail.com, Charchil Khandelwal, manish-31,...
-
kim.pepper โ
committed 36688711 on 2.x authored by
Charchil Khandelwal โ
- Status changed to Fixed
6 months ago 4:52am 14 June 2024 - ๐ฆ๐บAustralia kim.pepper ๐โโ๏ธ๐ฆ๐บSydney, Australia
Committed to 2.x. Thanks!
Automatically closed - issue fixed for 2 weeks with no activity.