iCalcreator.class.php (2.20.4) reports deprecations in PHP 8.1

Totally works, I applied it to a patch as I have it in composer:

"kigkonsult/icalcreator": {
      "#3330050 iCalcreator.class.php (2.20.4) reports deprecations in PHP 8.1": "https://www.drupal.org/files/issues/2022-12-30/3330050-2.patch"
    }

Thanks @_pratik_ Maybe we should provide it to the upstream fork maintainer?

It would be good to have a fresh release of the iCalcreator library fork but I am nevertheless encouraged that my proposed fix has belatedly garnered some support.

I believe we need an upstream request to have this fixed in kigkonsult/icalcreator

Assuming this is on github somewhere? has anyone pushed a pull request or made a fork?

iCalcreator was forked to https://github.com/lkmorlan/iCalcreator/releases/tag/v2.20.4 by Liam Morland → to address issue #2707373: PHP 7 support with iCalcreator class → . Do we need Liam to update that fork?

Hi @SteveWilson , Liam Morland is quite active, I'm sure that if someone created a pull request on github, he would merge it and tag a release.

I created a pull request for Liam Morlands repo
https://github.com/lkmorlan/iCalcreator/pull/1

Alternatively, someone could use my fork instead: https://github.com/joejoseph00/iCalcreator/releases/tag/v2.20.5

I updated the drupal.org project page for ical to refer to the new build, my fork that has the above mentioned changes.

https://github.com/joejoseph00/iCalcreator/archive/refs/tags/v2.20.5.zip

https://www.drupal.org/project/date_ical/releases/7.x-3.12 →
Updated README.txt
also updated project page to rever to the new library release.

This seems only to incorporate only the first change, not that at line 4872?

I have merged the pull request referred-to in #10.

@SteveWilson, thanks for catching that, I pushed that into my fork with the pull request for Liam Morlands fork and he merged it also.

I updated the project page with a link to my forks latest release that has the entire fix.

https://github.com/joejoseph00/iCalcreator/archive/refs/tags/v2.20.6.zip

The README.txt for date_ical has been updated to refer to my fork.

version v2.20.6 or higher to get this fix.

@joseph.olstad since you also maintain this and I don't use this any more, I will leave it to you to maintain the fork of iCalcreator. Thanks

Sounds good, ya that's what I was thinking, thanks for the followup! With that said, you might as well tag a release in case someone is still looking at your fork.

Thanks @joseph.olstad, all working well now.

Automatically closed - issue fixed for 2 weeks with no activity.