- 🇹🇷Turkey bonchak
Hi,
I have the same issue and modifying the theme yml file did not work.
- 🇹🇷Turkey bonchak
Hello,
Installing stable and updating theme yml file solved the problem.
https://www.drupal.org/project/stable → - 🇧🇪Belgium bart lambert
@bonchak
Stable module is indeed necessary to have at_tool working but when you create a new theme using the them generator you still have to change the core requirements manually and that can not be the goal.I hope Matt Bloomfield (@mattbloomfield) will surface one of these days to solve the issues for D10 compatibility.
- 🇹🇷Turkey bonchak
@bart lambert
I have updated the core requirements for D10 but I did not figure out the stable thing. The funny thing i,s that I understood stable as "stable version of the core adaptivetheme" :) It took some time to understand that stable is an other theme :) - 🇧🇪Belgium bart lambert
@bonchak
In D8 the "Stable" module was incorporated in the core. As far as I understand is At-tools using stable to work.
In D9/D10 stable is deprecated/remove so somebody revived it for those users who need it to keep using their themes in de newer Drupal Core versions.more info is found here:
https://www.drupal.org/docs/contributed-themes/stable →
https://www.drupal.org/node/3309392 → - First commit to issue fork.
- Merge request !1Update ThemeGeneratorTypes.php for Drupal 10 Support → (Closed) created by Unnamed author
I'll take a look at this very soon. I started a new job a few months ago and that's taken some time away from Adaptive Theme. But I'll get to it very soon.
- 🇸🇰Slovakia coaston
#11 cannot solve the issue. Original file has core_version_requirement: ^9.3 || ^10 so this patch is useless and does not work. Created subtheme still has not the right core version. The only way how to fix it currently is to update yml file in theme directly manually.
- Status changed to Downport
over 1 year ago 7:21am 24 July 2023 - Status changed to Fixed
over 1 year ago 7:26am 24 July 2023 - 🇮🇳India rushiraval
#12 Apply this patch no need to update file manually. I have already submitted request for merge. So hope it may be solved in next release.
- Status changed to Downport
over 1 year ago 7:34am 24 July 2023 - @rushiraval opened merge request.
- Status changed to Needs review
over 1 year ago 12:32pm 5 August 2023 - 🇧🇪Belgium bart lambert
There is still an error in the patch from #13!
in the line to be added, your " ' " is in the wrong position!
It reads:
+ $info['core_version_requirement'] = '^8 || ^9' || ^10;
while it should read:
+ $info['core_version_requirement'] = '^8 || ^9 || ^10';then it works....
- 🇳🇱Netherlands dries arnolds 🇳🇱 Amsterdam
The patch in #20 works fine. Can we get this committed?
- Status changed to RTBC
12 months ago 6:37am 22 November 2023 -
Rushikesh Raval →
committed db07ba61 on 2.0.x
Update ThemeGeneratorTypes.php for Core Requirment issue#3330032
-
Rushikesh Raval →
committed db07ba61 on 2.0.x
- Status changed to Fixed
12 months ago 5:24am 1 December 2023 - 🇮🇳India rushiraval
@bart lambert , @bonchak I have checked your comment regarding Stable Theme requirements in at_core theme of Adaptive Theme.
This issue may be created in https://www.drupal.org/project/adaptivetheme → .
Automatically closed - issue fixed for 2 weeks with no activity.