- 🇩🇪Germany Anybody Porta Westfalica
Drupal 10 is out. beta4 is marked compatible with Drupal 10. Is that true?
Over at 📌 Automated Drupal 10 compatibility fixes Fixed nothing seems to happen, perhaps a maintainer from this module should become Co-Maintainer for the base module?
- 🇮🇳India mohit_aghera Rajkot
I've spotted a few missing bits while using this module with 10.1
Adding explicit accessCheck on entity query is required.
Adding a patch for that. - First commit to issue fork.
- 🇮🇳India dineshkumarbollu
Hi
I applied both patches and checks the D10 compatible issues it still as one issue in Tests folder.
vendor/bin/drush upgrade_status:analyze term_merge
[notice] Processing /var/www/html/contributions/web/modules/contrib/term_merge-3329485.================================================================================
Term Merge, --
Scanned on Mon, 07/10/2023 - 15:42FILE:
web/modules/contrib/term_merge-3329485/tests/src/Functional/MergeTermsTestBase.p
hpSTATUS LINE MESSAGE
--------------------------------------------------------------------------------
Check manually 104 Call to deprecated method prophesize() of class
PHPUnit\Framework\TestCase:
https://github.com/sebastianbergmann/phpunit/issues/4141 - Status changed to RTBC
about 1 year ago 11:22am 10 October 2023 I have checked patch #2 and patch #4, and found they both work ok.
The problems which these patches address are also reported (and patched) separately in 🐛 TypeError: Drupal\Component\EventDispatcher\ContainerAwareEventDispatcher::dispatch(): Argument #1 ($event) must be of type object, string given RTBC and 🐛 SQL access check not implemented RTBC .The outstanding problem with "Call to deprecated method prophesize() of class PHPUnit\Framework\TestCase" reported by @dineshkumarbollu doesnt appear to impact normal term merging activity (presumably only testing). I propose that this problem is moved to its own, separate issue, where it can be dealt with separately, and not hold up the roll out of patches #2 and #4, which are clearly causing problems for anyone wanting to use this module on D10 (and causing people to waste their time re-inventing patches).
- Status changed to Closed: outdated
8 months ago 7:42am 20 April 2024 It looks to me as if 2.0.0-beta6 does not include patch #4 (access check in buildExistingTermsOptions).
- 🇫🇷France tostinni
It looks like it has been commited, see https://git.drupalcode.org/project/term_merge/-/blob/2.0.0-beta6/src/For...
Ah yes, I see now that the accessCheck has been put in at line 164, whereas patch #4 puts it in at line 158.