- 🇫🇷France ephoto_dam
Fixed the branch names
removed README.tx
removed LICENSE.txt
removed the empty gitignore
completed the composer.json
corrected the code according to PHPCS - 🇮🇳India vishal.kadam Mumbai
Remove version information and comments from info file (line 15-60).
It will be added automatically by Drupal.org packaging script.
- Status changed to Needs work
almost 2 years ago 9:01am 30 January 2023 - 🇮🇳India vishal.kadam Mumbai
@ephoto_dam PHPCS issues are not fixed
phpcs --standard=Drupal,DrupalPractice --extensions=php,module,inc,install,test,profile,theme,css,info,txt,md,yml ephoto_dam/ FILE: ephoto_dam/css/ephoto_dam.css ---------------------------------------------------------------------------- FOUND 44 ERRORS AFFECTING 39 LINES ---------------------------------------------------------------------------- 2 | ERROR | [x] Line indented incorrectly; expected 2 spaces, found 4 3 | ERROR | [x] Line indented incorrectly; expected 2 spaces, found 4 4 | ERROR | [x] Line indented incorrectly; expected 2 spaces, found 4 8 | ERROR | [x] Line indented incorrectly; expected 2 spaces, found 4 12 | ERROR | [x] Line indented incorrectly; expected 2 spaces, found 4 13 | ERROR | [x] Line indented incorrectly; expected 2 spaces, found 4 17 | ERROR | [x] Line indented incorrectly; expected 2 spaces, found 4 21 | ERROR | [x] Line indented incorrectly; expected 2 spaces, found 4 22 | ERROR | [x] Line indented incorrectly; expected 2 spaces, found 4 26 | ERROR | [x] Line indented incorrectly; expected 2 spaces, found 4 30 | ERROR | [x] Line indented incorrectly; expected 2 spaces, found 4 34 | ERROR | [x] Line indented incorrectly; expected 2 spaces, found 4 35 | ERROR | [x] Line indented incorrectly; expected 2 spaces, found 4 36 | ERROR | [x] Line indented incorrectly; expected 2 spaces, found 4 37 | ERROR | [x] Line indented incorrectly; expected 2 spaces, found 4 38 | ERROR | [x] Line indented incorrectly; expected 2 spaces, found 4 39 | ERROR | [x] Line indented incorrectly; expected 2 spaces, found 4 40 | ERROR | [x] Line indented incorrectly; expected 2 spaces, found 4 41 | ERROR | [x] Line indented incorrectly; expected 2 spaces, found 4 42 | ERROR | [x] Line indented incorrectly; expected 2 spaces, found 4 43 | ERROR | [x] Line indented incorrectly; expected 2 spaces, found 4 47 | ERROR | [x] Line indented incorrectly; expected 2 spaces, found 4 48 | ERROR | [x] Line indented incorrectly; expected 2 spaces, found 4 49 | ERROR | [x] Line indented incorrectly; expected 2 spaces, found 4 50 | ERROR | [x] Line indented incorrectly; expected 2 spaces, found 4 51 | ERROR | [x] Line indented incorrectly; expected 2 spaces, found 4 52 | ERROR | [x] Line indented incorrectly; expected 2 spaces, found 4 53 | ERROR | [x] Line indented incorrectly; expected 2 spaces, found 4 54 | ERROR | [x] Line indented incorrectly; expected 2 spaces, found 4 54 | ERROR | [ ] Style definitions must end with a semicolon 58 | ERROR | [x] Line indented incorrectly; expected 2 spaces, found 4 58 | ERROR | [x] Expected 1 space after colon in style definition; 0 found 58 | ERROR | [ ] Style definitions must end with a semicolon 62 | ERROR | [x] Line indented incorrectly; expected 2 spaces, found 4 62 | ERROR | [x] Expected 1 space after colon in style definition; 0 found 63 | ERROR | [x] Line indented incorrectly; expected 2 spaces, found 4 64 | ERROR | [x] Line indented incorrectly; expected 2 spaces, found 4 65 | ERROR | [x] Line indented incorrectly; expected 2 spaces, found 4 65 | ERROR | [x] Expected 1 space after colon in style definition; 0 found 66 | ERROR | [x] Line indented incorrectly; expected 2 spaces, found 4 67 | ERROR | [x] Line indented incorrectly; expected 2 spaces, found 4 68 | ERROR | [x] Line indented incorrectly; expected 2 spaces, found 4 69 | ERROR | [x] Line indented incorrectly; expected 2 spaces, found 4 70 | ERROR | [x] Expected 1 newline at end of file; 0 found ---------------------------------------------------------------------------- PHPCBF CAN FIX THE 42 MARKED SNIFF VIOLATIONS AUTOMATICALLY ---------------------------------------------------------------------------- FILE: ephoto_dam/ephoto_dam.info.yml ------------------------------------------------------------------------------------------------------------- FOUND 0 ERRORS AND 3 WARNINGS AFFECTING 1 LINE ------------------------------------------------------------------------------------------------------------- 1 | WARNING | Remove "project" from the info file, it will be added by drupal.org packaging automatically 1 | WARNING | Remove "datestamp" from the info file, it will be added by drupal.org packaging automatically 1 | WARNING | Remove "version" from the info file, it will be added by drupal.org packaging automatically ------------------------------------------------------------------------------------------------------------- FILE: ephoto_dam/ephoto_dam.module --------------------------------------------------------------------------------------------------------------------------------------------- FOUND 115 ERRORS AND 3 WARNINGS AFFECTING 90 LINES --------------------------------------------------------------------------------------------------------------------------------------------- 17 | ERROR | [x] Line indented incorrectly; expected 2 spaces, found 4 24 | ERROR | [x] Line indented incorrectly; expected 2 spaces, found 4 25 | ERROR | [x] Line indented incorrectly; expected 2 spaces, found 4 26 | ERROR | [x] Whitespace found at end of line 27 | ERROR | [x] Line indented incorrectly; expected 2 spaces, found 4 28 | ERROR | [x] Line indented incorrectly; expected 2 spaces, found 4 35 | ERROR | [x] Line indented incorrectly; expected 2 spaces, found 4 36 | ERROR | [x] Line indented incorrectly; expected 4 spaces, found 8 37 | ERROR | [x] Line indented incorrectly; expected 2 spaces, found 4 38 | ERROR | [x] Whitespace found at end of line 39 | ERROR | [x] Line indented incorrectly; expected 2 spaces, found 4 41 | WARNING | [x] A comma should follow the last multiline array item. Found: ) 41 | ERROR | [x] Spaces must be used for alignment; tabs are not allowed 41 | ERROR | [x] Whitespace found at end of line 42 | ERROR | [x] Spaces must be used for alignment; tabs are not allowed 42 | ERROR | [x] Whitespace found at end of line 43 | ERROR | [x] Whitespace found at end of line 44 | ERROR | [x] Line indented incorrectly; expected 2 spaces, found 4 45 | ERROR | [x] Line indented incorrectly; expected 2 spaces, found 4 46 | ERROR | [x] Line indented incorrectly; expected 2 spaces, found 4 47 | ERROR | [x] Whitespace found at end of line 48 | ERROR | [x] Line indented incorrectly; expected 2 spaces, found 4 49 | ERROR | [x] Line indented incorrectly; expected 2 spaces, found 4 50 | ERROR | [x] Line indented incorrectly; expected 2 spaces, found 4 51 | ERROR | [x] Line indented incorrectly; expected 2 spaces, found 4 52 | ERROR | [x] Line indented incorrectly; expected 2 spaces, found 4 52 | ERROR | [x] Expected 1 space after ".="; 5 found 52 | ERROR | [x] Spaces must be used for alignment; tabs are not allowed 53 | ERROR | [x] Line indented incorrectly; expected 2 spaces, found 4 53 | ERROR | [x] Expected 1 space after ".="; 5 found 53 | ERROR | [x] Spaces must be used for alignment; tabs are not allowed 54 | ERROR | [x] Line indented incorrectly; expected 2 spaces, found 4 54 | ERROR | [x] Expected 1 space after ".="; 5 found 54 | ERROR | [x] Spaces must be used for alignment; tabs are not allowed 55 | ERROR | [x] Line indented incorrectly; expected 2 spaces, found 4 55 | ERROR | [x] Expected 1 space after ".="; 5 found 55 | ERROR | [x] Spaces must be used for alignment; tabs are not allowed 56 | ERROR | [x] Line indented incorrectly; expected 2 spaces, found 4 56 | ERROR | [x] Expected 1 space after ".="; 5 found 56 | ERROR | [x] Spaces must be used for alignment; tabs are not allowed 57 | ERROR | [x] Line indented incorrectly; expected 2 spaces, found 4 58 | ERROR | [x] Whitespace found at end of line 59 | ERROR | [x] Line indented incorrectly; expected 2 spaces, found 4 60 | ERROR | [x] Line indented incorrectly; expected 2 spaces, found 4 61 | ERROR | [x] Whitespace found at end of line 62 | ERROR | [x] Line indented incorrectly; expected 2 spaces, found 4 63 | ERROR | [x] Line indented incorrectly; expected 2 spaces, found 4 64 | ERROR | [x] Whitespace found at end of line 65 | ERROR | [x] Line indented incorrectly; expected 2 spaces, found 4 66 | ERROR | [x] Whitespace found at end of line 67 | ERROR | [x] Line indented incorrectly; expected 2 spaces, found 4 68 | ERROR | [x] Line indented incorrectly; expected 2 spaces, found 4 69 | ERROR | [x] Line indented incorrectly; expected 2 spaces, found 4 70 | ERROR | [x] Line indented incorrectly; expected 2 spaces, found 4 71 | ERROR | [x] Line indented incorrectly; expected 2 spaces, found 4 72 | ERROR | [x] Line indented incorrectly; expected 2 spaces, found 4 73 | ERROR | [x] Whitespace found at end of line 74 | ERROR | [x] Line indented incorrectly; expected 2 spaces, found 4 81 | ERROR | [x] Whitespace found at end of line 82 | ERROR | [x] Line indented incorrectly; expected 2 spaces, found 4 82 | ERROR | [ ] The array declaration extends to column 86 (the limit is 80). The array content should be split up over multiple lines 84 | ERROR | [x] Line indented incorrectly; expected 2 spaces, found 4 86 | ERROR | [x] Line indented incorrectly; expected 2 spaces, found 4 87 | ERROR | [x] Line indented incorrectly; expected 4 spaces, found 8 92 | ERROR | [x] Line indented incorrectly; expected 2 spaces, found 4 99 | ERROR | [x] Whitespace found at end of line 100 | ERROR | [x] Line indented incorrectly; expected 2 spaces, found 4 102 | ERROR | [x] Line indented incorrectly; expected 2 spaces, found 4 103 | ERROR | [x] Whitespace found at end of line 104 | ERROR | [x] Line indented incorrectly; expected 2 spaces, found 4 105 | ERROR | [x] Line indented incorrectly; expected 2 spaces, found 4 106 | ERROR | [x] Line indented incorrectly; expected 2 spaces, found 4 107 | ERROR | [x] Line indented incorrectly; expected 2 spaces, found 4 107 | ERROR | [ ] The array declaration extends to column 134 (the limit is 80). The array content should be split up over multiple lines 107 | ERROR | [ ] The array declaration extends to column 133 (the limit is 80). The array content should be split up over multiple lines 108 | ERROR | [x] Line indented incorrectly; expected 2 spaces, found 4 108 | ERROR | [ ] The array declaration extends to column 134 (the limit is 80). The array content should be split up over multiple lines 108 | ERROR | [ ] The array declaration extends to column 133 (the limit is 80). The array content should be split up over multiple lines 109 | ERROR | [x] Line indented incorrectly; expected 2 spaces, found 4 109 | ERROR | [ ] The array declaration extends to column 140 (the limit is 80). The array content should be split up over multiple lines 109 | ERROR | [ ] The array declaration extends to column 139 (the limit is 80). The array content should be split up over multiple lines 111 | ERROR | [x] Line indented incorrectly; expected 2 spaces, found 4 117 | WARNING | [x] A comma should follow the last multiline array item. Found: $documents_size 120 | ERROR | [x] Line indented incorrectly; expected 2 spaces, found 4 122 | ERROR | [x] Line indented incorrectly; expected 2 spaces, found 4 124 | ERROR | [x] Line indented incorrectly; expected 2 spaces, found 4 125 | ERROR | [x] Line indented incorrectly; expected 4 spaces, found 8 127 | ERROR | [x] Line indented incorrectly; expected 4 spaces, found 8 129 | ERROR | [x] Line indented incorrectly; expected 4 spaces, found 8 130 | WARNING | [x] A comma should follow the last multiline array item. Found: ) 133 | ERROR | [x] Line indented incorrectly; expected 4 spaces, found 8 134 | ERROR | [x] Line indented incorrectly; expected 6 spaces, found 12 134 | ERROR | [x] There should be no white space after an opening "(" 134 | ERROR | [x] There should be no white space before a closing ")" 134 | ERROR | [x] Spaces must be used for alignment; tabs are not allowed 134 | ERROR | [x] Whitespace found at end of line 135 | ERROR | [x] Line indented incorrectly; expected 4 spaces, found 8 136 | ERROR | [x] Line indented incorrectly; expected 2 spaces, found 4 140 | ERROR | [x] Doc comment short description must end with a full stop 144 | ERROR | [x] Line indented incorrectly; expected 2 spaces, found 4 144 | ERROR | [ ] The array declaration extends to column 103 (the limit is 80). The array content should be split up over multiple lines 144 | ERROR | [x] TRUE, FALSE and NULL must be uppercase; expected "TRUE" but found "true" 145 | ERROR | [x] Line indented incorrectly; expected 2 spaces, found 4 145 | ERROR | [x] TRUE, FALSE and NULL must be uppercase; expected "FALSE" but found "false" 147 | ERROR | [x] Line indented incorrectly; expected 2 spaces, found 4 148 | ERROR | [x] Line indented incorrectly; expected 4 spaces, found 8 149 | ERROR | [x] Line indented incorrectly; expected 6 spaces, found 12 150 | ERROR | [x] Line indented incorrectly; expected 8 spaces, found 16 151 | ERROR | [x] Line indented incorrectly; expected 10 spaces, found 20 152 | ERROR | [x] Line indented incorrectly; expected 12 spaces, found 24 152 | ERROR | [x] TRUE, FALSE and NULL must be uppercase; expected "TRUE" but found "true" 153 | ERROR | [x] Line indented incorrectly; expected 12 spaces, found 24 154 | ERROR | [x] Line indented incorrectly; expected 10 spaces, found 20 155 | ERROR | [x] Line indented incorrectly; expected 8 spaces, found 16 156 | ERROR | [x] Line indented incorrectly; expected 6 spaces, found 12 157 | ERROR | [x] Line indented incorrectly; expected 4 spaces, found 8 158 | ERROR | [x] Line indented incorrectly; expected 2 spaces, found 4 160 | ERROR | [x] Line indented incorrectly; expected 2 spaces, found 4 --------------------------------------------------------------------------------------------------------------------------------------------- PHPCBF CAN FIX THE 110 MARKED SNIFF VIOLATIONS AUTOMATICALLY --------------------------------------------------------------------------------------------------------------------------------------------- FILE: ephoto_dam/ephoto_dam.routing.yml ----------------------------------------------------------------------- FOUND 1 ERROR AFFECTING 1 LINE ----------------------------------------------------------------------- 7 | ERROR | [x] Expected 1 newline at end of file; 2 found ----------------------------------------------------------------------- PHPCBF CAN FIX THE 1 MARKED SNIFF VIOLATIONS AUTOMATICALLY ----------------------------------------------------------------------- FILE: ephoto_dam/modules/ephoto_dam_field/css/ephoto_dam_field.css -------------------------------------------------------------------------------------------------- FOUND 113 ERRORS AFFECTING 51 LINES -------------------------------------------------------------------------------------------------- 2 | ERROR | [x] Line indented incorrectly; expected 2 spaces, found 4 2 | ERROR | [x] Expected 1 space after colon in style definition; 0 found 3 | ERROR | [x] Line indented incorrectly; expected 2 spaces, found 4 3 | ERROR | [x] Expected 1 space after colon in style definition; 0 found 4 | ERROR | [x] Line indented incorrectly; expected 2 spaces, found 4 4 | ERROR | [x] Expected 1 space after colon in style definition; 0 found 8 | ERROR | [x] Line indented incorrectly; expected 2 spaces, found 4 8 | ERROR | [x] Expected 1 space after colon in style definition; 0 found 12 | ERROR | [x] Line indented incorrectly; expected 2 spaces, found 4 12 | ERROR | [x] Expected 1 space after colon in style definition; 0 found 15 | ERROR | [x] Multiple selectors should each be on a single line 16 | ERROR | [x] Line indented incorrectly; expected 2 spaces, found 4 16 | ERROR | [x] Expected 1 space after colon in style definition; 0 found 17 | ERROR | [x] Line indented incorrectly; expected 2 spaces, found 4 17 | ERROR | [x] Expected 1 space after colon in style definition; 0 found 18 | ERROR | [x] Line indented incorrectly; expected 2 spaces, found 4 18 | ERROR | [x] Expected 1 space after colon in style definition; 0 found 18 | ERROR | [ ] Style definitions must end with a semicolon 21 | ERROR | [x] Multiple selectors should each be on a single line 22 | ERROR | [x] Line indented incorrectly; expected 2 spaces, found 4 22 | ERROR | [x] Expected 1 space after colon in style definition; 0 found 23 | ERROR | [x] Line indented incorrectly; expected 2 spaces, found 4 23 | ERROR | [x] Expected 1 space after colon in style definition; 0 found 24 | ERROR | [x] Spaces must be used to indent lines; tabs are not allowed 24 | ERROR | [x] Line indented incorrectly; expected 2 spaces, found 1 24 | ERROR | [x] Expected 1 space after colon in style definition; 0 found 25 | ERROR | [x] Line indented incorrectly; expected 2 spaces, found 4 25 | ERROR | [x] Expected 1 space after colon in style definition; 0 found 26 | ERROR | [x] Line indented incorrectly; expected 2 spaces, found 4 26 | ERROR | [x] Expected 1 space after colon in style definition; 0 found 26 | ERROR | [x] Whitespace found at end of line 30 | ERROR | [x] Line indented incorrectly; expected 2 spaces, found 4 30 | ERROR | [x] Expected 1 space after colon in style definition; 0 found 30 | ERROR | [ ] Style definitions must end with a semicolon 34 | ERROR | [x] Line indented incorrectly; expected 2 spaces, found 4 34 | ERROR | [x] Expected 1 space after colon in style definition; 0 found 38 | ERROR | [x] Line indented incorrectly; expected 2 spaces, found 4 38 | ERROR | [x] Expected 1 space after colon in style definition; 0 found 42 | ERROR | [x] Line indented incorrectly; expected 2 spaces, found 4 42 | ERROR | [x] Expected 1 space after colon in style definition; 0 found 46 | ERROR | [x] Line indented incorrectly; expected 2 spaces, found 4 46 | ERROR | [x] Expected 1 space after colon in style definition; 0 found 50 | ERROR | [x] Line indented incorrectly; expected 2 spaces, found 4 50 | ERROR | [x] Expected 1 space after colon in style definition; 0 found 53 | ERROR | [x] Multiple selectors should each be on a single line 54 | ERROR | [x] Line indented incorrectly; expected 2 spaces, found 4 54 | ERROR | [x] Expected 1 space after colon in style definition; 0 found 54 | ERROR | [ ] Style definitions must end with a semicolon 58 | ERROR | [x] Line indented incorrectly; expected 2 spaces, found 4 58 | ERROR | [x] Expected 1 space after colon in style definition; 0 found 59 | ERROR | [x] Line indented incorrectly; expected 2 spaces, found 4 59 | ERROR | [x] Expected 1 space after colon in style definition; 0 found 60 | ERROR | [x] Line indented incorrectly; expected 2 spaces, found 4 60 | ERROR | [x] Expected 1 space after colon in style definition; 0 found 61 | ERROR | [x] Line indented incorrectly; expected 2 spaces, found 4 61 | ERROR | [x] Expected 1 space after colon in style definition; 0 found 62 | ERROR | [x] Line indented incorrectly; expected 2 spaces, found 4 62 | ERROR | [x] Expected 1 space after colon in style definition; 0 found 63 | ERROR | [x] Line indented incorrectly; expected 2 spaces, found 4 63 | ERROR | [x] Expected 1 space after colon in style definition; 0 found 64 | ERROR | [x] Line indented incorrectly; expected 2 spaces, found 4 64 | ERROR | [x] Expected 1 space after colon in style definition; 0 found 64 | ERROR | [x] CSS colours must be defined in lowercase; expected #aaa but found #AAA 68 | ERROR | [x] Line indented incorrectly; expected 2 spaces, found 4 68 | ERROR | [x] Expected 1 space after colon in style definition; 0 found 72 | ERROR | [x] Line indented incorrectly; expected 2 spaces, found 4 72 | ERROR | [x] Expected 1 space after colon in style definition; 0 found 73 | ERROR | [x] Line indented incorrectly; expected 2 spaces, found 4 73 | ERROR | [x] Expected 1 space after colon in style definition; 0 found 74 | ERROR | [x] Spaces must be used to indent lines; tabs are not allowed 74 | ERROR | [x] Line indented incorrectly; expected 2 spaces, found 1 74 | ERROR | [x] Expected 1 space after colon in style definition; 0 found 75 | ERROR | [x] Line indented incorrectly; expected 2 spaces, found 4 75 | ERROR | [x] Expected 1 space after colon in style definition; 0 found 76 | ERROR | [x] Line indented incorrectly; expected 2 spaces, found 4 76 | ERROR | [x] Expected 1 space after colon in style definition; 0 found 77 | ERROR | [x] Line indented incorrectly; expected 2 spaces, found 4 77 | ERROR | [x] Expected 1 space after colon in style definition; 0 found 78 | ERROR | [x] Line indented incorrectly; expected 2 spaces, found 4 78 | ERROR | [x] Expected 1 space after colon in style definition; 0 found 79 | ERROR | [x] Line indented incorrectly; expected 2 spaces, found 4 79 | ERROR | [x] Expected 1 space after colon in style definition; 0 found 80 | ERROR | [x] Line indented incorrectly; expected 2 spaces, found 4 80 | ERROR | [x] Expected 1 space after colon in style definition; 0 found 80 | ERROR | [ ] Style definitions must end with a semicolon 84 | ERROR | [x] Line indented incorrectly; expected 2 spaces, found 4 84 | ERROR | [x] Expected 1 space after colon in style definition; 0 found 85 | ERROR | [x] Line indented incorrectly; expected 2 spaces, found 4 85 | ERROR | [x] Expected 1 space after colon in style definition; 0 found 86 | ERROR | [x] Line indented incorrectly; expected 2 spaces, found 4 86 | ERROR | [x] Expected 1 space after colon in style definition; 0 found 87 | ERROR | [x] Line indented incorrectly; expected 2 spaces, found 4 87 | ERROR | [x] Expected 1 space after colon in style definition; 0 found 88 | ERROR | [x] Line indented incorrectly; expected 2 spaces, found 4 88 | ERROR | [x] Expected 1 space after colon in style definition; 0 found 89 | ERROR | [x] Line indented incorrectly; expected 2 spaces, found 4 89 | ERROR | [x] Expected 1 space after colon in style definition; 0 found 90 | ERROR | [x] Line indented incorrectly; expected 2 spaces, found 4 90 | ERROR | [x] Expected 1 space after colon in style definition; 0 found 90 | ERROR | [ ] Style definitions must end with a semicolon 94 | ERROR | [x] Spaces must be used to indent lines; tabs are not allowed 94 | ERROR | [x] Line indented incorrectly; expected 2 spaces, found 1 94 | ERROR | [x] Expected 1 space after colon in style definition; 0 found 94 | ERROR | [ ] Style definitions must end with a semicolon 98 | ERROR | [x] Line indented incorrectly; expected 2 spaces, found 4 98 | ERROR | [x] Expected 1 space after colon in style definition; 0 found 98 | ERROR | [x] Whitespace found at end of line 99 | ERROR | [x] Line indented incorrectly; expected 2 spaces, found 4 99 | ERROR | [x] Expected 1 space after colon in style definition; 0 found 99 | ERROR | [ ] Style definitions must end with a semicolon 103 | ERROR | [x] Line indented incorrectly; expected 2 spaces, found 4 103 | ERROR | [x] Expected 1 space after colon in style definition; 0 found 103 | ERROR | [ ] Style definitions must end with a semicolon -------------------------------------------------------------------------------------------------- PHPCBF CAN FIX THE 105 MARKED SNIFF VIOLATIONS AUTOMATICALLY -------------------------------------------------------------------------------------------------- FILE: ephoto_dam/modules/ephoto_dam_field/ephoto_dam_field.info.yml ------------------------------------------------------------------------------------------------------------- FOUND 0 ERRORS AND 3 WARNINGS AFFECTING 1 LINE ------------------------------------------------------------------------------------------------------------- 1 | WARNING | Remove "project" from the info file, it will be added by drupal.org packaging automatically 1 | WARNING | Remove "datestamp" from the info file, it will be added by drupal.org packaging automatically 1 | WARNING | Remove "version" from the info file, it will be added by drupal.org packaging automatically ------------------------------------------------------------------------------------------------------------- FILE: ephoto_dam/modules/ephoto_dam_field/ephoto_dam_field.install -------------------------------------------------------------------------------------------------- FOUND 2 ERRORS AFFECTING 2 LINES -------------------------------------------------------------------------------------------------- 1 | ERROR | [x] Missing file doc comment 19 | ERROR | [x] Namespaced classes/interfaces/traits should be referenced with use statements -------------------------------------------------------------------------------------------------- PHPCBF CAN FIX THE 2 MARKED SNIFF VIOLATIONS AUTOMATICALLY -------------------------------------------------------------------------------------------------- FILE: ephoto_dam/modules/ephoto_dam_field/ephoto_dam_field.module ------------------------------------------------------------------------------------------------- FOUND 44 ERRORS AND 4 WARNINGS AFFECTING 38 LINES ------------------------------------------------------------------------------------------------- 10 | WARNING | [x] Unused use statement 11 | WARNING | [x] Unused use statement 18 | ERROR | [x] Line indented incorrectly; expected 2 spaces, found 4 20 | ERROR | [x] Line indented incorrectly; expected 2 spaces, found 4 21 | ERROR | [x] Line indented incorrectly; expected 2 spaces, found 4 23 | ERROR | [x] Line indented incorrectly; expected 2 spaces, found 4 24 | ERROR | [x] Line indented incorrectly; expected 4 spaces, found 8 26 | ERROR | [x] Line indented incorrectly; expected 4 spaces, found 8 27 | ERROR | [x] Line indented incorrectly; expected 4 spaces, found 8 29 | ERROR | [x] Line indented incorrectly; expected 4 spaces, found 8 31 | ERROR | [x] Line indented incorrectly; expected 4 spaces, found 8 31 | ERROR | [x] Whitespace found at end of line 32 | ERROR | [x] Line indented incorrectly; expected 2 spaces, found 4 39 | ERROR | [x] Line indented incorrectly; expected 2 spaces, found 4 40 | ERROR | [x] Line indented incorrectly; expected 4 spaces, found 8 41 | ERROR | [x] Line indented incorrectly; expected 2 spaces, found 4 42 | ERROR | [x] Whitespace found at end of line 43 | ERROR | [x] Line indented incorrectly; expected 2 spaces, found 4 45 | WARNING | [x] A comma should follow the last multiline array item. Found: '#' 45 | ERROR | [x] Spaces must be used for alignment; tabs are not allowed 45 | ERROR | [x] Whitespace found at end of line 46 | ERROR | [x] Spaces must be used for alignment; tabs are not allowed 46 | ERROR | [x] Whitespace found at end of line 47 | ERROR | [x] Whitespace found at end of line 48 | ERROR | [x] Line indented incorrectly; expected 2 spaces, found 4 49 | ERROR | [x] Line indented incorrectly; expected 2 spaces, found 4 50 | ERROR | [x] Line indented incorrectly; expected 2 spaces, found 4 51 | ERROR | [x] Line indented incorrectly; expected 2 spaces, found 4 52 | ERROR | [x] Line indented incorrectly; expected 2 spaces, found 4 52 | ERROR | [x] Spaces must be used for alignment; tabs are not allowed 52 | ERROR | [x] Whitespace found at end of line 53 | ERROR | [x] Whitespace found at end of line 54 | ERROR | [x] Line indented incorrectly; expected 2 spaces, found 4 61 | ERROR | [x] Line indented incorrectly; expected 2 spaces, found 4 62 | ERROR | [x] Line indented incorrectly; expected 4 spaces, found 8 63 | ERROR | [x] Line indented incorrectly; expected 2 spaces, found 4 70 | ERROR | [x] Line indented incorrectly; expected 2 spaces, found 4 72 | ERROR | [x] Line indented incorrectly; expected 2 spaces, found 4 74 | ERROR | [x] Line indented incorrectly; expected 2 spaces, found 4 75 | WARNING | [x] A comma should follow the last multiline array item. Found: ) 78 | ERROR | [x] Line indented incorrectly; expected 2 spaces, found 4 79 | ERROR | [x] Line indented incorrectly; expected 4 spaces, found 8 79 | ERROR | [x] There should be no white space after an opening "(" 79 | ERROR | [x] There should be no white space before a closing ")" 79 | ERROR | [x] Spaces must be used for alignment; tabs are not allowed 79 | ERROR | [x] Whitespace found at end of line 80 | ERROR | [x] Line indented incorrectly; expected 2 spaces, found 4 81 | ERROR | [x] Expected 1 newline at end of file; 0 found ------------------------------------------------------------------------------------------------- PHPCBF CAN FIX THE 48 MARKED SNIFF VIOLATIONS AUTOMATICALLY ------------------------------------------------------------------------------------------------- FILE: ephoto_dam/modules/ephoto_dam_field/src/Plugin/Field/FieldFormatter/EphotoDamFieldFormatter.php ------------------------------------------------------------------------------------------------------------------------------------- FOUND 118 ERRORS AND 3 WARNINGS AFFECTING 79 LINES ------------------------------------------------------------------------------------------------------------------------------------- 1 | ERROR | [x] The PHP open tag must be followed by exactly one blank line 4 | ERROR | [x] Namespaced classes, interfaces and traits should not begin with a file doc comment 13 | ERROR | [ ] Doc comment short description must end with a full stop 13 | ERROR | [ ] Doc comment short description must be on a single line, further text should be a separate paragraph 14 | ERROR | [x] Whitespace found at end of line 16 | ERROR | [x] Tag value indented incorrectly; expected 1 space but found 2 17 | WARNING | [ ] @author tags are not usually used in Drupal, because over time multiple contributors will touch the code anyway 17 | ERROR | [x] Tag value indented incorrectly; expected 1 space but found 3 18 | ERROR | [x] Tag value indented incorrectly; expected 1 space but found 2 19 | ERROR | [x] Tag value indented incorrectly; expected 1 space but found 5 30 | ERROR | [x] Line indented incorrectly; expected 0 spaces, found 1 31 | ERROR | [x] Doc comment short description must end with a full stop 32 | ERROR | [x] Whitespace found at end of line 34 | ERROR | [x] Tag value indented incorrectly; expected 1 space but found 2 35 | WARNING | [ ] @author tags are not usually used in Drupal, because over time multiple contributors will touch the code anyway 35 | ERROR | [x] Tag value indented incorrectly; expected 1 space but found 3 36 | ERROR | [x] Tag value indented incorrectly; expected 1 space but found 2 37 | ERROR | [x] Tag value indented incorrectly; expected 1 space but found 5 42 | ERROR | [x] Opening brace should be on the same line as the declaration 43 | ERROR | [x] Line indented incorrectly; expected 2 spaces, found 4 46 | ERROR | [x] Expected 1 spaces after parameter type; 38 found 46 | ERROR | [x] Whitespace found at end of line 46 | ERROR | [x] Parameter comment must be on the next line 47 | ERROR | [x] Parameter comment indentation must be 3 spaces, found 74 spaces 48 | ERROR | [x] Expected 1 spaces after parameter type; 39 found 48 | ERROR | [x] Whitespace found at end of line 48 | ERROR | [x] Parameter comment must be on the next line 49 | ERROR | [x] Parameter comment indentation must be 3 spaces, found 74 spaces 50 | ERROR | [x] Whitespace found at end of line 50 | ERROR | [x] Parameter comment must be on the next line 51 | ERROR | [x] Parameter comment indentation must be 3 spaces, found 74 spaces 52 | ERROR | [x] Expected 1 spaces after parameter type; 39 found 52 | ERROR | [x] Whitespace found at end of line 52 | ERROR | [x] Parameter comment must be on the next line 53 | ERROR | [x] Parameter comment indentation must be 3 spaces, found 74 spaces 54 | ERROR | [x] Expected 1 spaces after parameter type; 38 found 54 | ERROR | [x] Whitespace found at end of line 54 | ERROR | [x] Parameter comment must be on the next line 55 | ERROR | [x] Parameter comment indentation must be 3 spaces, found 74 spaces 56 | ERROR | [x] Expected 1 spaces after parameter type; 38 found 56 | ERROR | [x] Whitespace found at end of line 56 | ERROR | [x] Parameter comment must be on the next line 57 | ERROR | [x] Parameter comment indentation must be 3 spaces, found 74 spaces 60 | ERROR | [x] Expected 1 spaces after parameter type; 39 found 60 | ERROR | [x] Whitespace found at end of line 60 | ERROR | [x] Parameter comment must be on the next line 61 | ERROR | [x] Parameter comment indentation must be 3 spaces, found 74 spaces 63 | ERROR | [x] Line indented incorrectly; expected 2 spaces, found 4 63 | WARNING | [ ] Possible useless method overriding detected 63 | ERROR | [ ] Type hint "array" missing for $settings 63 | ERROR | [ ] Type hint "array" missing for $third_party_settings 63 | ERROR | [x] Expected 1 blank line before function; 0 found 65 | ERROR | [x] Whitespace found at end of line 66 | ERROR | [x] Whitespace found at end of line 68 | ERROR | [x] Whitespace found at end of line 69 | ERROR | [x] Whitespace found at end of line 72 | ERROR | [x] Line indented incorrectly; expected 4 spaces, found 8 74 | ERROR | [x] Whitespace found at end of line 75 | ERROR | [x] Whitespace found at end of line 76 | ERROR | [x] Whitespace found at end of line 77 | ERROR | [x] Whitespace found at end of line 80 | ERROR | [x] Line indented incorrectly; expected 2 spaces, found 4 82 | ERROR | [x] Line indented incorrectly; expected 2 spaces, found 4 83 | ERROR | [x] Doc comment short description must end with a full stop 84 | ERROR | [x] Whitespace found at end of line 85 | ERROR | [x] Data types in @param tags need to be fully namespaced 85 | ERROR | [x] Whitespace found at end of line 85 | ERROR | [x] Parameter comment must be on the next line 86 | ERROR | [x] Parameter comment indentation must be 3 spaces, found 46 spaces 86 | ERROR | [ ] Parameter comment must start with a capital letter 86 | ERROR | [x] Parameter comment must end with a full stop 87 | ERROR | [x] Expected 1 spaces after parameter type; 14 found 87 | ERROR | [x] Whitespace found at end of line 87 | ERROR | [x] Parameter comment must be on the next line 88 | ERROR | [x] Parameter comment indentation must be 3 spaces, found 46 spaces 88 | ERROR | [ ] Parameter comment must start with a capital letter 89 | ERROR | [x] Parameter comment must end with a full stop 90 | ERROR | [x] Expected 1 spaces after parameter type; 13 found 90 | ERROR | [x] Whitespace found at end of line 90 | ERROR | [x] Parameter comment must be on the next line 91 | ERROR | [x] Parameter comment indentation must be 3 spaces, found 46 spaces 91 | ERROR | [x] Whitespace found at end of line 91 | ERROR | [ ] Parameter comment must start with a capital letter 92 | ERROR | [x] Parameter comment must end with a full stop 93 | ERROR | [x] Expected 1 spaces after parameter type; 14 found 93 | ERROR | [x] Whitespace found at end of line 93 | ERROR | [x] Parameter comment must be on the next line 94 | ERROR | [x] Parameter comment indentation must be 3 spaces, found 46 spaces 94 | ERROR | [x] Whitespace found at end of line 94 | ERROR | [ ] Parameter comment must start with a capital letter 96 | ERROR | [x] Whitespace found at end of line 97 | ERROR | [x] Parameter comment must end with a full stop 98 | ERROR | [x] Whitespace found at end of line 99 | ERROR | [ ] Description for the @return value is missing 101 | ERROR | [x] Line indented incorrectly; expected 2 spaces, found 4 102 | ERROR | [x] Whitespace found at end of line 103 | ERROR | [x] Whitespace found at end of line 104 | ERROR | [x] Whitespace found at end of line 107 | ERROR | [x] Line indented incorrectly; expected 4 spaces, found 8 116 | ERROR | [x] Line indented incorrectly; expected 2 spaces, found 4 118 | ERROR | [x] Line indented incorrectly; expected 2 spaces, found 4 119 | ERROR | [x] Doc comment short description must end with a full stop 120 | ERROR | [x] Whitespace found at end of line 121 | ERROR | [ ] Parameter comment must start with a capital letter 121 | ERROR | [x] Data types in @param tags need to be fully namespaced 121 | ERROR | [x] Parameter comment must be on the next line 121 | ERROR | [x] Parameter comment must end with a full stop 122 | ERROR | [x] Expected 1 spaces after parameter type; 17 found 122 | ERROR | [x] Parameter comment must be on the next line 123 | ERROR | [x] Parameter comment indentation must be 3 spaces, found 41 spaces 123 | ERROR | [ ] Parameter comment must start with a capital letter 123 | ERROR | [x] Parameter comment must end with a full stop 124 | ERROR | [x] Whitespace found at end of line 125 | ERROR | [ ] Description for the @return value is missing 127 | ERROR | [x] Line indented incorrectly; expected 2 spaces, found 4 127 | ERROR | [x] Whitespace found at end of line 128 | ERROR | [x] Opening brace should be on the same line as the declaration 129 | ERROR | [x] Line indented incorrectly; expected 4 spaces, found 8 131 | ERROR | [x] Line indented incorrectly; expected 4 spaces, found 8 132 | ERROR | [x] Line indented incorrectly; expected 2 spaces, found 4 133 | ERROR | [x] Expected 1 newline at end of file; 0 found ------------------------------------------------------------------------------------------------------------------------------------- PHPCBF CAN FIX THE 106 MARKED SNIFF VIOLATIONS AUTOMATICALLY ------------------------------------------------------------------------------------------------------------------------------------- FILE: ephoto_dam/modules/ephoto_dam_field/src/Plugin/Field/FieldType/EphotoDamField.php ------------------------------------------------------------------------------------------------------------------------------------------------- FOUND 173 ERRORS AND 19 WARNINGS AFFECTING 150 LINES ------------------------------------------------------------------------------------------------------------------------------------------------- 1 | ERROR | [x] The PHP open tag must be followed by exactly one blank line 2 | ERROR | [x] Namespaced classes, interfaces and traits should not begin with a file doc comment 3 | ERROR | [x] Doc comment short description must end with a full stop 8 | ERROR | [x] Whitespace found at end of line 13 | ERROR | [x] Whitespace found at end of line 16 | ERROR | [x] Whitespace found at end of line 18 | ERROR | [x] Tag value indented incorrectly; expected 1 space but found 2 19 | WARNING | [ ] @author tags are not usually used in Drupal, because over time multiple contributors will touch the code anyway 19 | ERROR | [x] Tag value indented incorrectly; expected 1 space but found 3 20 | ERROR | [x] Tag value indented incorrectly; expected 1 space but found 2 21 | ERROR | [x] Tag value indented incorrectly; expected 1 space but found 5 29 | ERROR | [x] There must be one blank line after the last USE statement; 2 found; 32 | ERROR | [x] Line indented incorrectly; expected 0 spaces, found 1 33 | ERROR | [x] Doc comment short description must end with a full stop 34 | ERROR | [x] Whitespace found at end of line 36 | ERROR | [x] Tag value indented incorrectly; expected 1 space but found 2 37 | WARNING | [ ] @author tags are not usually used in Drupal, because over time multiple contributors will touch the code anyway 37 | ERROR | [x] Tag value indented incorrectly; expected 1 space but found 3 38 | ERROR | [x] Tag value indented incorrectly; expected 1 space but found 2 39 | ERROR | [x] Tag value indented incorrectly; expected 1 space but found 5 42 | ERROR | [x] Opening brace should be on the same line as the declaration 44 | ERROR | [x] Line indented incorrectly; expected 2 spaces, found 4 45 | ERROR | [x] Doc comment short description must end with a full stop 49 | ERROR | [x] Line indented incorrectly; expected 2 spaces, found 4 50 | ERROR | [x] TRUE, FALSE and NULL must be uppercase; expected "FALSE" but found "false" 51 | WARNING | [x] A comma should follow the last multiline array item. Found: '' 52 | ERROR | [x] Whitespace found at end of line 54 | ERROR | [x] Line indented incorrectly; expected 2 spaces, found 4 55 | ERROR | [x] Doc comment short description must end with a full stop 56 | ERROR | [x] Whitespace found at end of line 57 | ERROR | [x] Expected 1 spaces after parameter type; 25 found 57 | ERROR | [x] Parameter comment must be on the next line 57 | ERROR | [x] Parameter comment must end with a full stop 58 | ERROR | [x] Expected 1 spaces after parameter type; 24 found 58 | ERROR | [x] Parameter comment must be on the next line 58 | ERROR | [x] Parameter comment must end with a full stop 59 | ERROR | [x] Data types in @param tags need to be fully namespaced 59 | ERROR | [x] Parameter comment must be on the next line 60 | ERROR | [x] Whitespace found at end of line 61 | ERROR | [x] Parameter comment indentation must be 3 spaces, found 50 spaces 61 | ERROR | [ ] Parameter comment must start with a capital letter 61 | ERROR | [x] Parameter comment must end with a full stop 63 | ERROR | [x] Line indented incorrectly; expected 2 spaces, found 4 63 | WARNING | [ ] Possible useless method overriding detected 63 | ERROR | [x] Whitespace found at end of line 64 | ERROR | [x] TRUE, FALSE and NULL must be uppercase; expected "NULL" but found "null" 64 | ERROR | [x] Whitespace found at end of line 65 | ERROR | [x] TRUE, FALSE and NULL must be uppercase; expected "NULL" but found "null" 67 | ERROR | [x] Line indented incorrectly; expected 4 spaces, found 8 68 | ERROR | [x] Line indented incorrectly; expected 2 spaces, found 4 70 | ERROR | [x] Line indented incorrectly; expected 2 spaces, found 4 71 | ERROR | [x] Doc comment short description must end with a full stop 72 | ERROR | [x] Whitespace found at end of line 73 | ERROR | [x] Expected 1 spaces after parameter type; 25 found 73 | ERROR | [x] Parameter comment must be on the next line 73 | ERROR | [x] Parameter comment must end with a full stop 74 | ERROR | [x] Expected 1 spaces after parameter type; 24 found 74 | ERROR | [x] Parameter comment must be on the next line 74 | ERROR | [x] Parameter comment must end with a full stop 75 | ERROR | [x] Data types in @param tags need to be fully namespaced 75 | ERROR | [x] Parameter comment must be on the next line 76 | ERROR | [x] Parameter comment indentation must be 3 spaces, found 50 spaces 76 | ERROR | [ ] Parameter comment must start with a capital letter 76 | ERROR | [x] Parameter comment must end with a full stop 77 | ERROR | [x] Whitespace found at end of line 78 | ERROR | [ ] Description for the @return value is missing 80 | ERROR | [x] Line indented incorrectly; expected 2 spaces, found 4 81 | ERROR | [x] Whitespace found at end of line 82 | ERROR | [x] TRUE, FALSE and NULL must be uppercase; expected "NULL" but found "null" 82 | ERROR | [x] Whitespace found at end of line 83 | ERROR | [x] TRUE, FALSE and NULL must be uppercase; expected "NULL" but found "null" 85 | ERROR | [x] Line indented incorrectly; expected 4 spaces, found 8 86 | ERROR | [x] Line indented incorrectly; expected 2 spaces, found 4 86 | ERROR | [x] Expected 1 blank line after function; 2 found 89 | ERROR | [x] Line indented incorrectly; expected 2 spaces, found 4 90 | ERROR | [x] Doc comment short description must end with a full stop 91 | ERROR | [x] Whitespace found at end of line 92 | ERROR | [x] Data types in @param tags need to be fully namespaced 92 | ERROR | [x] Whitespace found at end of line 92 | ERROR | [x] Parameter comment must be on the next line 93 | ERROR | [x] Parameter comment indentation must be 3 spaces, found 58 spaces 93 | ERROR | [x] Whitespace found at end of line 94 | ERROR | [x] Parameter comment must end with a full stop 95 | ERROR | [x] Whitespace found at end of line 96 | ERROR | [ ] Description for the @return value is missing 98 | ERROR | [x] Line indented incorrectly; expected 2 spaces, found 4 101 | ERROR | [x] Line indented incorrectly; expected 4 spaces, found 8 104 | ERROR | [x] Array indentation error, expected 18 spaces but found 20 105 | ERROR | [x] Array indentation error, expected 18 spaces but found 20 105 | ERROR | [x] TRUE, FALSE and NULL must be uppercase; expected "TRUE" but found "true" 106 | ERROR | [x] Whitespace found at end of line 109 | WARNING | [x] A comma should follow the last multiline array item. Found: 256 113 | WARNING | [x] A comma should follow the last multiline array item. Found: 9 117 | WARNING | [x] A comma should follow the last multiline array item. Found: 20 117 | ERROR | [x] Whitespace found at end of line 121 | WARNING | [x] A comma should follow the last multiline array item. Found: 256 125 | WARNING | [x] A comma should follow the last multiline array item. Found: 256 126 | WARNING | [x] A comma should follow the last multiline array item. Found: ] 126 | ERROR | [x] Whitespace found at end of line 127 | WARNING | [x] A comma should follow the last multiline array item. Found: ] 129 | ERROR | [x] Line indented incorrectly; expected 2 spaces, found 4 129 | ERROR | [x] Whitespace found at end of line 131 | ERROR | [x] Line indented incorrectly; expected 2 spaces, found 4 132 | ERROR | [x] Doc comment short description must end with a full stop 133 | ERROR | [x] Whitespace found at end of line 134 | ERROR | [x] Data types in @param tags need to be fully namespaced 134 | ERROR | [x] Whitespace found at end of line 134 | ERROR | [x] Parameter comment must be on the next line 135 | ERROR | [x] Parameter comment indentation must be 3 spaces, found 58 spaces 135 | ERROR | [x] Whitespace found at end of line 136 | ERROR | [x] Parameter comment must end with a full stop 137 | ERROR | [x] Whitespace found at end of line 138 | ERROR | [ ] Description for the @return value is missing 140 | ERROR | [x] Line indented incorrectly; expected 2 spaces, found 4 143 | ERROR | [x] Line indented incorrectly; expected 4 spaces, found 8 144 | ERROR | [x] Object operator not indented correctly; expected 10 spaces but found 8 144 | ERROR | [x] Whitespace found at end of line 145 | ERROR | [x] Whitespace found at end of line 146 | ERROR | [x] Line indented incorrectly; expected 4 spaces, found 8 147 | ERROR | [x] Object operator not indented correctly; expected 10 spaces but found 8 149 | ERROR | [x] Line indented incorrectly; expected 4 spaces, found 8 150 | ERROR | [x] Object operator not indented correctly; expected 10 spaces but found 8 152 | ERROR | [x] Line indented incorrectly; expected 4 spaces, found 8 153 | ERROR | [x] Object operator not indented correctly; expected 10 spaces but found 8 155 | ERROR | [x] Line indented incorrectly; expected 4 spaces, found 8 156 | ERROR | [x] Object operator not indented correctly; expected 10 spaces but found 8 157 | ERROR | [x] Whitespace found at end of line 158 | ERROR | [x] Line indented incorrectly; expected 4 spaces, found 8 159 | ERROR | [x] Object operator not indented correctly; expected 10 spaces but found 8 160 | ERROR | [x] Whitespace found at end of line 161 | ERROR | [x] Line indented incorrectly; expected 4 spaces, found 8 162 | ERROR | [x] Line indented incorrectly; expected 2 spaces, found 4 164 | ERROR | [x] Line indented incorrectly; expected 2 spaces, found 4 165 | ERROR | [x] Doc comment short description must end with a full stop 166 | ERROR | [x] Whitespace found at end of line 167 | ERROR | [x] Expected "bool" but found "boolean" for function return type 167 | ERROR | [ ] Description for the @return value is missing 169 | ERROR | [x] Line indented incorrectly; expected 2 spaces, found 4 169 | ERROR | [x] Whitespace found at end of line 170 | ERROR | [x] Opening brace should be on the same line as the declaration 171 | ERROR | [x] Line indented incorrectly; expected 4 spaces, found 8 172 | ERROR | [x] Line indented incorrectly; expected 4 spaces, found 8 173 | ERROR | [x] Line indented incorrectly; expected 4 spaces, found 8 175 | ERROR | [x] Line indented incorrectly; expected 4 spaces, found 8 176 | ERROR | [x] Line indented incorrectly; expected 2 spaces, found 4 178 | ERROR | [x] Line indented incorrectly; expected 2 spaces, found 4 179 | ERROR | [x] Doc comment short description must end with a full stop 180 | ERROR | [x] Whitespace found at end of line 181 | ERROR | [x] Whitespace found at end of line 181 | ERROR | [x] Parameter comment must be on the next line 182 | ERROR | [x] Parameter comment indentation must be 3 spaces, found 26 spaces 182 | ERROR | [x] Parameter comment must end with a full stop 183 | ERROR | [x] Whitespace found at end of line 183 | ERROR | [x] Parameter comment must be on the next line 184 | ERROR | [x] Parameter comment indentation must be 3 spaces, found 26 spaces 184 | ERROR | [x] Whitespace found at end of line 185 | ERROR | [x] Parameter comment must end with a full stop 186 | ERROR | [x] Whitespace found at end of line 187 | ERROR | [ ] Description for the @return value is missing 189 | ERROR | [x] Line indented incorrectly; expected 2 spaces, found 4 189 | ERROR | [ ] Expected type hint "array"; found "FormStateInterface" for $form_state 190 | ERROR | [x] Whitespace found at end of line 193 | ERROR | [x] Line indented incorrectly; expected 4 spaces, found 8 195 | ERROR | [x] Line indented incorrectly; expected 4 spaces, found 8 196 | ERROR | [x] Whitespace found at end of line 197 | ERROR | [x] Line indented incorrectly; expected 4 spaces, found 8 198 | WARNING | [ ] t() calls should be avoided in classes, use \Drupal\Core\StringTranslation\StringTranslationTrait and $this->t() instead 199 | WARNING | [ ] t() calls should be avoided in classes, use \Drupal\Core\StringTranslation\StringTranslationTrait and $this->t() instead 202 | ERROR | [x] Whitespace found at end of line 203 | WARNING | [ ] Do not concatenate strings to translatable strings, they should be part of the t() argument and you should use placeholders 208 | ERROR | [x] Whitespace found at end of line 209 | ERROR | [x] Whitespace found at end of line 210 | WARNING | [x] A comma should follow the last multiline array item. Found: '\'].enableVersionSupport(this)' 211 | WARNING | [x] A comma should follow the last multiline array item. Found: ] 214 | ERROR | [x] Line indented incorrectly; expected 4 spaces, found 8 215 | WARNING | [ ] t() calls should be avoided in classes, use \Drupal\Core\StringTranslation\StringTranslationTrait and $this->t() instead 218 | WARNING | [ ] t() calls should be avoided in classes, use \Drupal\Core\StringTranslation\StringTranslationTrait and $this->t() instead 219 | WARNING | [x] A comma should follow the last multiline array item. Found: 1 220 | ERROR | [x] Whitespace found at end of line 222 | ERROR | [x] Line indented incorrectly; expected 4 spaces, found 8 223 | ERROR | [x] Line indented incorrectly; expected 2 spaces, found 4 225 | ERROR | [x] Line indented incorrectly; expected 2 spaces, found 4 226 | ERROR | [x] Doc comment short description must end with a full stop 227 | ERROR | [x] Whitespace found at end of line 228 | ERROR | [ ] Description for the @return value is missing 230 | ERROR | [x] Line indented incorrectly; expected 2 spaces, found 4 230 | ERROR | [x] Whitespace found at end of line 231 | ERROR | [x] Opening brace should be on the same line as the declaration 232 | ERROR | [x] Line indented incorrectly; expected 4 spaces, found 8 233 | ERROR | [x] Line indented incorrectly; expected 2 spaces, found 4 233 | ERROR | [x] Expected 1 blank line after function; 0 found 233 | ERROR | [x] Whitespace found at end of line ------------------------------------------------------------------------------------------------------------------------------------------------- PHPCBF CAN FIX THE 175 MARKED SNIFF VIOLATIONS AUTOMATICALLY ------------------------------------------------------------------------------------------------------------------------------------------------- FILE: ephoto_dam/modules/ephoto_dam_field/src/Plugin/Field/FieldWidget/EphotoDamFieldWidget.php ---------------------------------------------------------------------------------------------------------------------------------------------- FOUND 207 ERRORS AND 32 WARNINGS AFFECTING 188 LINES ---------------------------------------------------------------------------------------------------------------------------------------------- 3 | ERROR | [x] Namespaced classes, interfaces and traits should not begin with a file doc comment 12 | ERROR | [ ] Doc comment short description must end with a full stop 12 | ERROR | [ ] Doc comment short description must be on a single line, further text should be a separate paragraph 13 | ERROR | [x] Whitespace found at end of line 15 | ERROR | [x] Tag value indented incorrectly; expected 1 space but found 2 16 | WARNING | [ ] @author tags are not usually used in Drupal, because over time multiple contributors will touch the code anyway 16 | ERROR | [x] Tag value indented incorrectly; expected 1 space but found 3 17 | ERROR | [x] Tag value indented incorrectly; expected 1 space but found 2 18 | ERROR | [x] Tag value indented incorrectly; expected 1 space but found 5 25 | ERROR | [x] There must be one blank line after the last USE statement; 2 found; 28 | ERROR | [x] Line indented incorrectly; expected 0 spaces, found 1 29 | ERROR | [x] Doc comment short description must end with a full stop 30 | ERROR | [x] Whitespace found at end of line 32 | ERROR | [x] Tag value indented incorrectly; expected 1 space but found 2 33 | WARNING | [ ] @author tags are not usually used in Drupal, because over time multiple contributors will touch the code anyway 33 | ERROR | [x] Tag value indented incorrectly; expected 1 space but found 3 34 | ERROR | [x] Tag value indented incorrectly; expected 1 space but found 2 35 | ERROR | [x] Tag value indented incorrectly; expected 1 space but found 5 38 | ERROR | [x] Opening brace should be on the same line as the declaration 40 | ERROR | [x] Line indented incorrectly; expected 2 spaces, found 4 40 | WARNING | [ ] Property name "$_first" should not be prefixed with an underscore to indicate visibility 40 | ERROR | [ ] Missing member variable doc comment 40 | ERROR | [ ] Class property $_first should use lowerCamel naming without underscores 42 | ERROR | [x] Whitespace found at end of line 43 | ERROR | [x] Line indented incorrectly; expected 2 spaces, found 4 44 | ERROR | [x] Doc comment short description must end with a full stop 45 | ERROR | [x] Whitespace found at end of line 46 | ERROR | [x] Data types in @param tags need to be fully namespaced 46 | ERROR | [x] Whitespace found at end of line 46 | ERROR | [x] Parameter comment must be on the next line 47 | ERROR | [x] Parameter comment indentation must be 3 spaces, found 43 spaces 47 | ERROR | [ ] Parameter comment must start with a capital letter 47 | ERROR | [x] Parameter comment must end with a full stop 48 | ERROR | [x] Expected 1 spaces after parameter type; 17 found 48 | ERROR | [x] Whitespace found at end of line 48 | ERROR | [x] Parameter comment must be on the next line 49 | ERROR | [x] Parameter comment indentation must be 3 spaces, found 43 spaces 49 | ERROR | [ ] Parameter comment must start with a capital letter 49 | ERROR | [x] Parameter comment must end with a full stop 50 | ERROR | [x] Expected 1 spaces after parameter type; 18 found 50 | ERROR | [x] Whitespace found at end of line 50 | ERROR | [x] Parameter comment must be on the next line 51 | ERROR | [x] Parameter comment indentation must be 3 spaces, found 43 spaces 51 | ERROR | [ ] Parameter comment must start with a capital letter 51 | ERROR | [x] Parameter comment must end with a full stop 52 | ERROR | [x] Expected 1 spaces after parameter type; 18 found 52 | ERROR | [x] Whitespace found at end of line 52 | ERROR | [x] Parameter comment must be on the next line 53 | ERROR | [x] Parameter comment indentation must be 3 spaces, found 43 spaces 53 | ERROR | [ ] Parameter comment must start with a capital letter 53 | ERROR | [x] Parameter comment must end with a full stop 54 | ERROR | [x] Expected 1 spaces after parameter type; 5 found 54 | ERROR | [x] Data types in @param tags need to be fully namespaced 54 | ERROR | [x] Whitespace found at end of line 54 | ERROR | [x] Parameter comment must be on the next line 55 | ERROR | [x] Parameter comment indentation must be 3 spaces, found 43 spaces 55 | ERROR | [ ] Parameter comment must start with a capital letter 56 | ERROR | [x] Whitespace found at end of line 57 | ERROR | [x] Parameter comment must end with a full stop 58 | ERROR | [x] Whitespace found at end of line 60 | ERROR | [x] Return comment indentation must be 3 spaces, found 1 spaces 62 | ERROR | [x] Line indented incorrectly; expected 2 spaces, found 4 62 | ERROR | [x] Expected 1 blank line before function; 2 found 64 | ERROR | [x] Whitespace found at end of line 65 | ERROR | [x] Whitespace found at end of line 66 | ERROR | [x] Whitespace found at end of line 69 | ERROR | [x] Line indented incorrectly; expected 4 spaces, found 8 70 | ERROR | [x] Line indented incorrectly; expected 4 spaces, found 8 71 | ERROR | [x] Line indented incorrectly; expected 4 spaces, found 8 73 | ERROR | [x] Line indented incorrectly; expected 4 spaces, found 8 74 | ERROR | [x] Line indented incorrectly; expected 6 spaces, found 12 75 | ERROR | [x] Whitespace found at end of line 76 | ERROR | [x] Whitespace found at end of line 77 | WARNING | [x] A comma should follow the last multiline array item. Found: 'ephoto-dam-field-versions-button' 80 | ERROR | [x] Line indented incorrectly; expected 6 spaces, found 12 80 | ERROR | [x] Whitespace found at end of line 81 | ERROR | [x] Line indented incorrectly; expected 8 spaces, found 16 82 | ERROR | [x] Line indented incorrectly; expected 6 spaces, found 12 83 | ERROR | [x] Line indented incorrectly; expected 6 spaces, found 12 84 | ERROR | [x] Array indentation error, expected 14 spaces but found 16 85 | ERROR | [x] Array indentation error, expected 14 spaces but found 16 85 | WARNING | [ ] t() calls should be avoided in classes, use \Drupal\Core\StringTranslation\StringTranslationTrait and $this->t() instead 86 | ERROR | [x] Array indentation error, expected 14 spaces but found 16 87 | ERROR | [x] Array indentation error, expected 14 spaces but found 16 89 | ERROR | [x] Whitespace found at end of line 90 | ERROR | [x] Whitespace found at end of line 91 | WARNING | [x] A comma should follow the last multiline array item. Found: '\'].selectVersions();return false' 95 | ERROR | [x] Line indented incorrectly; expected 6 spaces, found 12 96 | ERROR | [x] Line indented incorrectly; expected 8 spaces, found 16 96 | ERROR | [x] Whitespace found at end of line 97 | ERROR | [x] Whitespace found at end of line 98 | ERROR | [x] TRUE, FALSE and NULL must be uppercase; expected "NULL" but found "null" 100 | ERROR | [x] Line indented incorrectly; expected 8 spaces, found 16 100 | ERROR | [x] Whitespace found at end of line 101 | ERROR | [x] Whitespace found at end of line 102 | ERROR | [x] TRUE, FALSE and NULL must be uppercase; expected "NULL" but found "null" 104 | ERROR | [x] Line indented incorrectly; expected 8 spaces, found 16 111 | ERROR | [x] Whitespace found at end of line 112 | ERROR | [x] Whitespace found at end of line 113 | ERROR | [x] Whitespace found at end of line 114 | ERROR | [x] Concat operator must be surrounded by a single space 116 | WARNING | [x] A comma should follow the last multiline array item. Found: ] 117 | WARNING | [x] A comma should follow the last multiline array item. Found: ] 120 | ERROR | [x] Line indented incorrectly; expected 8 spaces, found 16 122 | WARNING | [ ] t() calls should be avoided in classes, use \Drupal\Core\StringTranslation\StringTranslationTrait and $this->t() instead 125 | ERROR | [x] Whitespace found at end of line 126 | ERROR | [x] Use null coalesce operator instead of ternary operator. 126 | ERROR | [x] Whitespace found at end of line 127 | ERROR | [x] TRUE, FALSE and NULL must be uppercase; expected "NULL" but found "null" 133 | WARNING | [x] A comma should follow the last multiline array item. Found: 'this.focus();this.select()' 134 | WARNING | [x] A comma should follow the last multiline array item. Found: ] 135 | ERROR | [x] Whitespace found at end of line 137 | ERROR | [x] Line indented incorrectly; expected 8 spaces, found 16 139 | WARNING | [ ] t() calls should be avoided in classes, use \Drupal\Core\StringTranslation\StringTranslationTrait and $this->t() instead 146 | WARNING | [x] A comma should follow the last multiline array item. Found: 'this.focus();this.select()' 147 | WARNING | [x] A comma should follow the last multiline array item. Found: ] 148 | ERROR | [x] Whitespace found at end of line 149 | ERROR | [x] Line indented incorrectly; expected 6 spaces, found 12 150 | ERROR | [x] Line indented incorrectly; expected 4 spaces, found 8 152 | ERROR | [x] Line indented incorrectly; expected 4 spaces, found 8 153 | ERROR | [x] Line indented incorrectly; expected 4 spaces, found 8 154 | ERROR | [x] Line indented incorrectly; expected 6 spaces, found 12 155 | ERROR | [x] Line indented incorrectly; expected 4 spaces, found 8 156 | ERROR | [x] Line indented incorrectly; expected 4 spaces, found 8 158 | ERROR | [x] Line indented incorrectly; expected 4 spaces, found 8 160 | WARNING | [ ] t() calls should be avoided in classes, use \Drupal\Core\StringTranslation\StringTranslationTrait and $this->t() instead 160 | ERROR | [x] Concat operator must be surrounded by a single space 163 | ERROR | [x] Whitespace found at end of line 164 | ERROR | [x] Use null coalesce operator instead of ternary operator. 164 | ERROR | [x] Whitespace found at end of line 165 | ERROR | [x] TRUE, FALSE and NULL must be uppercase; expected "NULL" but found "null" 168 | ERROR | [x] Whitespace found at end of line 169 | ERROR | [x] Whitespace found at end of line 173 | ERROR | [ ] The array declaration extends to column 83 (the limit is 80). The array content should be split up over multiple lines 174 | ERROR | [x] Whitespace found at end of line 175 | WARNING | [x] A comma should follow the last multiline array item. Found: 'this.focus();this.select()' 175 | ERROR | [x] Whitespace found at end of line 176 | WARNING | [x] A comma should follow the last multiline array item. Found: ] 179 | ERROR | [x] Line indented incorrectly; expected 4 spaces, found 8 179 | ERROR | [ ] The array declaration extends to column 81 (the limit is 80). The array content should be split up over multiple lines 180 | ERROR | [x] Line indented incorrectly; expected 4 spaces, found 8 182 | ERROR | [x] Line indented incorrectly; expected 4 spaces, found 8 183 | ERROR | [x] Line indented incorrectly; expected 6 spaces, found 12 184 | ERROR | [x] Line indented incorrectly; expected 6 spaces, found 12 185 | ERROR | [x] Line indented incorrectly; expected 4 spaces, found 8 185 | ERROR | [x] Whitespace found at end of line 187 | ERROR | [x] Line indented incorrectly; expected 4 spaces, found 8 190 | ERROR | [x] Whitespace found at end of line 194 | ERROR | [x] Use null coalesce operator instead of ternary operator. 194 | ERROR | [x] TRUE, FALSE and NULL must be uppercase; expected "NULL" but found "null" 197 | ERROR | [x] Whitespace found at end of line 198 | ERROR | [x] Whitespace found at end of line 203 | WARNING | [ ] t() calls should be avoided in classes, use \Drupal\Core\StringTranslation\StringTranslationTrait and $this->t() instead 204 | ERROR | [x] Whitespace found at end of line 205 | WARNING | [x] A comma should follow the last multiline array item. Found: 'this.focus();this.select()' 205 | ERROR | [x] Whitespace found at end of line 206 | WARNING | [x] A comma should follow the last multiline array item. Found: ] 209 | ERROR | [x] Line indented incorrectly; expected 4 spaces, found 8 210 | ERROR | [x] Line indented incorrectly; expected 4 spaces, found 8 212 | ERROR | [x] Line indented incorrectly; expected 4 spaces, found 8 212 | ERROR | [x] Whitespace found at end of line 215 | ERROR | [x] Line indented incorrectly; expected 6 spaces, found 12 216 | ERROR | [x] Line indented incorrectly; expected 6 spaces, found 12 217 | ERROR | [x] Line indented incorrectly; expected 4 spaces, found 8 219 | ERROR | [x] Line indented incorrectly; expected 4 spaces, found 8 222 | ERROR | [x] Whitespace found at end of line 223 | ERROR | [x] Whitespace found at end of line 224 | ERROR | [x] Whitespace found at end of line 225 | ERROR | [x] TRUE, FALSE and NULL must be uppercase; expected "NULL" but found "null" 228 | ERROR | [x] Whitespace found at end of line 230 | WARNING | [ ] t() calls should be avoided in classes, use \Drupal\Core\StringTranslation\StringTranslationTrait and $this->t() instead 233 | WARNING | [ ] t() calls should be avoided in classes, use \Drupal\Core\StringTranslation\StringTranslationTrait and $this->t() instead 233 | ERROR | [x] Whitespace found at end of line 234 | WARNING | [x] A comma should follow the last multiline array item. Found: 'this.focus();this.select()' 234 | ERROR | [x] Whitespace found at end of line 235 | WARNING | [x] A comma should follow the last multiline array item. Found: ] 238 | ERROR | [x] Line indented incorrectly; expected 4 spaces, found 8 239 | ERROR | [x] Whitespace found at end of line 240 | ERROR | [x] Whitespace found at end of line 241 | WARNING | [x] A comma should follow the last multiline array item. Found: 'ephoto-dam-field-file-button' 243 | ERROR | [x] Line indented incorrectly; expected 4 spaces, found 8 244 | ERROR | [x] Line indented incorrectly; expected 6 spaces, found 13 245 | ERROR | [x] Line indented incorrectly; expected 4 spaces, found 8 247 | ERROR | [x] Line indented incorrectly; expected 4 spaces, found 8 249 | WARNING | [ ] t() calls should be avoided in classes, use \Drupal\Core\StringTranslation\StringTranslationTrait and $this->t() instead 253 | ERROR | [x] Whitespace found at end of line 254 | ERROR | [x] Whitespace found at end of line 255 | ERROR | [x] Whitespace found at end of line 256 | ERROR | [x] Whitespace found at end of line 257 | ERROR | [x] Whitespace found at end of line 258 | WARNING | [x] A comma should follow the last multiline array item. Found: ');return false' 259 | WARNING | [x] A comma should follow the last multiline array item. Found: ] 262 | ERROR | [x] Line indented incorrectly; expected 4 spaces, found 8 262 | ERROR | [x] Inline comments must end in full-stops, exclamation marks, question marks, colons, or closing parentheses 263 | ERROR | [x] Line indented incorrectly; expected 4 spaces, found 8 263 | ERROR | [x] Whitespace found at end of line 266 | ERROR | [x] Line indented incorrectly; expected 6 spaces, found 12 267 | ERROR | [x] Line indented incorrectly; expected 6 spaces, found 12 268 | ERROR | [x] Line indented incorrectly; expected 8 spaces, found 16 269 | ERROR | [x] Line indented incorrectly; expected 6 spaces, found 12 270 | ERROR | [x] Line indented incorrectly; expected 6 spaces, found 12 270 | ERROR | [x] Whitespace found at end of line 271 | ERROR | [x] Whitespace found at end of line 272 | ERROR | [x] TRUE, FALSE and NULL must be uppercase; expected "NULL" but found "null" 274 | ERROR | [x] Line indented incorrectly; expected 6 spaces, found 12 278 | ERROR | [x] Whitespace found at end of line 280 | ERROR | [x] Whitespace found at end of line 281 | ERROR | [x] Whitespace found at end of line 282 | ERROR | [x] Whitespace found at end of line 283 | ERROR | [x] Whitespace found at end of line 284 | ERROR | [x] Whitespace found at end of line 285 | ERROR | [x] Whitespace found at end of line 288 | ERROR | [x] Array indentation error, expected 18 spaces but found 20 289 | WARNING | [x] A comma should follow the last multiline array item. Found: ] 292 | ERROR | [x] Line indented incorrectly; expected 6 spaces, found 12 294 | WARNING | [ ] t() calls should be avoided in classes, use \Drupal\Core\StringTranslation\StringTranslationTrait and $this->t() instead 294 | ERROR | [x] Concat operator must be surrounded by a single space 297 | ERROR | [x] Whitespace found at end of line 298 | ERROR | [x] Use null coalesce operator instead of ternary operator. 298 | ERROR | [x] Whitespace found at end of line 299 | ERROR | [x] TRUE, FALSE and NULL must be uppercase; expected "NULL" but found "null" 305 | WARNING | [x] A comma should follow the last multiline array item. Found: 'this.focus();this.select()' 306 | WARNING | [x] A comma should follow the last multiline array item. Found: ] 307 | ERROR | [x] Whitespace found at end of line 308 | ERROR | [x] Line indented incorrectly; expected 4 spaces, found 8 308 | ERROR | [x] Whitespace found at end of line 310 | ERROR | [x] Line indented incorrectly; expected 4 spaces, found 8 311 | ERROR | [x] Line indented incorrectly; expected 6 spaces, found 12 311 | ERROR | [x] Whitespace found at end of line 312 | ERROR | [x] Line indented incorrectly; expected 6 spaces, found 12 313 | ERROR | [x] Line indented incorrectly; expected 6 spaces, found 12 314 | ERROR | [x] Line indented incorrectly; expected 6 spaces, found 12 315 | ERROR | [x] Line indented incorrectly; expected 4 spaces, found 8 316 | ERROR | [x] Whitespace found at end of line 317 | ERROR | [x] Line indented incorrectly; expected 4 spaces, found 8 317 | ERROR | [x] TRUE, FALSE and NULL must be uppercase; expected "TRUE" but found "true" 319 | ERROR | [x] Line indented incorrectly; expected 4 spaces, found 8 320 | ERROR | [x] Line indented incorrectly; expected 2 spaces, found 4 320 | ERROR | [x] Expected 1 blank line after function; 0 found ---------------------------------------------------------------------------------------------------------------------------------------------- PHPCBF CAN FIX THE 216 MARKED SNIFF VIOLATIONS AUTOMATICALLY ---------------------------------------------------------------------------------------------------------------------------------------------- FILE: ephoto_dam/modules/ephoto_dam_field/src/Plugin/Validation/Constraint/EphotoDamFieldConstraint.php --------------------------------------------------------------------------------------------------------------------------------------- FOUND 18 ERRORS AND 2 WARNINGS AFFECTING 17 LINES --------------------------------------------------------------------------------------------------------------------------------------- 3 | ERROR | [x] Namespaced classes, interfaces and traits should not begin with a file doc comment 5 | ERROR | [ ] Doc comment short description must end with a full stop 5 | ERROR | [ ] Doc comment short description must be on a single line, further text should be a separate paragraph 6 | ERROR | [x] Whitespace found at end of line 8 | ERROR | [x] Tag value indented incorrectly; expected 1 space but found 2 9 | WARNING | [ ] @author tags are not usually used in Drupal, because over time multiple contributors will touch the code anyway 9 | ERROR | [x] Tag value indented incorrectly; expected 1 space but found 3 10 | ERROR | [x] Tag value indented incorrectly; expected 1 space but found 2 11 | ERROR | [x] Tag value indented incorrectly; expected 1 space but found 5 12 | ERROR | [x] Whitespace found at end of line 16 | ERROR | [x] There must be one blank line after the last USE statement; 3 found; 19 | ERROR | [ ] More than 2 empty lines are not allowed 21 | ERROR | [ ] Doc comment short description must end with a full stop 22 | ERROR | [x] Whitespace found at end of line 24 | ERROR | [x] Tag value indented incorrectly; expected 1 space but found 2 25 | WARNING | [ ] @author tags are not usually used in Drupal, because over time multiple contributors will touch the code anyway 25 | ERROR | [x] Tag value indented incorrectly; expected 1 space but found 3 26 | ERROR | [x] Tag value indented incorrectly; expected 1 space but found 2 27 | ERROR | [x] Tag value indented incorrectly; expected 1 space but found 5 30 | ERROR | [x] Opening brace should be on the same line as the declaration --------------------------------------------------------------------------------------------------------------------------------------- PHPCBF CAN FIX THE 14 MARKED SNIFF VIOLATIONS AUTOMATICALLY --------------------------------------------------------------------------------------------------------------------------------------- FILE: ephoto_dam/modules/ephoto_dam_field/src/Plugin/Validation/Constraint/EphotoDamFieldConstraintValidator.php ------------------------------------------------------------------------------------------------------------------------------------------------ FOUND 75 ERRORS AND 3 WARNINGS AFFECTING 57 LINES ------------------------------------------------------------------------------------------------------------------------------------------------ 1 | ERROR | [x] The PHP open tag must be followed by exactly one blank line 2 | ERROR | [x] Namespaced classes, interfaces and traits should not begin with a file doc comment 4 | ERROR | [ ] Doc comment short description must end with a full stop 4 | ERROR | [ ] Doc comment short description must be on a single line, further text should be a separate paragraph 5 | ERROR | [x] Whitespace found at end of line 7 | ERROR | [x] Tag value indented incorrectly; expected 1 space but found 2 8 | WARNING | [ ] @author tags are not usually used in Drupal, because over time multiple contributors will touch the code anyway 8 | ERROR | [x] Tag value indented incorrectly; expected 1 space but found 3 9 | ERROR | [x] Tag value indented incorrectly; expected 1 space but found 2 10 | ERROR | [x] Tag value indented incorrectly; expected 1 space but found 5 11 | ERROR | [x] Whitespace found at end of line 18 | ERROR | [x] There must be one blank line after the last USE statement; 3 found; 21 | ERROR | [ ] More than 2 empty lines are not allowed 22 | ERROR | [x] Line indented incorrectly; expected 0 spaces, found 1 23 | ERROR | [x] Doc comment short description must end with a full stop 24 | ERROR | [x] Whitespace found at end of line 26 | ERROR | [x] Tag value indented incorrectly; expected 1 space but found 2 27 | WARNING | [ ] @author tags are not usually used in Drupal, because over time multiple contributors will touch the code anyway 27 | ERROR | [x] Tag value indented incorrectly; expected 1 space but found 3 28 | ERROR | [x] Tag value indented incorrectly; expected 1 space but found 2 29 | ERROR | [x] Tag value indented incorrectly; expected 1 space but found 5 30 | ERROR | [x] There must be exactly one newline after the class comment 32 | ERROR | [x] Whitespace found at end of line 33 | ERROR | [x] Whitespace found at end of line 35 | ERROR | [x] Opening brace should be on the same line as the declaration 36 | ERROR | [x] Line indented incorrectly; expected 2 spaces, found 4 39 | ERROR | [x] Line indented incorrectly; expected 2 spaces, found 4 39 | ERROR | [x] Expected 1 blank line before function; 0 found 39 | ERROR | [x] Whitespace found at end of line 40 | ERROR | [x] Opening brace should be on the same line as the declaration 41 | ERROR | [x] Whitespace found at end of line 42 | ERROR | [x] Line indented incorrectly; expected 2 spaces, found 4 44 | ERROR | [x] Line indented incorrectly; expected 2 spaces, found 4 45 | ERROR | [x] Doc comment short description must end with a full stop 46 | ERROR | [x] Whitespace found at end of line 47 | ERROR | [ ] Parameter comment must start with a capital letter 47 | ERROR | [x] Data types in @param tags need to be fully namespaced 47 | ERROR | [x] Parameter comment must be on the next line 47 | ERROR | [x] Parameter comment must end with a full stop 48 | ERROR | [x] Whitespace found at end of line 50 | ERROR | [x] Return comment indentation must be 3 spaces, found 38 spaces 52 | ERROR | [x] Line indented incorrectly; expected 2 spaces, found 4 52 | ERROR | [x] Whitespace found at end of line 53 | ERROR | [x] Opening brace should be on the same line as the declaration 54 | ERROR | [x] Line indented incorrectly; expected 4 spaces, found 8 55 | ERROR | [x] Line indented incorrectly; expected 2 spaces, found 4 57 | ERROR | [x] Line indented incorrectly; expected 2 spaces, found 4 58 | ERROR | [x] Doc comment short description must end with a full stop 59 | ERROR | [x] Whitespace found at end of line 60 | ERROR | [x] Expected 1 spaces after parameter type; 6 found 60 | ERROR | [ ] Parameter comment must start with a capital letter 60 | ERROR | [x] Parameter comment must be on the next line 60 | ERROR | [x] Parameter comment must end with a full stop 61 | ERROR | [ ] Parameter comment must start with a capital letter 61 | ERROR | [x] Data types in @param tags need to be fully namespaced 61 | ERROR | [x] Parameter comment must be on the next line 61 | ERROR | [x] Parameter comment must end with a full stop 62 | ERROR | [x] Whitespace found at end of line 64 | ERROR | [x] Return comment indentation must be 3 spaces, found 38 spaces 66 | ERROR | [x] Line indented incorrectly; expected 2 spaces, found 4 66 | ERROR | [ ] Type hint "Media" missing for $field 66 | ERROR | [x] Whitespace found at end of line 67 | ERROR | [x] Opening brace should be on the same line as the declaration 68 | ERROR | [x] Line indented incorrectly; expected 4 spaces, found 8 69 | ERROR | [x] Line indented incorrectly; expected 6 spaces, found 12 69 | ERROR | [x] TRUE, FALSE and NULL must be uppercase; expected "NULL" but found "null" 70 | ERROR | [x] Line indented incorrectly; expected 4 spaces, found 8 72 | ERROR | [x] Line indented incorrectly; expected 4 spaces, found 8 72 | ERROR | [x] Whitespace found at end of line 73 | ERROR | [x] Whitespace found at end of line 76 | ERROR | [x] Line indented incorrectly; expected 4 spaces, found 8 76 | WARNING | [ ] t() calls should be avoided in classes, use \Drupal\Core\StringTranslation\StringTranslationTrait and $this->t() instead 85 | ERROR | [x] Whitespace found at end of line 86 | ERROR | [x] Line indented incorrectly; expected 4 spaces, found 8 87 | ERROR | [x] Line indented incorrectly; expected 6 spaces, found 12 88 | ERROR | [x] Line indented incorrectly; expected 4 spaces, found 8 89 | ERROR | [x] Line indented incorrectly; expected 2 spaces, found 4 89 | ERROR | [x] Expected 1 blank line after function; 0 found ------------------------------------------------------------------------------------------------------------------------------------------------ PHPCBF CAN FIX THE 68 MARKED SNIFF VIOLATIONS AUTOMATICALLY ------------------------------------------------------------------------------------------------------------------------------------------------ FILE: ephoto_dam/plugin/plugin.css ---------------------------------------------------------------------------- FOUND 52 ERRORS AFFECTING 49 LINES ---------------------------------------------------------------------------- 2 | ERROR | [x] Line indented incorrectly; expected 2 spaces, found 4 2 | ERROR | [x] Expected 1 space after colon in style definition; 0 found 3 | ERROR | [x] Line indented incorrectly; expected 2 spaces, found 4 3 | ERROR | [x] Expected 1 space after colon in style definition; 0 found 3 | ERROR | [ ] Style definitions must end with a semicolon 7 | ERROR | [x] Line indented incorrectly; expected 2 spaces, found 4 8 | ERROR | [x] Line indented incorrectly; expected 2 spaces, found 4 9 | ERROR | [x] Line indented incorrectly; expected 2 spaces, found 4 10 | ERROR | [x] Line indented incorrectly; expected 2 spaces, found 4 14 | ERROR | [x] Line indented incorrectly; expected 2 spaces, found 4 18 | ERROR | [x] Line indented incorrectly; expected 2 spaces, found 4 19 | ERROR | [x] Line indented incorrectly; expected 2 spaces, found 4 20 | ERROR | [x] Line indented incorrectly; expected 2 spaces, found 4 21 | ERROR | [x] Line indented incorrectly; expected 2 spaces, found 4 22 | ERROR | [x] Line indented incorrectly; expected 2 spaces, found 4 23 | ERROR | [x] Line indented incorrectly; expected 2 spaces, found 4 24 | ERROR | [x] Line indented incorrectly; expected 2 spaces, found 4 25 | ERROR | [x] Line indented incorrectly; expected 2 spaces, found 4 29 | ERROR | [x] Line indented incorrectly; expected 2 spaces, found 4 30 | ERROR | [x] Line indented incorrectly; expected 2 spaces, found 4 31 | ERROR | [x] Line indented incorrectly; expected 2 spaces, found 4 32 | ERROR | [x] Line indented incorrectly; expected 2 spaces, found 4 33 | ERROR | [x] Line indented incorrectly; expected 2 spaces, found 4 34 | ERROR | [x] Line indented incorrectly; expected 2 spaces, found 4 35 | ERROR | [x] Line indented incorrectly; expected 2 spaces, found 4 36 | ERROR | [x] Line indented incorrectly; expected 2 spaces, found 4 39 | ERROR | [x] Whitespace found at end of line 40 | ERROR | [x] Line indented incorrectly; expected 2 spaces, found 4 41 | ERROR | [x] Line indented incorrectly; expected 2 spaces, found 4 45 | ERROR | [x] Line indented incorrectly; expected 2 spaces, found 4 49 | ERROR | [x] Line indented incorrectly; expected 2 spaces, found 4 50 | ERROR | [x] Line indented incorrectly; expected 2 spaces, found 4 54 | ERROR | [x] Line indented incorrectly; expected 2 spaces, found 4 58 | ERROR | [x] Line indented incorrectly; expected 2 spaces, found 4 62 | ERROR | [x] Line indented incorrectly; expected 2 spaces, found 4 63 | ERROR | [x] Line indented incorrectly; expected 2 spaces, found 4 64 | ERROR | [x] Line indented incorrectly; expected 2 spaces, found 4 65 | ERROR | [x] Line indented incorrectly; expected 2 spaces, found 4 66 | ERROR | [x] Line indented incorrectly; expected 2 spaces, found 4 67 | ERROR | [x] Line indented incorrectly; expected 2 spaces, found 4 68 | ERROR | [x] Line indented incorrectly; expected 2 spaces, found 4 69 | ERROR | [x] Line indented incorrectly; expected 2 spaces, found 4 70 | ERROR | [x] Line indented incorrectly; expected 2 spaces, found 4 71 | ERROR | [x] Line indented incorrectly; expected 2 spaces, found 4 75 | ERROR | [x] Line indented incorrectly; expected 2 spaces, found 4 79 | ERROR | [x] Line indented incorrectly; expected 2 spaces, found 4 80 | ERROR | [x] Line indented incorrectly; expected 2 spaces, found 4 81 | ERROR | [x] Line indented incorrectly; expected 2 spaces, found 4 82 | ERROR | [x] Line indented incorrectly; expected 2 spaces, found 4 83 | ERROR | [x] Line indented incorrectly; expected 2 spaces, found 4 84 | ERROR | [x] Line indented incorrectly; expected 2 spaces, found 4 85 | ERROR | [x] Line indented incorrectly; expected 2 spaces, found 4 ---------------------------------------------------------------------------- PHPCBF CAN FIX THE 51 MARKED SNIFF VIOLATIONS AUTOMATICALLY ---------------------------------------------------------------------------- FILE: ephoto_dam/README.md ---------------------------------------------------------------------- FOUND 0 ERRORS AND 3 WARNINGS AFFECTING 3 LINES ---------------------------------------------------------------------- 5 | WARNING | Line exceeds 80 characters; contains 118 characters 27 | WARNING | Line exceeds 80 characters; contains 82 characters 31 | WARNING | Line exceeds 80 characters; contains 105 characters ---------------------------------------------------------------------- FILE: ephoto_dam/src/Form/ConfigurationForm.php ---------------------------------------------------------------------------------------------------------------------------------------------- FOUND 140 ERRORS AND 4 WARNINGS AFFECTING 102 LINES ---------------------------------------------------------------------------------------------------------------------------------------------- 1 | ERROR | [x] The PHP open tag must be followed by exactly one blank line 1 | ERROR | [x] Whitespace found at end of line 2 | ERROR | [x] Namespaced classes, interfaces and traits should not begin with a file doc comment 5 | ERROR | [ ] Doc comment short description must end with a full stop 5 | ERROR | [ ] Doc comment short description must be on a single line, further text should be a separate paragraph 6 | ERROR | [x] Whitespace found at end of line 8 | ERROR | [x] Tag value indented incorrectly; expected 1 space but found 2 9 | WARNING | [ ] @author tags are not usually used in Drupal, because over time multiple contributors will touch the code anyway 9 | ERROR | [x] Tag value indented incorrectly; expected 1 space but found 3 10 | ERROR | [x] Tag value indented incorrectly; expected 1 space but found 2 11 | ERROR | [x] Tag value indented incorrectly; expected 1 space but found 5 12 | ERROR | [x] Whitespace found at end of line 14 | ERROR | [x] Whitespace found at end of line 16 | ERROR | [x] Whitespace found at end of line 17 | ERROR | [x] Whitespace found at end of line 20 | ERROR | [x] Doc comment short description must end with a full stop 21 | ERROR | [x] Whitespace found at end of line 23 | ERROR | [x] Tag value indented incorrectly; expected 1 space but found 2 24 | WARNING | [ ] @author tags are not usually used in Drupal, because over time multiple contributors will touch the code anyway 24 | ERROR | [x] Tag value indented incorrectly; expected 1 space but found 3 25 | ERROR | [x] Tag value indented incorrectly; expected 1 space but found 2 26 | ERROR | [x] Tag value indented incorrectly; expected 1 space but found 5 29 | ERROR | [x] Opening brace should be on the same line as the declaration 30 | ERROR | [x] Line indented incorrectly; expected 2 spaces, found 4 31 | ERROR | [x] Doc comment short description must end with a full stop 32 | ERROR | [x] Whitespace found at end of line 33 | ERROR | [x] Whitespace found at end of line 34 | ERROR | [x] Return comment indentation must be 3 spaces, found 1 spaces 35 | ERROR | [x] Whitespace found at end of line 36 | ERROR | [x] Line indented incorrectly; expected 2 spaces, found 4 36 | ERROR | [x] Expected 1 blank line before function; 0 found 36 | ERROR | [x] Whitespace found at end of line 37 | ERROR | [x] Opening brace should be on the same line as the declaration 38 | ERROR | [x] Line indented incorrectly; expected 4 spaces, found 8 38 | ERROR | [x] Whitespace found at end of line 39 | ERROR | [x] Array indentation error, expected 10 spaces but found 12 39 | ERROR | [x] Whitespace found at end of line 40 | ERROR | [x] Whitespace found at end of line 41 | ERROR | [x] Line indented incorrectly; expected 2 spaces, found 4 43 | ERROR | [x] Line indented incorrectly; expected 2 spaces, found 4 44 | ERROR | [x] Doc comment short description must end with a full stop 45 | ERROR | [x] Whitespace found at end of line 47 | ERROR | [x] Whitespace found at end of line 47 | ERROR | [x] Return comment indentation must be 3 spaces, found 1 spaces 48 | ERROR | [x] Whitespace found at end of line 49 | ERROR | [x] Line indented incorrectly; expected 2 spaces, found 4 49 | ERROR | [x] Whitespace found at end of line 50 | ERROR | [x] Opening brace should be on the same line as the declaration 51 | ERROR | [x] Line indented incorrectly; expected 4 spaces, found 8 51 | ERROR | [x] Whitespace found at end of line 52 | ERROR | [x] Line indented incorrectly; expected 2 spaces, found 4 54 | ERROR | [x] Line indented incorrectly; expected 2 spaces, found 4 55 | ERROR | [x] Doc comment short description must end with a full stop 56 | ERROR | [x] Whitespace found at end of line 57 | ERROR | [x] Expected 1 spaces after parameter type; 14 found 57 | ERROR | [ ] Parameter comment must start with a capital letter 57 | ERROR | [x] Parameter comment must be on the next line 57 | ERROR | [x] Parameter comment must end with a full stop 58 | ERROR | [x] Data types in @param tags need to be fully namespaced 58 | ERROR | [x] Parameter comment must be on the next line 58 | ERROR | [x] Parameter comment must end with a full stop 59 | ERROR | [x] Whitespace found at end of line 61 | ERROR | [x] Return comment indentation must be 3 spaces, found 39 spaces 61 | ERROR | [x] Whitespace found at end of line 62 | ERROR | [x] Whitespace found at end of line 63 | ERROR | [x] Line indented incorrectly; expected 2 spaces, found 4 63 | ERROR | [x] Whitespace found at end of line 64 | ERROR | [x] Opening brace should be on the same line as the declaration 65 | ERROR | [x] Line indented incorrectly; expected 4 spaces, found 8 65 | ERROR | [x] Whitespace found at end of line 67 | ERROR | [x] Line indented incorrectly; expected 4 spaces, found 8 68 | ERROR | [x] Array indentation error, expected 10 spaces but found 12 69 | ERROR | [x] Array indentation error, expected 10 spaces but found 12 69 | ERROR | [x] Whitespace found at end of line 70 | ERROR | [x] Array indentation error, expected 10 spaces but found 12 72 | ERROR | [x] Array indentation error, expected 10 spaces but found 12 72 | ERROR | [x] Whitespace found at end of line 73 | ERROR | [x] Array indentation error, expected 10 spaces but found 12 74 | ERROR | [x] Array indentation error, expected 10 spaces but found 12 74 | ERROR | [x] TRUE, FALSE and NULL must be uppercase; expected "TRUE" but found "true" 75 | ERROR | [x] Array indentation error, expected 10 spaces but found 12 76 | WARNING | [x] A comma should follow the last multiline array item. Found: ) 78 | ERROR | [x] Array indentation error, expected 10 spaces but found 12 79 | ERROR | [x] Whitespace found at end of line 81 | ERROR | [x] Line indented incorrectly; expected 4 spaces, found 8 81 | ERROR | [x] Whitespace found at end of line 82 | ERROR | [x] Line indented incorrectly; expected 2 spaces, found 4 82 | ERROR | [x] Whitespace found at end of line 84 | ERROR | [x] Line indented incorrectly; expected 2 spaces, found 4 85 | ERROR | [x] Doc comment short description must end with a full stop 86 | ERROR | [x] Whitespace found at end of line 87 | ERROR | [x] Expected 1 spaces after parameter type; 14 found 87 | ERROR | [ ] Parameter comment must start with a capital letter 87 | ERROR | [x] Parameter comment must be on the next line 87 | ERROR | [x] Parameter comment must end with a full stop 88 | ERROR | [x] Data types in @param tags need to be fully namespaced 88 | ERROR | [x] Parameter comment must be on the next line 88 | ERROR | [x] Parameter comment must end with a full stop 89 | ERROR | [x] Whitespace found at end of line 90 | ERROR | [ ] @return doc comment specified, but function has no return statement 91 | ERROR | [x] Return comment indentation must be 3 spaces, found 39 spaces 93 | ERROR | [x] Line indented incorrectly; expected 2 spaces, found 4 93 | ERROR | [x] Whitespace found at end of line 94 | ERROR | [x] Opening brace should be on the same line as the declaration 95 | ERROR | [x] Line indented incorrectly; expected 4 spaces, found 8 97 | ERROR | [x] Line indented incorrectly; expected 4 spaces, found 8 97 | ERROR | [x] Whitespace found at end of line 99 | ERROR | [x] Line indented incorrectly; expected 4 spaces, found 8 100 | ERROR | [x] Line indented incorrectly; expected 6 spaces, found 12 101 | WARNING | [ ] t() calls should be avoided in classes, use \Drupal\Core\StringTranslation\StringTranslationTrait and $this->t() instead 103 | ERROR | [x] Line indented incorrectly; expected 4 spaces, found 8 105 | ERROR | [x] Line indented incorrectly; expected 4 spaces, found 8 106 | ERROR | [x] Line indented incorrectly; expected 6 spaces, found 12 107 | ERROR | [x] Line indented incorrectly; expected 4 spaces, found 8 107 | ERROR | [x] Whitespace found at end of line 109 | ERROR | [x] Line indented incorrectly; expected 4 spaces, found 8 110 | ERROR | [x] Line indented incorrectly; expected 2 spaces, found 4 110 | ERROR | [x] Whitespace found at end of line 111 | ERROR | [x] Whitespace found at end of line 112 | ERROR | [x] Line indented incorrectly; expected 2 spaces, found 4 113 | ERROR | [x] Doc comment short description must end with a full stop 114 | ERROR | [x] Whitespace found at end of line 115 | ERROR | [x] Expected 1 spaces after parameter type; 14 found 115 | ERROR | [ ] Parameter comment must start with a capital letter 115 | ERROR | [x] Parameter comment must be on the next line 115 | ERROR | [x] Parameter comment must end with a full stop 116 | ERROR | [x] Data types in @param tags need to be fully namespaced 116 | ERROR | [x] Parameter comment must be on the next line 116 | ERROR | [x] Parameter comment must end with a full stop 117 | ERROR | [x] Whitespace found at end of line 118 | ERROR | [ ] @return doc comment specified, but function has no return statement 119 | ERROR | [x] Return comment indentation must be 3 spaces, found 39 spaces 121 | ERROR | [x] Line indented incorrectly; expected 2 spaces, found 4 121 | ERROR | [x] Whitespace found at end of line 122 | ERROR | [x] Opening brace should be on the same line as the declaration 123 | ERROR | [x] Line indented incorrectly; expected 4 spaces, found 8 124 | ERROR | [x] Object operator not indented correctly; expected 10 spaces but found 12 130 | ERROR | [x] Whitespace found at end of line 131 | ERROR | [x] Line indented incorrectly; expected 4 spaces, found 8 132 | ERROR | [x] Line indented incorrectly; expected 2 spaces, found 4 132 | ERROR | [x] Expected 1 blank line after function; 0 found 132 | ERROR | [x] Whitespace found at end of line 133 | ERROR | [x] Expected 1 newline at end of file; 0 found 133 | ERROR | [x] Whitespace found at end of line ---------------------------------------------------------------------------------------------------------------------------------------------- PHPCBF CAN FIX THE 134 MARKED SNIFF VIOLATIONS AUTOMATICALLY ---------------------------------------------------------------------------------------------------------------------------------------------- FILE: ephoto_dam/src/Plugin/CKEditorPlugin/EphotoDam.php ------------------------------------------------------------------------------------------------------------------------------------- FOUND 123 ERRORS AND 13 WARNINGS AFFECTING 111 LINES ------------------------------------------------------------------------------------------------------------------------------------- 3 | ERROR | [x] Namespaced classes, interfaces and traits should not begin with a file doc comment 11 | ERROR | [x] Whitespace found at end of line 13 | ERROR | [x] Tag value indented incorrectly; expected 1 space but found 2 14 | WARNING | [ ] @author tags are not usually used in Drupal, because over time multiple contributors will touch the code anyway 14 | ERROR | [x] Tag value indented incorrectly; expected 1 space but found 3 15 | ERROR | [x] Tag value indented incorrectly; expected 1 space but found 2 16 | ERROR | [x] Tag value indented incorrectly; expected 1 space but found 5 17 | ERROR | [x] Whitespace found at end of line 24 | WARNING | [x] Unused use statement 27 | WARNING | [x] Unused use statement 28 | WARNING | [x] Unused use statement 31 | ERROR | [x] Doc comment short description must end with a full stop 32 | ERROR | [x] Whitespace found at end of line 34 | ERROR | [x] Tag value indented incorrectly; expected 1 space but found 2 35 | WARNING | [ ] @author tags are not usually used in Drupal, because over time multiple contributors will touch the code anyway 35 | ERROR | [x] Tag value indented incorrectly; expected 1 space but found 3 36 | ERROR | [x] Tag value indented incorrectly; expected 1 space but found 2 37 | ERROR | [x] Tag value indented incorrectly; expected 1 space but found 5 38 | WARNING | [ ] The class short comment should describe what the class does and not simply repeat the class name 42 | ERROR | [x] Opening brace should be on the same line as the declaration 43 | ERROR | [x] Whitespace found at end of line 44 | ERROR | [x] Line indented incorrectly; expected 2 spaces, found 4 45 | ERROR | [x] Doc comment short description must end with a full stop 49 | ERROR | [x] Line indented incorrectly; expected 2 spaces, found 4 51 | ERROR | [x] TRUE, FALSE and NULL must be uppercase; expected "TRUE" but found "true" 53 | ERROR | [x] TRUE, FALSE and NULL must be uppercase; expected "TRUE" but found "true" 56 | WARNING | [x] A comma should follow the last multiline array item. Found: 320 58 | ERROR | [x] Whitespace found at end of line 59 | ERROR | [x] Line indented incorrectly; expected 2 spaces, found 4 61 | ERROR | [x] Whitespace found at end of line 62 | ERROR | [ ] Description for the @return value is missing 64 | ERROR | [x] Line indented incorrectly; expected 2 spaces, found 4 64 | ERROR | [x] Whitespace found at end of line 65 | ERROR | [x] Opening brace should be on the same line as the declaration 66 | ERROR | [x] Line indented incorrectly; expected 4 spaces, found 8 67 | ERROR | [x] Line indented incorrectly; expected 2 spaces, found 4 68 | ERROR | [x] Whitespace found at end of line 69 | ERROR | [x] Line indented incorrectly; expected 2 spaces, found 4 70 | ERROR | [x] Doc comment short description must end with a full stop 71 | ERROR | [x] Whitespace found at end of line 72 | ERROR | [x] Data types in @param tags need to be fully namespaced 72 | ERROR | [x] Parameter comment must be on the next line 73 | ERROR | [x] Parameter comment indentation must be 3 spaces, found 23 spaces 73 | ERROR | [ ] Parameter comment must start with a capital letter 73 | ERROR | [x] Parameter comment must end with a full stop 74 | ERROR | [x] Whitespace found at end of line 75 | ERROR | [ ] Description for the @return value is missing 77 | ERROR | [x] Line indented incorrectly; expected 2 spaces, found 4 77 | ERROR | [x] Whitespace found at end of line 78 | ERROR | [x] Opening brace should be on the same line as the declaration 79 | ERROR | [x] Line indented incorrectly; expected 4 spaces, found 8 80 | ERROR | [x] Line indented incorrectly; expected 2 spaces, found 4 81 | ERROR | [x] Whitespace found at end of line 82 | ERROR | [x] Line indented incorrectly; expected 2 spaces, found 4 84 | ERROR | [x] Whitespace found at end of line 85 | ERROR | [ ] Description for the @return value is missing 87 | ERROR | [x] Line indented incorrectly; expected 2 spaces, found 4 87 | ERROR | [x] Whitespace found at end of line 88 | ERROR | [x] Opening brace should be on the same line as the declaration 89 | ERROR | [x] Line indented incorrectly; expected 4 spaces, found 8 90 | ERROR | [x] Array indentation error, expected 10 spaces but found 12 91 | ERROR | [x] Array indentation error, expected 14 spaces but found 16 92 | ERROR | [x] Array indentation error, expected 14 spaces but found 16 92 | ERROR | [x] Whitespace found at end of line 93 | ERROR | [x] Array indentation error, expected 14 spaces but found 16 96 | ERROR | [x] Line indented incorrectly; expected 2 spaces, found 4 98 | ERROR | [x] Line indented incorrectly; expected 2 spaces, found 4 99 | ERROR | [x] Doc comment short description must end with a full stop 100 | ERROR | [x] Whitespace found at end of line 101 | ERROR | [x] Expected 1 spaces after parameter type; 14 found 101 | ERROR | [x] Parameter comment must be on the next line 101 | ERROR | [x] Parameter comment must end with a full stop 102 | ERROR | [x] Data types in @param tags need to be fully namespaced 102 | ERROR | [x] Data types in @param tags need to be fully namespaced 102 | ERROR | [x] Parameter comment must be on the next line 102 | ERROR | [x] Parameter comment must end with a full stop 103 | ERROR | [x] Expected 1 spaces after parameter type; 13 found 103 | ERROR | [x] Data types in @param tags need to be fully namespaced 103 | ERROR | [x] Parameter comment must be on the next line 104 | ERROR | [x] Parameter comment indentation must be 3 spaces, found 39 spaces 104 | ERROR | [ ] Parameter comment must start with a capital letter 104 | ERROR | [x] Parameter comment must end with a full stop 105 | ERROR | [x] Whitespace found at end of line 106 | ERROR | [ ] Description for the @return value is missing 108 | ERROR | [x] Line indented incorrectly; expected 2 spaces, found 4 108 | ERROR | [x] Whitespace found at end of line 109 | ERROR | [x] Whitespace found at end of line 112 | ERROR | [x] Line indented incorrectly; expected 4 spaces, found 8 114 | ERROR | [x] Line indented incorrectly; expected 4 spaces, found 8 116 | ERROR | [x] Line indented incorrectly; expected 4 spaces, found 8 123 | WARNING | [x] A comma should follow the last multiline array item. Found: false 123 | ERROR | [x] TRUE, FALSE and NULL must be uppercase; expected "FALSE" but found "false" 126 | ERROR | [x] Line indented incorrectly; expected 4 spaces, found 8 130 | WARNING | [x] A comma should follow the last multiline array item. Found: false 130 | ERROR | [x] TRUE, FALSE and NULL must be uppercase; expected "FALSE" but found "false" 133 | ERROR | [x] Line indented incorrectly; expected 4 spaces, found 8 138 | WARNING | [x] A comma should follow the last multiline array item. Found: false 138 | ERROR | [x] TRUE, FALSE and NULL must be uppercase; expected "FALSE" but found "false" 141 | ERROR | [x] Line indented incorrectly; expected 4 spaces, found 8 148 | ERROR | [x] TRUE, FALSE and NULL must be uppercase; expected "TRUE" but found "true" 151 | WARNING | [x] A comma should follow the last multiline array item. Found: 20 154 | ERROR | [x] Line indented incorrectly; expected 4 spaces, found 8 161 | ERROR | [x] TRUE, FALSE and NULL must be uppercase; expected "TRUE" but found "true" 164 | WARNING | [x] A comma should follow the last multiline array item. Found: 20 167 | ERROR | [x] Line indented incorrectly; expected 4 spaces, found 8 174 | ERROR | [x] TRUE, FALSE and NULL must be uppercase; expected "TRUE" but found "true" 177 | WARNING | [x] A comma should follow the last multiline array item. Found: 20 180 | ERROR | [x] Line indented incorrectly; expected 4 spaces, found 8 181 | ERROR | [x] Line indented incorrectly; expected 2 spaces, found 4 182 | ERROR | [x] Whitespace found at end of line 183 | ERROR | [x] Line indented incorrectly; expected 2 spaces, found 4 184 | ERROR | [x] Doc comment short description must end with a full stop 186 | ERROR | [x] Parameter comment must be on the next line 186 | ERROR | [x] Parameter comment must end with a full stop 187 | ERROR | [x] Whitespace found at end of line 188 | ERROR | [ ] Description for the @return value is missing 190 | ERROR | [x] Line indented incorrectly; expected 2 spaces, found 4 190 | ERROR | [x] Whitespace found at end of line 191 | ERROR | [x] Opening brace should be on the same line as the declaration 192 | ERROR | [x] Line indented incorrectly; expected 4 spaces, found 8 193 | ERROR | [x] Line indented incorrectly; expected 4 spaces, found 8 195 | ERROR | [x] Line indented incorrectly; expected 4 spaces, found 8 196 | ERROR | [x] Whitespace found at end of line 198 | ERROR | [x] Array indentation error, expected 14 spaces but found 16 199 | ERROR | [x] Array indentation error, expected 14 spaces but found 16 203 | ERROR | [x] Line indented incorrectly; expected 4 spaces, found 8 204 | ERROR | [x] Line indented incorrectly; expected 6 spaces, found 12 205 | ERROR | [x] Line indented incorrectly; expected 4 spaces, found 8 207 | ERROR | [x] Line indented incorrectly; expected 4 spaces, found 8 209 | ERROR | [x] Line indented incorrectly; expected 4 spaces, found 8 210 | ERROR | [x] Line indented incorrectly; expected 6 spaces, found 12 211 | ERROR | [x] Line indented incorrectly; expected 4 spaces, found 8 212 | ERROR | [x] Whitespace found at end of line 213 | ERROR | [x] Line indented incorrectly; expected 4 spaces, found 8 214 | ERROR | [x] Line indented incorrectly; expected 2 spaces, found 4 214 | ERROR | [x] Expected 1 blank line after function; 0 found ------------------------------------------------------------------------------------------------------------------------------------- PHPCBF CAN FIX THE 126 MARKED SNIFF VIOLATIONS AUTOMATICALLY ------------------------------------------------------------------------------------------------------------------------------------- FILE: ephoto_dam/src/Plugin/Filter/EphotoDam.php ------------------------------------------------------------------------------------------------------------------------------------- FOUND 198 ERRORS AND 4 WARNINGS AFFECTING 172 LINES ------------------------------------------------------------------------------------------------------------------------------------- 1 | ERROR | [x] The PHP open tag must be followed by exactly one blank line 2 | ERROR | [x] Namespaced classes, interfaces and traits should not begin with a file doc comment 12 | ERROR | [x] Whitespace found at end of line 14 | ERROR | [x] Tag value indented incorrectly; expected 1 space but found 2 15 | WARNING | [ ] @author tags are not usually used in Drupal, because over time multiple contributors will touch the code anyway 15 | ERROR | [x] Tag value indented incorrectly; expected 1 space but found 3 16 | ERROR | [x] Tag value indented incorrectly; expected 1 space but found 2 17 | ERROR | [x] Tag value indented incorrectly; expected 1 space but found 5 18 | ERROR | [x] Whitespace found at end of line 19 | ERROR | [x] Whitespace found at end of line 29 | ERROR | [ ] Doc comment short description must end with a full stop 30 | ERROR | [x] Whitespace found at end of line 32 | ERROR | [x] Tag value indented incorrectly; expected 1 space but found 2 33 | WARNING | [ ] @author tags are not usually used in Drupal, because over time multiple contributors will touch the code anyway 33 | ERROR | [x] Tag value indented incorrectly; expected 1 space but found 3 34 | ERROR | [x] Tag value indented incorrectly; expected 1 space but found 2 35 | ERROR | [x] Tag value indented incorrectly; expected 1 space but found 5 38 | ERROR | [x] Opening brace should be on the same line as the declaration 40 | ERROR | [x] Line indented incorrectly; expected 2 spaces, found 4 41 | ERROR | [x] Doc comment short description must end with a full stop 45 | ERROR | [x] Line indented incorrectly; expected 2 spaces, found 4 55 | WARNING | [x] A comma should follow the last multiline array item. Found: 'zoom' 57 | ERROR | [x] Whitespace found at end of line 58 | ERROR | [x] Line indented incorrectly; expected 2 spaces, found 4 61 | ERROR | [x] Expected 1 spaces after parameter type; 2 found 61 | ERROR | [x] Parameter comment must be on the next line 62 | ERROR | [x] Parameter comment must be on the next line 63 | ERROR | [x] Expected 1 spaces after parameter type; 2 found 63 | ERROR | [x] Parameter comment must be on the next line 65 | ERROR | [x] Line indented incorrectly; expected 2 spaces, found 4 65 | WARNING | [ ] Possible useless method overriding detected 66 | ERROR | [x] Opening brace should be on the same line as the declaration 67 | ERROR | [x] Line indented incorrectly; expected 4 spaces, found 8 68 | ERROR | [x] Line indented incorrectly; expected 2 spaces, found 4 70 | ERROR | [x] Line indented incorrectly; expected 2 spaces, found 4 73 | ERROR | [x] Data types in @param tags need to be fully namespaced 73 | ERROR | [x] Parameter comment must be on the next line 74 | ERROR | [x] Expected 1 spaces after parameter type; 14 found 74 | ERROR | [x] Parameter comment must be on the next line 75 | ERROR | [x] Expected 1 spaces after parameter type; 13 found 75 | ERROR | [x] Parameter comment must be on the next line 76 | ERROR | [x] Expected 1 spaces after parameter type; 14 found 76 | ERROR | [x] Parameter comment must be on the next line 77 | ERROR | [x] Whitespace found at end of line 78 | ERROR | [ ] Description for the @return value is missing 80 | ERROR | [x] Line indented incorrectly; expected 2 spaces, found 4 81 | ERROR | [x] Whitespace found at end of line 82 | ERROR | [x] Whitespace found at end of line 83 | ERROR | [x] Whitespace found at end of line 86 | ERROR | [x] Line indented incorrectly; expected 4 spaces, found 8 87 | ERROR | [x] Line indented incorrectly; expected 2 spaces, found 4 89 | ERROR | [x] Line indented incorrectly; expected 2 spaces, found 4 90 | ERROR | [x] Doc comment short description must end with a full stop 91 | ERROR | [x] Whitespace found at end of line 92 | ERROR | [x] Parameter comment must be on the next line 92 | ERROR | [x] Parameter comment must end with a full stop 93 | ERROR | [x] Parameter comment must be on the next line 94 | ERROR | [x] Parameter comment indentation must be 3 spaces, found 25 spaces 94 | ERROR | [ ] Parameter comment must start with a capital letter 94 | ERROR | [x] Parameter comment must end with a full stop 95 | ERROR | [x] Whitespace found at end of line 96 | ERROR | [ ] Description for the @return value is missing 96 | ERROR | [x] Data types in @return tags need to be fully namespaced 98 | ERROR | [x] Line indented incorrectly; expected 2 spaces, found 4 98 | ERROR | [x] Whitespace found at end of line 99 | ERROR | [x] Opening brace should be on the same line as the declaration 100 | ERROR | [x] Line indented incorrectly; expected 4 spaces, found 8 101 | ERROR | [x] Whitespace found at end of line 102 | ERROR | [x] Line indented incorrectly; expected 4 spaces, found 8 103 | ERROR | [x] Line indented incorrectly; expected 6 spaces, found 12 104 | ERROR | [x] Line indented incorrectly; expected 8 spaces, found 16 105 | ERROR | [x] Line indented incorrectly; expected 6 spaces, found 12 105 | ERROR | [x] Expected newline after closing brace 106 | ERROR | [x] Line indented incorrectly; expected 8 spaces, found 16 107 | ERROR | [x] Line indented incorrectly; expected 6 spaces, found 12 108 | ERROR | [x] Whitespace found at end of line 109 | ERROR | [x] Line indented incorrectly; expected 6 spaces, found 12 110 | ERROR | [x] Whitespace found at end of line 111 | ERROR | [x] Line indented incorrectly; expected 6 spaces, found 12 112 | ERROR | [x] Line indented incorrectly; expected 4 spaces, found 8 114 | ERROR | [x] Line indented incorrectly; expected 4 spaces, found 8 116 | ERROR | [x] Line indented incorrectly; expected 4 spaces, found 8 117 | ERROR | [x] Line indented incorrectly; expected 2 spaces, found 4 118 | ERROR | [x] Whitespace found at end of line 119 | ERROR | [x] Line indented incorrectly; expected 2 spaces, found 4 120 | ERROR | [x] Doc comment short description must end with a full stop 122 | ERROR | [x] Parameter comment must be on the next line 122 | ERROR | [x] Parameter comment must end with a full stop 123 | ERROR | [x] Whitespace found at end of line 124 | ERROR | [ ] Description for the @return value is missing 126 | ERROR | [x] Line indented incorrectly; expected 2 spaces, found 4 126 | ERROR | [ ] Private method name "EphotoDam::_renderImage" is not in lowerCamel format 126 | ERROR | [x] Whitespace found at end of line 127 | ERROR | [x] Opening brace should be on the same line as the declaration 128 | ERROR | [x] Line indented incorrectly; expected 4 spaces, found 8 130 | ERROR | [x] Line indented incorrectly; expected 4 spaces, found 8 131 | ERROR | [x] Line indented incorrectly; expected 6 spaces, found 12 131 | ERROR | [x] Whitespace found at end of line 133 | ERROR | [x] Line indented incorrectly; expected 4 spaces, found 8 134 | ERROR | [x] Whitespace found at end of line 135 | ERROR | [x] Line indented incorrectly; expected 4 spaces, found 8 136 | ERROR | [x] Line indented incorrectly; expected 4 spaces, found 8 137 | ERROR | [x] Line indented incorrectly; expected 4 spaces, found 8 138 | ERROR | [x] Line indented incorrectly; expected 4 spaces, found 8 139 | ERROR | [x] Line indented incorrectly; expected 4 spaces, found 8 140 | ERROR | [x] Line indented incorrectly; expected 4 spaces, found 8 141 | ERROR | [x] Whitespace found at end of line 142 | ERROR | [x] Line indented incorrectly; expected 4 spaces, found 8 143 | ERROR | [x] Line indented incorrectly; expected 6 spaces, found 12 144 | ERROR | [x] Line indented incorrectly; expected 4 spaces, found 8 145 | ERROR | [x] Whitespace found at end of line 146 | ERROR | [x] Line indented incorrectly; expected 4 spaces, found 8 148 | ERROR | [x] Line indented incorrectly; expected 4 spaces, found 8 149 | ERROR | [x] Line indented incorrectly; expected 6 spaces, found 12 150 | ERROR | [x] Line indented incorrectly; expected 6 spaces, found 12 151 | ERROR | [x] Line indented incorrectly; expected 4 spaces, found 8 152 | ERROR | [x] Whitespace found at end of line 153 | ERROR | [x] Line indented incorrectly; expected 4 spaces, found 8 154 | ERROR | [x] Line indented incorrectly; expected 2 spaces, found 4 155 | ERROR | [x] Whitespace found at end of line 156 | ERROR | [x] Line indented incorrectly; expected 2 spaces, found 4 157 | ERROR | [x] Doc comment short description must end with a full stop 159 | ERROR | [x] Parameter comment must be on the next line 159 | ERROR | [x] Parameter comment must end with a full stop 160 | ERROR | [x] Whitespace found at end of line 161 | ERROR | [ ] Description for the @return value is missing 163 | ERROR | [x] Line indented incorrectly; expected 2 spaces, found 4 163 | ERROR | [ ] Private method name "EphotoDam::_renderEmbed" is not in lowerCamel format 163 | ERROR | [x] Whitespace found at end of line 164 | ERROR | [x] Opening brace should be on the same line as the declaration 165 | ERROR | [x] Line indented incorrectly; expected 4 spaces, found 8 166 | ERROR | [x] Whitespace found at end of line 167 | ERROR | [x] Line indented incorrectly; expected 4 spaces, found 8 168 | ERROR | [x] Line indented incorrectly; expected 6 spaces, found 12 168 | ERROR | [x] Whitespace found at end of line 170 | ERROR | [x] Line indented incorrectly; expected 4 spaces, found 8 171 | ERROR | [x] Whitespace found at end of line 172 | ERROR | [x] Line indented incorrectly; expected 4 spaces, found 8 174 | ERROR | [x] Line indented incorrectly; expected 4 spaces, found 8 175 | ERROR | [x] Line indented incorrectly; expected 4 spaces, found 8 176 | ERROR | [x] Line indented incorrectly; expected 4 spaces, found 8 177 | ERROR | [x] Line indented incorrectly; expected 4 spaces, found 8 178 | ERROR | [x] Line indented incorrectly; expected 4 spaces, found 8 179 | ERROR | [x] Whitespace found at end of line 180 | ERROR | [x] Line indented incorrectly; expected 4 spaces, found 8 181 | ERROR | [x] Line indented incorrectly; expected 6 spaces, found 12 182 | ERROR | [x] Line indented incorrectly; expected 4 spaces, found 8 183 | ERROR | [x] Whitespace found at end of line 184 | ERROR | [x] Line indented incorrectly; expected 4 spaces, found 8 185 | ERROR | [x] Whitespace found at end of line 186 | ERROR | [x] Line indented incorrectly; expected 4 spaces, found 8 187 | ERROR | [x] Line indented incorrectly; expected 6 spaces, found 12 188 | ERROR | [x] Line indented incorrectly; expected 6 spaces, found 12 189 | ERROR | [x] Line indented incorrectly; expected 4 spaces, found 8 191 | ERROR | [x] Line indented incorrectly; expected 4 spaces, found 8 192 | ERROR | [x] Line indented incorrectly; expected 2 spaces, found 4 193 | ERROR | [x] Whitespace found at end of line 194 | ERROR | [x] Line indented incorrectly; expected 2 spaces, found 4 197 | ERROR | [x] Parameter comment must be on the next line 198 | ERROR | [x] Whitespace found at end of line 199 | ERROR | [ ] Description for the @return value must be on the next line 201 | ERROR | [x] Line indented incorrectly; expected 2 spaces, found 4 201 | ERROR | [x] Whitespace found at end of line 202 | ERROR | [x] Opening brace should be on the same line as the declaration 203 | ERROR | [x] Line indented incorrectly; expected 4 spaces, found 8 204 | ERROR | [x] Line indented incorrectly; expected 4 spaces, found 8 221 | ERROR | [x] Line indented incorrectly; expected 6 spaces, found 12 222 | ERROR | [x] Line indented incorrectly; expected 4 spaces, found 8 224 | ERROR | [x] Line indented incorrectly; expected 4 spaces, found 8 225 | ERROR | [x] Whitespace found at end of line 226 | ERROR | [x] Line indented incorrectly; expected 4 spaces, found 8 227 | ERROR | [x] Line indented incorrectly; expected 6 spaces, found 12 228 | ERROR | [x] Line indented incorrectly; expected 6 spaces, found 12 228 | ERROR | [x] TRUE, FALSE and NULL must be uppercase; expected "TRUE" but found "true" 230 | ERROR | [x] Line indented incorrectly; expected 6 spaces, found 12 231 | ERROR | [x] Line indented incorrectly; expected 8 spaces, found 16 232 | ERROR | [x] Line indented incorrectly; expected 6 spaces, found 12 234 | ERROR | [x] Line indented incorrectly; expected 6 spaces, found 12 235 | ERROR | [x] Line indented incorrectly; expected 8 spaces, found 16 236 | ERROR | [x] Line indented incorrectly; expected 6 spaces, found 12 237 | ERROR | [x] Line indented incorrectly; expected 4 spaces, found 8 239 | ERROR | [x] Line indented incorrectly; expected 4 spaces, found 8 240 | ERROR | [x] Line indented incorrectly; expected 2 spaces, found 4 241 | ERROR | [x] Whitespace found at end of line 242 | ERROR | [x] Line indented incorrectly; expected 2 spaces, found 4 245 | ERROR | [x] Parameter comment must be on the next line 246 | ERROR | [x] Whitespace found at end of line 247 | ERROR | [ ] Description for the @return value must be on the next line 249 | ERROR | [x] Line indented incorrectly; expected 2 spaces, found 4 249 | ERROR | [ ] Type hint "array" missing for $settings 249 | ERROR | [x] Whitespace found at end of line 250 | ERROR | [x] Opening brace should be on the same line as the declaration 251 | ERROR | [x] Line indented incorrectly; expected 4 spaces, found 8 252 | ERROR | [x] Line indented incorrectly; expected 6 spaces, found 12 253 | ERROR | [x] Line indented incorrectly; expected 8 spaces, found 16 253 | ERROR | [x] TRUE, FALSE and NULL must be uppercase; expected "FALSE" but found "false" 254 | ERROR | [x] Line indented incorrectly; expected 6 spaces, found 12 255 | ERROR | [x] Line indented incorrectly; expected 4 spaces, found 8 257 | ERROR | [x] Line indented incorrectly; expected 4 spaces, found 8 257 | ERROR | [x] TRUE, FALSE and NULL must be uppercase; expected "TRUE" but found "true" 258 | ERROR | [x] Line indented incorrectly; expected 2 spaces, found 4 258 | ERROR | [x] Expected 1 blank line after function; 0 found ------------------------------------------------------------------------------------------------------------------------------------- PHPCBF CAN FIX THE 188 MARKED SNIFF VIOLATIONS AUTOMATICALLY ------------------------------------------------------------------------------------------------------------------------------------- - 🇺🇸United States greggles Denver, Colorado, USA
Please post phpcs reports as attachments in the future when they are long. It makes it hard to read the issues when a comment is so long like that.
- Status changed to Needs review
almost 2 years ago 8:28am 14 February 2023 - 🇫🇷France ephoto_dam
Thanks for the feed back
I was using phpcs with the default standard, changed it to use the Drupal Standard and fixed the errors. - Status changed to Needs work
almost 2 years ago 8:38am 14 February 2023 - Status changed to Needs review
almost 2 years ago 8:39am 14 February 2023 - Status changed to RTBC
almost 2 years ago 10:26am 14 February 2023 - Assigned to apaderno
- Status changed to Needs review
almost 2 years ago 11:22am 14 February 2023 - Status changed to Needs work
almost 2 years ago 11:59am 14 February 2023 - 🇮🇹Italy apaderno Brescia, 🇮🇹
- The following points are just a start and don't necessarily encompass all of the changes that may be necessary
- A specific point may just be an example and may apply in other places
- A review is about code that doesn't follow the coding standards, contains possible security issue, or doesn't correctly use the Drupal API; the single points aren't ordered, not even by importance
ephoto_dam.module
/** * Hook : implements hook_form_FORM_ID_alter(). */ function ephoto_dam_form_filter_format_form_alter(&$form, FormStateInterface $form_state, $form_id) { // Appel de la méthode ephoto_dam_toolbar_filter_validate() $form['#validate'][] = 'ephoto_dam_toolbar_filter_validate'; // Appel de la méthode ephoto_dam_settings_validate() $form['#validate'][] = 'ephoto_dam_settings_validate'; }Documentation comments for hook implementations start with Implements.
Code comments need to be in English./** * Hook : implements hook_toolbar_filter_validate(). */ function ephoto_dam_toolbar_filter_validate($form, FormStateInterface $form_state) { $filter_enabled = !empty($form_state->getValue( [ 'filters', 'ephoto_dam', 'status' ] )); $button_enabled = ephoto_dam_button_enabled($form_state); if ($filter_enabled !== $button_enabled) { $form_state->setError( $form['filters']['status']['ephoto_dam'], t('To embed the fields Ephoto Dam, make sure you have enabled the filter and dragged the icon into the WYSIWYG toolbar. For more information <a href="@url">read the documentation</a>.', ['@url' => Url::fromRoute('help.page', ['name' => 'ephoto_dam'])->toString()]) ); } }A validation handler, like a submission handler, is not documented to be a hook. Validation handlers have a different documentation comment.
src/Plugin/CKEditorPlugin/EphotoDam.php
/** * {@inheritdoc} */ public function getFile() { return drupal_get_path('module', 'ephoto_dam') . '/plugin/plugin.js'; }drupal_get_path()has been deprecated in Drupal 9.3.x and replaced by\Drupal\Core\Extension\ExtensionPathResolver::getPath()./** * Prepare the settings. * * @param object $editor * The Editor. */ protected function getSettings($editor):array { $editor_settings = $editor->getSettings(); $common_settings = \Drupal::config('ephoto_dam.settings'); $settings = NestedArray::getValue($editor_settings, [ 'plugins', 'ephoto_dam', ]); if (!$settings) { $settings = self::DEFAULT_SETTINGS; } $server_url = $common_settings->get('server_url'); if ($server_url) { $settings['server_url'] = $server_url; } return $settings; }The description of the method purpose could be expanded; the documentation comment does not describe the returned value.
Plugins need to use the Dependency Injection container for their dependencies.
As a side note, that seems over-complicated code, to just add the server URL from the module configuration.src/Form/ConfigurationForm.php
$server_url = filter_var($server_url, FILTER_VALIDATE_URL); if (!$server_url) { $form_state->setErrorByName('settings_server_url', t('Please enter a correct URL')); } if (substr($server_url, -1) !== '/') { $server_url .= '/'; }Since the value of
$server_urlis not stored back in$form_state, appending a slash to$server_urlis useless. The last three lines are also incorrect whenfilter_var()returnsFALSE.
Instead oft(), that method should use$this->t()as the other methods do.src/Plugin/Field/FieldFormatter/EphotoDamFieldFormatter.php
class EphotoDamFieldFormatter extends FormatterBase implements ContainerFactoryPluginInterface {FormatterBasealready implements that interface; there is no need forEphotoDamFieldFormatterto implement it too, since it extendsFormatterBase./** * {@inheritdoc} */ public function viewElements(FieldItemListInterface $items, $langcode) { $element = []; return $element; }A formatter that builds an empty renderable array for a field value makes me think the code is not complete. Projects for these applications should contain complete code, although they are not required to be bug-free.
modules/ephoto_dam_field/src/Plugin/Field/FieldType/EphotoDamField.php
/** * Default settings. * * @const */ private const DEFAULT_SETTINGS = [ 'version_support' => FALSE, 'captions_format' => '', ];Constants are not documented with
@const.$properties['url'] = DataDefinition::create('string') ->setLabel(t('Url'));Why is not
DataDefinition::create('uri')used in that case?modules/ephoto_dam_field/src/Plugin/Validation/Constraint
/* * @category Fiel_Constraint * @package Ephoto-Drupal * @license https://www.ephoto.fr/ Einden */@licensedoes not give a link to a license file, but that would be useless, as PHP code hosted on drupal.org is licensed under a specific license. Which one is it?modules/ephoto_dam_field/src/Plugin/Validation/Constraint/EphotoDamFieldConstraintValidator.php
/** * Create an instance of the validator. */ public function __construct() { } /** * {@inheritdoc} */ public static function create(ContainerInterface $container) { return new static(); }If a class does not need those methods, there is no need to implement them.
modules/ephoto_dam_field/ephoto_dam_field.info.yml
core: '8.x' core_version_requirement: ^8 || ^9 dependencies: - drupal:field - drupal:systemSince Drupal 8 is now not supported, the core requirements should be changed.
The System module is always installed; there is no need to declare it as dependency, if there are not restrictions on its version. - Issue was unassigned.
- Status changed to Needs review
almost 2 years ago 3:50pm 15 February 2023 - 🇫🇷France ephoto_dam
Thanks for all those indications
Changes has been made accordingly to your feedback.One point which couldn't be fixed is in modules/ephoto_dam_field/src/Plugin/Field/FieldType/EphotoDamField.php
Why is not DataDefinition::create('uri') used in that case?
I've tried to use uri instead of string but this raises the following error when we try to create a structure content (translated ) :
This value must be of the correct primitif typeSince I haven't found a solution, I've left string for now.
- Status changed to Needs work
almost 2 years ago 5:49pm 15 February 2023 - 🇮🇹Italy apaderno Brescia, 🇮🇹
What reported after comment #12 is probably for the wrong branch. The 8.x-3.x branch has most of the commits from Arnaud Bour, which means it cannot be used from Fares Cherif (the person who created this application).
The 8.x-2.x branch has commits from Fares Cherif, but Fares Cherif has not done commits since 2020. This means that even what reported before comment #12 has been changed in that branch and the correct status for this application is Needs work.
- 🇮🇹Italy apaderno Brescia, 🇮🇹
As a side note, as comment #2 noted, for the time this application is open, only the user who created the application can commit code. It means that commits from other people will make this application be closed as won't fix.
- Status changed to Needs review
almost 2 years ago 9:40am 16 February 2023 - 🇫🇷France ephoto_dam
I, Mr Arnaud Bour, am responsible for this account and will be the only person using it.
I am the sole owner of it.
I've changed the name of the account into the good one and was responsible for the previous commits.If I where to collaborate with others in my company, is the following process good with you :
- each code what they are tasked with and push it to our private git
- I review it
- I push it to the drupal git - Status changed to Needs work
almost 2 years ago 9:52am 16 February 2023 - 🇮🇹Italy apaderno Brescia, 🇮🇹
I apologize, but you have already said to be Fares Cherif.
It has been already stated that:
- We review a project were most of the commits in at least a branch has been done from the user who applies
- We do not allow multiple users to get the permission to opt projects into security advisory policy using a single application; if there are more than one developer, each developer needs to apply using their own Drupal.org account
- We do not accept applications done from an account used by more than a single person
- 🇫🇷France ephoto_dam
In that case, what should be done ?
Should I put back the name of the account into Fares Cherif and create a new branch with it, thus having the only commit of that branch with the good name, or do you advice something else ? - 🇮🇹Italy apaderno Brescia, 🇮🇹
This application can only continue with the 8.x-2.x branch, since that branch contains commit done from the account used to create this application (i.e ephoto_dam), but that means the account used to create this application must do all the commits in that branch.
- 🇫🇷France ephoto_dam
We've been using the name of the branches as former steps of the project and drupal versions
Therefore, the branches 7.x-1.x and 8.x-2x correspond of former steps and should be closed, however I haven't found a way to do it on drupalgit. Using that former branch would thus be an issue for our clients.
However creating a new branch such as 8.x-4.x or 9.x-4.x since it works on drupal 9 would be perfectly fine. Is that a sensible solution ?On the account of the name of the user, Fares Cherif was a honnest mistake. The real owner of the project and of this account is Arnaud Bour, is it impossible to fix this mistake ?
- 🇮🇹Italy apaderno Brescia, 🇮🇹
Who is the code "owner" is not relevant for these applications. What is important is that the account used to create the application has done commits in a branch, which is what happens with the account ephoto_dam and the 8.x-2.x branch.
- 🇫🇷France ephoto_dam
Alright, so if I understand correctly, if I create a new branch ( for instance 8.x-4.x ) and commit on this new branch using the account ephoto_dam, I can use this branch as the one which is getting verified. Is that correct ?
- 🇮🇹Italy apaderno Brescia, 🇮🇹
There is no need to create a new branch, since the the 8.x-2.x branch already contains commits from the ephoto_dam account.
- 🇫🇷France ephoto_dam
We fixed the branch 8.x-3.x so that only the owner of drupal did commit in it and we corrected the profile of the owner
- Status changed to Closed: won't fix
almost 2 years ago 6:41pm 17 February 2023 - 🇮🇹Italy apaderno Brescia, 🇮🇹
I am sorry, but doing commits like this just to artificially increase the number of commits done using an account does not make a branch suitable for these applications.
Furthermore, I do not think we can trust a person who first said to be using a shared account, who then said the account was not shared, that his name was Fares Cherif and now affirms his name is Bour Arnaud.
- Assigned to ephoto_dam
- Issue was unassigned.