integer with minimum but no maximum causing ValueError: mt_rand(): Argument #2 ($max) must be greater than or equal to argument #1 ($min)

public static function generateSampleValue(FieldDefinitionInterface $field_definition) { $min = $field_definition->getSetting('min') ?: 0; - $max = $field_definition->getSetting('max') ?: 999; + $max = $field_definition->getSetting('max') ?: $min + 999; $values['value'] = mt_rand($min, $max); return $values; }

Comments & Activities

Not all content is available!

It's likely this issue predates Contrib.social: some issue and comment data are missing.

Comment 2 months ago →
🇺🇸United States jvogt Seattle, WA
This didn't end up being addressed in 🐛 Validate the min, max and default values for Numeric fields Fixed . This remains an issue if min >= 1000 and max is not set in the field settings. I've re-rolled the patch for 10.3.
Status changed to Needs review 2 months ago5:26pm 3 September 2024
Comment 2 months ago →
🇺🇸United States jvogt Seattle, WA
Status changed to Needs work 2 months ago12:52am 4 September 2024
Comment 2 months ago →
🇺🇸United States smustgrave
Thanks for reporting but fixes should be in an MR and most likely will need test coverage
Assigned to arunkumark
Comment 2 months ago →
🇮🇳India arunkumark Coimbatore
Comment 2 months ago →
🇮🇳India arunkumark Coimbatore
Created MR and added test case for Integer item without max value.
Merge request !9412integer with minimum but no maximum causing ValueError → (Open) created by arunkumark
Issue was unassigned.
Status changed to Needs review 2 months ago10:22am 4 September 2024
Pipeline finished with Success
2 months ago
Total: 482s
#273382
Status changed to Needs work 2 months ago2:08pm 9 September 2024
Comment 2 months ago →
🇺🇸United States smustgrave
Left a comment on the MR.

integer with minimum but no maximum causing ValueError: mt_rand(): Argument #2 ($max) must be greater than or equal to argument #1 ($min)

Problem/Motivation

Steps to reproduce

Proposed resolution

Merge Requests

!9412integer with minimum but no maximum causing ValueError: mt_rand(): Argument #2 ($max) must be greater than or equal to argument #1 ($min)
Open

Comments & Activities

integer with minimum but no maximum causing ValueError: mt_rand(): Argument #2 ($max) must be greater than or equal to argument #1 ($min)

Problem/Motivation

Steps to reproduce

Proposed resolution

Merge Requests

!9412integer with minimum but no maximum causing ValueError: mt_rand(): Argument #2 ($max) must be greater than or equal to argument #1 ($min)Open

Comments & Activities

!9412integer with minimum but no maximum causing ValueError: mt_rand(): Argument #2 ($max) must be greater than or equal to argument #1 ($min)
Open