Add basic test coverage

@nevergone we already discussed that the tests are less performant then equally implemented Kernel tests, I just wanted to give you a head start here, as you volunteered implementing these tests. No need for the insulting tone. This is Open-Source, everyone is doing their part.

Let's all keep calm and friendly here :) All good. We'll do it like written in #20 or simply close this cluttered issue and create a new one ;)

@Grevil

I'm sorry, I didn't mean to be offensive. I don't want you to do unnecessary work, and I don't want unnecessary code in the module.
It is useless to test uninstall the module, because it does nothing. Nothing happens when the module is installed, but if you do want to test it, this line in any test will do it:

  protected static $modules = [
    'watchdog_mailer',
  ];

If the module cannot be installed, the tests will not run. It is therefore unnecessary to test just the module installation.

@nevergone, understandable. I think I just took it the wrong way, no bad blood.

I agree with @Anybody, let's continue with #20, as soon as there is time!

Some resources for testing mail:

• https://api.drupal.org/api/drupal/core%21lib%21Drupal%21Core%21Test%21As...
• https://api.drupal.org/api/examples/email_example%21tests%21src%21Functi...
• https://www.tag1consulting.com/blog/introducing-drupal-test-traits
• https://www.tag1consulting.com/sites/default/files/blog/files/Introducin...

@LRWebks: Could you please add missing tests to the issue summary you experienced when working on this module?
So this can be improved by anyone going through the list.

Install/uninstall test is obsolote, see related change record: https://www.drupal.org/node/3388092 →

@nevergone thank you, very good point! But that means we have to require drupal:^10.2, which is quite early?

Perhaps better keep the existing tests for now and add a TODO do do this later?

@Anybody:

GenericModuleTestBase support add Drupal core 10.1.5
https://www.drupal.org/project/drupal/releases/10.1.5 →

Would also mean we'd have to remove Drupal 9 compatibility.

Drupal 9 EOL: 2023 Nov 01.

No more ideas why no emails are being sent in the test (or are not shown in result). Please help!

Please test and review.

Please needs a manual rebase, can't be merged currently.

BTW README.txt has been replaced by README.md - I think that's part of the required rebase. It shouldn't be re-introduced.

Merge conflict resolved.

Setting this fixed, as @nevergone already merged this. Still there should be a follow-up to fix the current test issues:

See https://www.drupal.org/node/3027256/qa: →

PHP Fatal error: Uncaught Error: Class "Drupal\Tests\system\Functional\Module\GenericModuleTestBase" not found in /var/www/html/modules/contrib/watchdog_mailer/tests/src/Functional/GenericTest.php:12

I'm still working on this.

Tests supplemented.

@nevergone GREAT WORK! Thank you very much! I'll take a look at the tests soon, very interested how it worked.

Anything left that should be added as tests in a follow-up?

@Anybody:

No, I'm done.

Automatically closed - issue fixed for 2 weeks with no activity.