- Status changed to Active
about 2 years ago 1:09pm 1 February 2023 - π§πͺBelgium wim leers Ghent π§πͺπͺπΊ
π package_manager_bypass should *minimally* bypass php-tuf/composer-stager, not maximally Fixed landed, this is unblocked.
- Assigned to wim leers
- π§πͺBelgium wim leers Ghent π§πͺπͺπΊ
π Explore simplifying our fixture manipulation classes Fixed simplified this further (after π package_manager_bypass should *minimally* bypass php-tuf/composer-stager, not maximally Fixed ), by adding a
fixture_manipulator
module.So at this point I think the
package_manager_bypass
module has been sufficiently simplified that improving its documentation is now very simple. - Issue was unassigned.
- Status changed to RTBC
about 2 years ago 1:45pm 13 February 2023 - π§πͺBelgium wim leers Ghent π§πͺπͺπΊ
This:
- provides an accurate summary of what this module does right in the module description
- renames services to clarify what they actually do
- marks everything
final
and@internal
- gets rid of the base class which was in its name tied to the stager, and turns it into a trait instead
-
Wim Leers β
authored c2c322ca on 8.x-2.x
Issue #3325869 by Wim Leers, omkar.podey: Improve documentation for...
-
Wim Leers β
authored c2c322ca on 8.x-2.x
- Status changed to Fixed
about 2 years ago 3:57pm 13 February 2023 - πΊπΈUnited States tedbow Ithaca, NY, USA
this is so much better. Thanks @Wim Leers!
- Status changed to RTBC
about 2 years ago 5:07pm 13 February 2023 - π§πͺBelgium wim leers Ghent π§πͺπͺπΊ
+++ b/package_manager/tests/modules/package_manager_bypass/src/PackageManagerBypassServiceProvider.php @@ -21,12 +23,13 @@ class PackageManagerBypassServiceProvider extends ServiceProviderBase { + // By default, \Drupal\package_manager_bypass\Stager
I did forget to finish my thought here though π
By writing this comment, I realized
package_manager_bypass
'Stager
,Beginner
andCommitter
all ought to be named differently. So I did.Finishing the thoughtβ¦
-
phenaproxima β
committed 7d085d55 on 8.x-2.x
Issue #3325869 follow-up by Wim Leers
-
phenaproxima β
committed 7d085d55 on 8.x-2.x
- Status changed to Fixed
about 2 years ago 5:16pm 13 February 2023 - πΊπΈUnited States tim.plunkett Philadelphia
Note that this commit broke Project Browser. Several classes used by PB were renamed here and made internal. @tedbow said it wouldn't be reverted, so we're adjusting here: π Fix tests after breaking change in Automatic Updates Fixed
Automatically closed - issue fixed for 2 weeks with no activity.