Explore simplifying our fixture manipulation classes

working on an idea

updating summary

relating 📌 Improve the user experience of having your staged update deleted before it was applied Fixed because in the summary I explain we just found an edge case there.

Thought of what I think is an even simpler solution. Working on it in 3336255-subscriber-manipulator

Ok I like 3336255-subscriber-manipulator much better.

I still want to self review the new MR but ready for review.

tedbow → closed merge request !672

Went through this in detail, had a few questions, but man … this is SO MUCH BETTER! :D

Much simpler than 📌 Improve FixtureManipulator DX: validate package name + ensure StageFixtureManipulator is committed + ensure `package_manager_bypass_composer_stager` is not set to FALSE Fixed 🤩

Testing Drupal\Tests\automatic_updates\Kernel\CronUpdaterTest
.......E.......................                                   31 / 31 (100%)

Time: 00:54.511, Memory: 6.00 MB

There was 1 error:

1) Drupal\Tests\automatic_updates\Kernel\CronUpdaterTest::testStageDestroyedOnError with data set "post-create exception" ('Drupal\package_manager\Event\...eEvent', 'Exception')
LogicException: The StageFixtureManipulator has arguments that were not cleared. This likely means that the PostCreateEvent was never fired.

Per https://git.drupalcode.org/project/automatic_updates/-/merge_requests/67..., RTBC'ing merge request 675, which is a nice simplification over merge request 673! 👏

Thanks for the feedback @Wim Leers!

Automatically closed - issue fixed for 2 weeks with no activity.