- Status changed to RTBC
almost 2 years ago 1:44pm 8 February 2023 - Status changed to Needs work
almost 2 years ago 1:42pm 13 February 2023 - 🇬🇧United Kingdom catch
The 10.1 version of this code uses
str_starts_with()
but looks like it's still potentially passing null, so I think we need a re-roll here. - Status changed to Needs review
almost 2 years ago 1:57pm 13 February 2023 - Status changed to Fixed
almost 2 years ago 4:47pm 13 February 2023 - 🇬🇧United Kingdom catch
Committed/pushed to 10.1.x, and the respective patch to 10.0.x and cherry-picked to 9.5.x, thanks!
- Status changed to Needs work
almost 2 years ago 6:52pm 13 February 2023 - 🇩🇪Germany tstoeckler Essen, Germany
The re-roll for 10.1 was incorrect, the "=== 0" is incorrect. I guess that also means there is no test coverage for that piece of code. Either way should be fixed/reverted at least for 10.1
- Status changed to Needs review
almost 2 years ago 8:12pm 13 February 2023 - 🇫🇷France andypost
There's follow-up as `===0` will always
FALSE
as result isbool
https://www.php.net/manual/en/function.str-starts-with.php - Status changed to Needs work
almost 2 years ago 9:12pm 13 February 2023 The Needs Review Queue Bot → tested this issue. It no longer applies to Drupal core. Therefore, this issue status is now "Needs work".
Apart from a re-roll or rebase, this issue may need more work to address feedback in the issue or MR comments. To progress an issue, incorporate this feedback as part of the process of updating the issue. This helps other contributors to know what is outstanding.
Consult the Drupal Contributor Guide → to find step-by-step guides for working with issues.
- Status changed to Fixed
almost 2 years ago 9:42pm 13 February 2023 - 🇬🇧United Kingdom catch
Committed/pushed the follow-up, whoops and thanks!
Let's open a follow-up for test coverage.
- 🇫🇷France andypost
Thank you, filed follow-up 📌 Add test coverage for layout_builder_entity_view_alter() Active
Automatically closed - issue fixed for 2 weeks with no activity.
- Status changed to Fixed
10 months ago 11:47am 29 February 2024