Items without <title> are not imported

Created on 26 November 2022, about 2 years ago
Updated 7 September 2023, over 1 year ago

Problem/Motivation

The items of an otherwise working RSS feed without "title" field are not imported by Aggregator. This applies e.g. to Mastodon feeds starting with V 4.0

Steps to reproduce

Add a news RSS feed. Use a feed URL of any Mastodon user using Mastodon 4.x
e.g. mine https://kirche.social/@kuschelkirche.rss
It won't import anything.

Check the same feed with nearly any other RSS reader and you will see the latest posts.

I downloaded my RSS feed an edited it by adding a "title" tag for every issue, just for testing. Like this:
<item><title>Testtitel</title>
Add a new RSS feed with this URL:
https://www.kuschelkirche.de/kuschelkirche-mit-Title.rss
It imports withouth any problems

Proposed resolution

Import feed even if "title" is missing.

There's a discussion on the Mastodon side that says "title" is not obligatory and the feed reader should really work without it:
https://github.com/mastodon/mastodon/pull/19290

Remaining tasks

User interface changes

API changes

Data model changes

💬 Support request
Status

Needs review

Version

2.0

Component

Code

Created by

🇩🇪Germany Kniekel

Live updates comments and jobs are added and updated live.
Sign in to follow issues

Comments & Activities

Not all content is available!

It's likely this issue predates Contrib.social: some issue and comment data are missing.

  • Open in Jenkins → Open on Drupal.org →
    Core: 9.5.x + Environment: PHP 8.1 & MySQL 8
    last update over 1 year ago
    148 pass
  • 🇺🇸United States dcam

    Yes, it's the DefaultProcessor that rejects title-less items. Here's a new test using the new DefaultProcessorTest that verifies it. This issue is one of the reasons I wrote it in the first place.

    We would still need to decide what we want and can do about it, if anything. I haven't done any research yet.

  • Open in Jenkins → Open on Drupal.org →
    Core: 10.1.x + Environment: PHP 8.1 & MariaDB 10.3.22
    last update over 1 year ago
    148 pass
  • heddn Nicaragua

    Not directly related, but if the feed item has a malformed or non existent URL, it also has issues. The example feed here has no 'link' value. The processor just handles it and then Item::buildUri fails on an empty url string.

    https://rss.art19.com/apology-line

    <item>
    <title>Listen Now – Over My Dead Body: Gone Hunting</title>
    <description>
    <p>When Mike Williams vanishes on a hunting trip, the authorities suspect he was eaten by alligators but the true predators who took Mike may lurk much closer to home. The mystery of Mike’s disappearance might have faded from memory, if it wasn’t for one woman’s tireless crusade. From Wondery, comes a new season of Over My Dead Body; a story about an obsessive love affair, a scandalous secret and a mother’s battle for the truth.</p><p><br></p><p>Listen to Over My Dead Body:&nbsp;<a href="http://Wondery.fm/_OMDB_" rel="noopener noreferrer" target="_blank"><u>Wondery.fm/_OMDB_</u></a></p><p>See Privacy Policy at <a href="https://art19.com/privacy" rel="noopener noreferrer" target="_blank">https://art19.com/privacy</a> and California Privacy Notice at <a href="https://art19.com/privacy#do-not-sell-my-info" rel="noopener noreferrer" target="_blank">https://art19.com/privacy#do-not-sell-my-info</a>.</p>
    </description>
    <itunes:title>Listen Now – Over My Dead Body: Gone Hunting</itunes:title>
    <itunes:episodeType>trailer</itunes:episodeType>
    <itunes:summary>
    When Mike Williams vanishes on a hunting trip, the authorities suspect he was eaten by alligators but the true predators who took Mike may lurk much closer to home. The mystery of Mike’s disappearance might have faded from memory, if it wasn’t for one woman’s tireless crusade. From Wondery, comes a new season of Over My Dead Body; a story about an obsessive love affair, a scandalous secret and a mother’s battle for the truth. Listen to Over My Dead Body: Wondery.fm/_OMDB_ See Privacy Policy at https://art19.com/privacy and California Privacy Notice at https://art19.com/privacy#do-not-sell-my-info.
    </itunes:summary>
    <content:encoded>
    <p>When Mike Williams vanishes on a hunting trip, the authorities suspect he was eaten by alligators but the true predators who took Mike may lurk much closer to home. The mystery of Mike’s disappearance might have faded from memory, if it wasn’t for one woman’s tireless crusade. From Wondery, comes a new season of Over My Dead Body; a story about an obsessive love affair, a scandalous secret and a mother’s battle for the truth.</p><p><br></p><p>Listen to Over My Dead Body:&nbsp;<a href="http://Wondery.fm/_OMDB_" rel="noopener noreferrer" target="_blank"><u>Wondery.fm/_OMDB_</u></a></p><p>See Privacy Policy at <a href="https://art19.com/privacy" rel="noopener noreferrer" target="_blank">https://art19.com/privacy</a> and California Privacy Notice at <a href="https://art19.com/privacy#do-not-sell-my-info" rel="noopener noreferrer" target="_blank">https://art19.com/privacy#do-not-sell-my-info</a>.</p>
    </content:encoded>
    <guid isPermaLink="false">
    gid://art19-episode-locator/V0/THAkE_PLYvLPe5esjbbRwigRYOcI8slrh1TzzUS0Yes
    </guid>
    <pubDate>Mon, 21 Aug 2023 08:00:00 -0000</pubDate>
    <itunes:explicit>yes</itunes:explicit>
    <itunes:image href="https://content.production.cdn.art19.com/images/be/e1/82/c2/bee182c2-14b7-491b-b877-272ab6754025/bd4ab6d08d7b723678a682b6e399d26523245b3ba83f61617b9b28396aba1092b101cd86707576ec021b77e143b447463342b352f8825265b15310c989b6cb93.jpeg"/>
    <itunes:keywords>
    Serial killer,TRUE CRIME,Society,This American Life,MURDER,Apology,Apology Line,Binge Worthy Documentary,New York City,Binge-worthy true crime,exhibit c
    </itunes:keywords>
    <itunes:duration>00:05:41</itunes:duration>
    <enclosure url="https://dts.podtrac.com/redirect.mp3/chrt.fm/track/9EE2G/pdst.fm/e/rss.art19.com/episodes/f2a5ba0e-de92-4ba8-85d3-afd3f042179c.mp3?rss_browser=BAhJIgxGaXJlZm94BjoGRVQ%3D--e1fe8381133ee436d645c9120f2b13f7c307fd4d" type="audio/mpeg" length="5456457"/>
    </item>
    
  • 🇦🇺Australia larowlan 🇦🇺🏝.au GMT+10

    Shouldn't #3 fail?

  • 🇺🇸United States dcam

    Shouldn't #3 fail?

    Nope, although it does need to be rerolled since I enhanced that test.

    +++ b/tests/src/Kernel/Plugin/aggregator/processor/DefaultProcessorTest.php
    @@ -77,6 +77,19 @@ class DefaultProcessorTest extends KernelTestBase {
    +        0,
    

    Here on line 92 the number of expected items is 0. So when the title-less item isn't imported this passes.

Production build 0.71.5 2024