Fix phpcs issues

phpcs --standard=DrupalPractice --extensions=php,module,inc,install,test,profile,theme,css,info,txt,md,yml /var/www/html/drupal_cms/drupal9/web/modules/contrib/nopremium FILE: /var/www/html/drupal_cms/drupal9/web/modules/contrib/nopremium/nopremium.info.yml ---------------------------------------------------------------------------------------------- FOUND 0 ERRORS AND 1 WARNING AFFECTING 1 LINE ---------------------------------------------------------------------------------------------- 7 | WARNING | All dependencies must be prefixed with the project name, for example "drupal:" ---------------------------------------------------------------------------------------------- FILE: /var/www/html/drupal_cms/drupal9/web/modules/contrib/nopremium/tests/src/Kernel/NodeViewTest.php ------------------------------------------------------------------------------------------------------ FOUND 0 ERRORS AND 1 WARNING AFFECTING 1 LINE ------------------------------------------------------------------------------------------------------ 36 | WARNING | Unused variable $content_admin_user. ------------------------------------------------------------------------------------------------------ Time: 230ms; Memory: 8MB

Comments & Activities

Not all content is available!

It's likely this issue predates Contrib.social: some issue and comment data are missing.

Comment almost 2 years ago →
🇮🇳India samit.310@gmail.com
In #3 📌 Fix phpcs issues Fixed following lines are removed from tests/src/Kernel/NodeViewTest.php file.
I guess we should keep that code.

// Create an administrative user. $content_admin_user = $this->createUser(['uid' => 2], ['administer nodes']);
Issue was unassigned.
Status changed to Needs review almost 2 years ago5:47am 31 January 2023
Comment almost 2 years ago →
🇮🇳India samit.310@gmail.com
Updated patch is attached.

interdiff with #3 📌 Fix phpcs issues Fixed
First commit to issue fork.
Assigned to himanshu_jhaloya
Comment almost 2 years ago →
🇮🇳India himanshu_jhaloya Indore
Issue was unassigned.
Status changed to RTBC almost 2 years ago7:21am 31 January 2023
Comment almost 2 years ago →
🇮🇳India himanshu_jhaloya Indore
Reviewed the patch applied cleanly. no error & warning was found. Moving to RTBC
Comment almost 2 years ago →
System Message

MegaChriz → committed 0cdc91d2 on 8.x-1.x authored by samit.310@gmail.com →
Issue #3322639 by PrasadDeole, samit.310@gmail.com: Fixed minor coding...
Comment almost 2 years ago →
🇳🇱Netherlands megachriz
Thanks for the patch. Committed #6.

@himanshu_jhaloya
Thanks for trying to apply the patch, but whether or not a patch applies is already covered by the testbot in this case. Therefore, I didn't credit you on the commit.
Status changed to Fixed almost 2 years ago8:13am 31 January 2023
Comment almost 2 years ago →
🇳🇱Netherlands megachriz
Comment almost 2 years ago →
System Message
Automatically closed - issue fixed for 2 weeks with no activity.

Problem/Motivation

Comments & Activities