- Status changed to Needs work
almost 2 years ago 2:59am 11 May 2023 - First commit to issue fork.
- last update
almost 2 years ago 1 pass - @bharath-kondeti opened merge request.
- Status changed to Needs review
almost 2 years ago 9:23am 11 May 2023 - Status changed to Needs work
almost 2 years ago 10:07pm 11 May 2023 - ๐บ๐ธUnited States luke.leber Pennsylvania
#7-9 have not addressed the review notes and will not be considered for contribution credit. Please contrubute to the existing merge request rather than opening new ones in order to be considered for crediting.
Thank you.
- Status changed to Needs review
almost 2 years ago 9:45am 12 May 2023 - ๐ฎ๐ณIndia bharath-kondeti Hyderabad
Addressed #10, closed the new MR raised and updated the existing MR with review comments addressed.
- ๐ฎ๐ณIndia Raveen Kumar
Hey Guys. I reviewed the README.md, it's included all the Drupal recommends sections and formatting.
- Status changed to Needs work
about 1 year ago 8:05am 29 January 2024 - ๐ฎ๐ณIndia Nupur Badola
unable to apply the patch.
error: patch failed: README.txt:1
error: README.txt: patch does not apply - ๐ฎ๐ณIndia ravi kant Jaipur
ravi kant โ made their first commit to this issueโs fork.
- Status changed to Needs review
about 1 year ago 12:34pm 29 January 2024 - Status changed to Needs work
about 1 year ago 11:35am 30 January 2024 - ๐ฎ๐ณIndia Nupur Badola
Reviewed MR!2, the patch is not cleanly applied.
2.diff.txt:44: trailing whitespace. - Supporting organizations: 2.diff.txt:53: trailing whitespace. The module provides an event so that others can develop an event subscriber 2.diff.txt:74: trailing whitespace. - [LimoenGroen](https://www.drupal.org/limoengroen) error: patch failed: README.txt:1 error: README.txt: patch does not apply
- ๐ฎ๐ณIndia mohd sahzad
Mohd Sahzad โ made their first commit to this issueโs fork.
- Status changed to Needs review
about 1 year ago 12:11pm 30 January 2024 - ๐ฎ๐ณIndia mohd sahzad
Hi @Nupur Badola,
I have updated README.md file, so please review last commit in MR !2 - Status changed to Needs work
about 1 year ago 8:56am 31 January 2024 - ๐ต๐ญPhilippines kenyoOwen
Hi ravi kant
I reviewed your changes and the "social" text should be capital letter in the Project name and introduction section. ## Supporting organizations should be below the ##Maintainers section.
Thank you.
- ๐ฎ๐ณIndia anjali mehta
Anjali Mehta โ made their first commit to this issueโs fork.
- Status changed to Needs review
about 1 year ago 11:18am 31 January 2024 - Status changed to Needs work
about 1 year ago 12:07pm 1 February 2024 - ๐ฎ๐ณIndia Nupur Badola
Reviewed MR!2, the file has still some issues.
2.diff.txt:57: trailing whitespace. - ***social_media.add_more_social_media*** error: patch failed: README.txt:1 error: README.txt: patch does not apply
- ๐ฎ๐ณIndia ravi kant Jaipur
I cannot create the sub-branch for 2.0.x branch.
- Merge request !17Issue #3358738 by Luke.Leber, attila.fekete, morvaim, nielsaers, yce, Oscaner:... โ (Open) created by ravi kant
- ๐ฎ๐ณIndia ravi kant Jaipur
ravi kant โ changed the visibility of the branch 3322365-switch-to-readme.md to hidden.
- Status changed to Needs review
about 1 year ago 8:55am 27 February 2024 - ๐ฎ๐ณIndia ravi kant Jaipur
I have created MR !17 due to MR !2 was having many different files. Which may be by mistake committed.
- Status changed to Needs work
about 1 year ago 1:05pm 28 February 2024 - ๐ฎ๐ณIndia Nupur Badola
Reviewed MR!17, the patch has still some issues:
error: patch failed: README.txt:7 error: README.txt: patch does not apply error: patch failed: composer.json:14 error: composer.json: patch does not apply error: patch failed: config/install/social_media.settings.yml:2 error: config/install/social_media.settings.yml: patch does not apply error: config/schema/social_media.schema.yml: already exists in working directory error: patch failed: social_media.api.php:1 error: social_media.api.php: patch does not apply error: patch failed: social_media.info.yml:1 error: social_media.info.yml: patch does not apply error: patch failed: social_media.install:1 error: social_media.install: patch does not apply error: patch failed: social_media.libraries.yml:9 error: social_media.libraries.yml: patch does not apply error: social_media.post_update.php: already exists in working directory error: patch failed: src/Controller/AccessController.php:6 error: src/Controller/AccessController.php: patch does not apply error: patch failed: src/Event/SocialMediaEvent.php:2 error: src/Event/SocialMediaEvent.php: patch does not apply error: patch failed: src/Form/ForwardEmailForm.php:2 error: src/Form/ForwardEmailForm.php: patch does not apply error: patch failed: src/Form/SocialMediaAdminForm.php:4 error: src/Form/SocialMediaAdminForm.php: patch does not apply error: patch failed: src/Plugin/Block/SocialSharingBlock.php:3 error: src/Plugin/Block/SocialSharingBlock.php: patch does not apply error: patch failed: src/Plugin/Field/FieldFormatter/SocialMediaFormatter.php:2 error: src/Plugin/Field/FieldFormatter/SocialMediaFormatter.php: patch does not apply error: patch failed: src/Plugin/Field/FieldWidget/SocialMediaWidget.php:35 error: src/Plugin/Field/FieldWidget/SocialMediaWidget.php: patch does not apply error: tests/src/Functional/SocialMediaAdminFormTest.php: already exists in working directory
- ๐ฎ๐ณIndia ravi kant Jaipur
The MR have lots other files which should not be in this MR.
I will create new MR. - ๐ฎ๐ณIndia ravi kant Jaipur
ravi kant โ changed the visibility of the branch 3322365-update-readme-file to hidden.
- Status changed to Needs review
about 1 year ago 2:13pm 29 February 2024 - ๐ฎ๐ณIndia ravi kant Jaipur
@Nupur Badola
I have created new MR !18.
This MR have only one file so conflict will not create. - Status changed to Needs work
about 1 year ago 11:51am 1 March 2024 - ๐ฎ๐ณIndia Nupur Badola
Reviewed MR!18, the patch has some issues mentioned below:
1. In #Table of contents, first is given as "Event subscribe", However in the detailed section , it is mentioned as "Event subscriber".
- Status changed to Needs review
about 1 year ago 12:14pm 1 March 2024 - Status changed to RTBC
about 1 year ago 6:41am 4 March 2024 - ๐ฎ๐ณIndia Nupur Badola
Reviewed MR!18, the file is updated as per the readme.md file template.
Hence marking it to RTBC.