Switch to README.md

bharath-kondeti → made their first commit to this issue’s fork.

#7-9 have not addressed the review notes and will not be considered for contribution credit. Please contrubute to the existing merge request rather than opening new ones in order to be considered for crediting.

Thank you.

bharath-kondeti → closed merge request !13

Addressed #10, closed the new MR raised and updated the existing MR with review comments addressed.

Hey Guys. I reviewed the README.md, it's included all the Drupal recommends sections and formatting.

unable to apply the patch.
error: patch failed: README.txt:1
error: README.txt: patch does not apply

ravi kant → made their first commit to this issue’s fork.

I have updated the MR !2.

Reviewed MR!2, the patch is not cleanly applied.

2.diff.txt:44: trailing whitespace.
- Supporting organizations:
2.diff.txt:53: trailing whitespace.
The module provides an event so that others can develop an event subscriber
2.diff.txt:74: trailing whitespace.
- [LimoenGroen](https://www.drupal.org/limoengroen)
error: patch failed: README.txt:1
error: README.txt: patch does not apply

Mohd Sahzad → made their first commit to this issue’s fork.

Hi @Nupur Badola,
I have updated README.md file, so please review last commit in MR !2

Hi ravi kant

I reviewed your changes and the "social" text should be capital letter in the Project name and introduction section. ## Supporting organizations should be below the ##Maintainers section.

Thank you.

Anjali Mehta → made their first commit to this issue’s fork.

Reviewed MR!2, the file has still some issues.

2.diff.txt:57: trailing whitespace.
- ***social_media.add_more_social_media***
error: patch failed: README.txt:1
error: README.txt: patch does not apply

I cannot create the sub-branch for 2.0.x branch.

ravi kant → changed the visibility of the branch 3322365-switch-to-readme.md to hidden.

I have created MR !17 due to MR !2 was having many different files. Which may be by mistake committed.

Reviewed MR!17, the patch has still some issues:

error: patch failed: README.txt:7
error: README.txt: patch does not apply
error: patch failed: composer.json:14
error: composer.json: patch does not apply
error: patch failed: config/install/social_media.settings.yml:2
error: config/install/social_media.settings.yml: patch does not apply
error: config/schema/social_media.schema.yml: already exists in working directory
error: patch failed: social_media.api.php:1
error: social_media.api.php: patch does not apply
error: patch failed: social_media.info.yml:1
error: social_media.info.yml: patch does not apply
error: patch failed: social_media.install:1
error: social_media.install: patch does not apply
error: patch failed: social_media.libraries.yml:9
error: social_media.libraries.yml: patch does not apply
error: social_media.post_update.php: already exists in working directory
error: patch failed: src/Controller/AccessController.php:6
error: src/Controller/AccessController.php: patch does not apply
error: patch failed: src/Event/SocialMediaEvent.php:2
error: src/Event/SocialMediaEvent.php: patch does not apply
error: patch failed: src/Form/ForwardEmailForm.php:2
error: src/Form/ForwardEmailForm.php: patch does not apply
error: patch failed: src/Form/SocialMediaAdminForm.php:4
error: src/Form/SocialMediaAdminForm.php: patch does not apply
error: patch failed: src/Plugin/Block/SocialSharingBlock.php:3
error: src/Plugin/Block/SocialSharingBlock.php: patch does not apply
error: patch failed: src/Plugin/Field/FieldFormatter/SocialMediaFormatter.php:2
error: src/Plugin/Field/FieldFormatter/SocialMediaFormatter.php: patch does not apply
error: patch failed: src/Plugin/Field/FieldWidget/SocialMediaWidget.php:35
error: src/Plugin/Field/FieldWidget/SocialMediaWidget.php: patch does not apply
error: tests/src/Functional/SocialMediaAdminFormTest.php: already exists in working directory

The MR have lots other files which should not be in this MR.
I will create new MR.

ravi kant → changed the visibility of the branch 3322365-update-readme-file to hidden.

@Nupur Badola

I have created new MR !18.
This MR have only one file so conflict will not create.

Reviewed MR!18, the patch has some issues mentioned below:

1. In #Table of contents, first is given as "Event subscribe", However in the detailed section , it is mentioned as  "Event subscriber".

Reviewed MR!18, the file is updated as per the readme.md file template.
Hence marking it to RTBC.