Deprecated function: urldecode(): Passing null to parameter #1 ($string) of type string is deprecated in backup_migrate_location->set_url()

I tried to reproduce this on a PHP 8.2 instance and I don't see this issue, couldn't replicate it.

I have not been able to reproduce this with either PHP 8.1 or PHP 8.2 following the instruction of the reporter.

The patch suggests that the problem is in the method set_url(), where so far error suppression (using the ampersand prefix in PHP) has been used instead of error handling.

I did manage however to reproduce the error by creating a fresh FTP destination. I haven't checked, but presumably the 'pass' field, when left empty, causes a problem here.

Applying the patch makes the error messages go away, while the database entry for this destination remains the same.

As an aside, in this particular instance (i.e. the FTP destination example) I get an additional error message: Warning: Undefined array key "old_password" in backup_migrate_destination_remote->edit_form_submit() (line 1341 of /drupal7/sites/all/modules/backup_migrate/includes/destinations.inc).

This was fixed in one of the other issues.

Wait, no, it's not fixed yet.

The last submitted patch, 5: backup_migrate-n3322166-5.patch, failed testing. View results →
- codesniffer_fixes.patch Interdiff of automated coding standards fixes only.

The last submitted patch, 5: backup_migrate-n3322166-5.patch, failed testing. View results →
- codesniffer_fixes.patch Interdiff of automated coding standards fixes only.

I'm committing what's there, the test errors are unrelated. Thank you.

Automatically closed - issue fixed for 2 weeks with no activity.