- ๐ฎ๐ณIndia jay jangid Jaipur
Thanks @Pracheth for creating MR , but here still some issues.
I am working on it.
- Issue was unassigned.
- Status changed to Needs review
almost 2 years ago 9:03am 24 January 2023 - ๐ฎ๐ณIndia jay jangid Jaipur
Updated MR , please review.
Thank you.
- ๐ฎ๐ณIndia Nupur Badola
Issue exists in the patch.
error: patch failed: batch_resize_image.info.yml:1 error: batch_resize_image.info.yml: patch does not apply
- Status changed to Needs work
over 1 year ago 2:47pm 21 June 2023 - ๐ต๐ญPhilippines clarkssquared
Hi Jay Jangid
I applied your MR !1 to my local and below are my feedbacks.
First, I executed curl https://git.drupalcode.org/project/batch_resize_image/-/merge_requests/1... | git apply -v and below is the output in my terminal
Checking patch README.md...
Checking patch README.txt...
Checking patch batch_resize_image.info.yml...
error: while searching for:
name: 'Batch Resize Image'
type: module
description: 'An easy way to resize images in files folder.'
core: 8.x
core_version_requirement: ^8 || ^9
package: 'Images'
configure: batch_resize_image.batch_resize_image_formerror: patch failed: batch_resize_image.info.yml:1
error: batch_resize_image.info.yml: patch does not applyHence, the patch did not apply and I replicated the same error @Nupur Badola mentioned.
Second, I executed curl https://git.drupalcode.org/project/batch_resize_image/-/merge_requests/1... | patch this method successfully replaced the README.txt file with README.md, but it shows in my terminal that there is a conflict in batch_resize_image.info.yml file.
I will move this to needs work, hoping that the MR/patch will apply cleanly
Kindly check the screenshot I attached for your reference
- ๐ฎ๐ณIndia ravi kant Jaipur
ravi kant โ made their first commit to this issueโs fork.
- Status changed to Needs review
9 months ago 9:13am 13 March 2024 - First commit to issue fork.
- Status changed to RTBC
9 months ago 5:38am 14 March 2024 - ๐ฎ๐ณIndia Nupur Badola
Reviewed MR!1, the file is updated as per the readme.md file template.
Hence marking it to RTBC.