- Assigned to phenaproxima
- Status changed to Active
almost 2 years ago 1:04pm 15 February 2023 - π§πͺBelgium wim leers Ghent π§πͺπͺπΊ
Per his activity in Slack, I'm pretty sure @phenaproxima is eager to take this on π€
- π§πͺBelgium wim leers Ghent π§πͺπͺπΊ
The requirements changes are already happening in π Update requirements for 3.x Fixed . Retitling to clarify scope of this issue.
We can work on these 2 in parallel, so not postponing this.
- @phenaproxima opened merge request.
- Status changed to Needs work
almost 2 years ago 3:41pm 15 February 2023 - Issue was unassigned.
- Status changed to Needs review
almost 2 years ago 5:12pm 15 February 2023 - πΊπΈUnited States phenaproxima Massachusetts
161 additions, 2612 deletions! π
I made the following changes:
- With the lone exception of ComposerUtility (which we're transitioning away from), everything that was deprecated has been removed.
- I used constructor property promotion everywhere I could. This meant removing a lot of duplicated doc comments and boilerplate. Beautiful.
- Caught exceptions that didn't use the actual exception object were converted to non-capturing catches.
- Injected properties that conflict with properties defined in traits (MessengerTrait, StringTranslationTrait) were removed in favor of using the trait methods.
- Assigned to phenaproxima
- Status changed to Needs work
almost 2 years ago 5:22pm 15 February 2023 - π§πͺBelgium wim leers Ghent π§πͺπͺπΊ
EPIC stats!
This will break most in-progress MRs though π Including the exception architecture one. OTOH, landing this now will also ensure that in-progress MRs can shed a lot of their cruft and have plenty of examplesβ¦
@phenaproxima I think you missed @heddn's remark that I +1'd: https://git.drupalcode.org/project/automatic_updates/-/merge_requests/70.... Spotted 2 other patterns too. Pretty sure you'll love doing these! π
- Issue was unassigned.
- Status changed to Needs review
almost 2 years ago 5:33pm 15 February 2023 - πΊπΈUnited States phenaproxima Massachusetts
All feedback is addressed.
- Assigned to tedbow
- πΊπΈUnited States phenaproxima Massachusetts
I went over this with @tedbow in Zoom and he felt it was pretty good. Assigning to him for final review and (hopefully) commit.
- Status changed to RTBC
almost 2 years ago 7:14pm 15 February 2023 - πΊπΈUnited States tedbow Ithaca, NY, USA
re #21 I looked at the commits since the zoom and everything looks good!
Great to get this in
-
phenaproxima β
committed 68d32b2e on 3.0.x
Issue #3321474 by phenaproxima, tedbow: Adopt PHP 8.1-only capabilities...
-
phenaproxima β
committed 68d32b2e on 3.0.x
- Status changed to Fixed
almost 2 years ago 7:17pm 15 February 2023 - Assigned to phenaproxima
- π§πͺBelgium wim leers Ghent π§πͺπͺπΊ
@phenaproxima you wrote
Having said that, I do think it makes sense to make it protected readonly in StageEvent. In another issue, we should convert it to public readonly and remove getStage() π
Can you please create that follow-up issue?
- πΊπΈUnited States phenaproxima Massachusetts
- Issue was unassigned.
Automatically closed - issue fixed for 2 weeks with no activity.