- Issue created by @tedbow
- @tedbow opened merge request.
- Status changed to Postponed
almost 2 years ago 10:54am 15 February 2023 - π§πͺBelgium wim leers Ghent π§πͺπͺπΊ
The test failures here look like this:
Testing Drupal\Tests\automatic_updates\Build\CoreUpdateTest FFFFF 5 / 5 (100%) Time: 01:57.671, Memory: 14.00 MB There were 5 failures: 1) Drupal\Tests\automatic_updates\Build\CoreUpdateTest::testApi COMMAND: COMPOSER_MIRROR_PATH_REPOS=1 composer require --update-with-all-dependencies "drupal/automatic_updates:@dev" OUTPUT: ERROR: ./composer.json has been updated Running composer update drupal/automatic_updates --with-all-dependencies Loading composer repositories with package information Updating dependencies Your requirements could not be resolved to an installable set of packages. Problem 1 - Root composer.json requires drupal/automatic_updates @dev -> satisfiable by drupal/automatic_updates[dev-merge-request-699]. - drupal/automatic_updates dev-merge-request-699 requires drupal/core ^10 -> found drupal/core[9.8.0] but it does not match the constraint.
β¦ which is what I encountered a few weeks ago and opened π Assert no errors after creating the test project in ModuleUpdateTest Needs review for.
- Status changed to Needs work
almost 2 years ago 2:52pm 15 February 2023 - π§πͺBelgium wim leers Ghent π§πͺπͺπΊ
Looks like my theory in #5 worked β that means I disproved my theory in #4 π€ β this does not need to be postponed on π Assert no errors after creating the test project in ModuleUpdateTest Needs review anymore!
- Assigned to phenaproxima
- Status changed to Needs review
almost 2 years ago 3:58pm 15 February 2023 - π§πͺBelgium wim leers Ghent π§πͺπͺπΊ
Hopefully that'll be green now! π€
Left to do: address the
@todo
in\Drupal\Tests\automatic_updates\Functional\AvailableUpdatesReportTest::assertVersionLink()
. Assigning to @phenaproxima since he added that β it's not entirely clear to me what should happen there β I think the entire assertion method should be dropped and all calls to it, but that'd be equivalent to losing test coverageβ¦ - First commit to issue fork.
- Assigned to tedbow
- πΊπΈUnited States phenaproxima Massachusetts
Assigning to @tedbow for review.
I decided to keep assertVersionLink(), but changed it assertVersionIsListed() to more accurately reflect what it does. The Download link is no longer visible, which is a core change that core should be testing.
- Status changed to RTBC
almost 2 years ago 5:51pm 15 February 2023 - πΊπΈUnited States tedbow Ithaca, NY, USA
Looks good to me if tests pass
-
phenaproxima β
committed 6d81b03b on 8.x-2.x authored by
tedbow β
Issue #3341708 by Wim Leers, tedbow, phenaproxima: Update requirements...
-
phenaproxima β
committed 6d81b03b on 8.x-2.x authored by
tedbow β
- Status changed to Fixed
almost 2 years ago 6:15pm 15 February 2023 -
phenaproxima β
committed 4e350a4c on 3.0.x authored by
tedbow β
Issue #3341708 by Wim Leers, tedbow, phenaproxima: Update requirements...
-
phenaproxima β
committed 4e350a4c on 3.0.x authored by
tedbow β
-
phenaproxima β
committed 1d071464 on 8.x-2.x
Revert "Issue #3341708 by Wim Leers, tedbow, phenaproxima: Update...
-
phenaproxima β
committed 1d071464 on 8.x-2.x
- Issue was unassigned.
Automatically closed - issue fixed for 2 weeks with no activity.