- 🇮🇳India Nupur Badola
Reviewed MR!1, the patch is not cleanly applied.
git.drupalcode.org_project_views_serialization_pager_-_merge_requests_1.diff.txt:31: trailing whitespace. To use: git.drupalcode.org_project_views_serialization_pager_-_merge_requests_1.diff.txt:35: trailing whitespace. Views \> Add view and create a new view of REST EXPORT. git.drupalcode.org_project_views_serialization_pager_-_merge_requests_1.diff.txt:37: trailing whitespace. field set, select the ‘Serialization with Pager’ style. git.drupalcode.org_project_views_serialization_pager_-_merge_requests_1.diff.txt:41: trailing whitespace. field set, select the ‘Full’, item to display error: README.md: already exists in working directory error: README.txt: No such file or directory
and does not follow the readme.md file template format, refer https://www.drupal.org/docs/develop/managing-a-drupalorg-theme-module-or... →
- Assigned to AditiVB
- Issue was unassigned.
- 🇮🇳India AditiVB
i have changed my readme.txt file to readme.md file in branch views_serialization_pager_readmemd
- Status changed to Needs review
8 months ago 5:30am 26 October 2023 - 🇮🇳India AditiVB
not able to create MR request creating a patch here .
- Status changed to Needs work
8 months ago 6:48am 26 October 2023 - 🇵ðŸ‡Philippines clarkssquared
Hi Aditi Saraf,
I applied your patch #7 and I found out that your patch does nothing but to remove the README.txt only, as per the issue description, README.txt must be replaced with README.md. For your reference please refer to Drupal README.md template →
- First commit to issue fork.
- Status changed to Needs review
7 months ago 7:34am 24 November 2023 - thakurnishant_06 India
Rebased the MR2 and updated the readme.md file according to the readme.md template.
Kindly review the changes.
Thank you. - Status changed to RTBC
7 months ago 7:00am 1 December 2023 - 🇮🇳India Nupur Badola
Reviewed MR!2, the patch is cleanly applied. Hence marking it to RTBC.