Add tests to ensure case-unsensitivity works

I feel like these tests are highly overengineered. I copied the RiddleForm description over to 📌 Create further tests for the upper / lower case validation in conjunction with riddler Closed: duplicate . Otherwise I'd suggest closing this issue in favour of 📌 Create further tests for the upper / lower case validation in conjunction with riddler Closed: duplicate .

There went actually quite a bit of work in there... I will try to fix the tests.

OK, there are a few tests left, which currently fail. That is no problem though, as they fail because the answers were not available in the "example" riddle, back when this issue was created. I will throw these issues out and add the newly created tests from 📌 Create further tests for the upper / lower case validation in conjunction with riddler Closed: duplicate .

From 📌 Create further tests for the upper / lower case validation in conjunction with riddler Closed: duplicate by @Anybody:

Thanks @Grevil, looking fine so far!

Finally another logout might make sense, testing a different word so we can be sure only the expected cases work in this test.

PS: I wouldn't use such a complicated riddle, which is hard to remember even for the developer (which is the right one). Better use something short like "UPPERcase" and match against that, it will reduce the risk to make mistakes in the tests. If you're willing to accept the well intentioned advice.

The remaining failing tests show pretty well, that this module seems to have a caching problem. If we clear all caches after manually setting the solution, the remaining tests succeed.

Thanks @Grevil! That's a good point. Still we need to find out, if the issue is within the module itself or Captcha or by design.

Also, we need to differentiate (better also in at least one test) between ONE or more riddles. You remember... If there's more than one, it's expected not to be cached.

I think we should have a separate issue on that topic?

Yes, but in the failing tests, we are always only testing one answer, BUT we should create tests with multiple answers...

I also can not manually reproduce the failing tests... Maybe we actually need to flush the caches, as we are not setting the solution through the form, but rather through the riddleStorage?

    $exampleRiddle = $this->riddleStorage->load('example');
    $exampleRiddle->setSolution('YES')->save();

    $this->loginWithRiddleAnswer('Yes');

Either way, we should also test multiple answer tests...

We found the problem! When a captcha is cachable, we overwrite the solution with "FALSE", as otherwise different users with the same cache can just straight away access the form with the correct captcha answer cached! (The captcha sid of the form isn't changed, so the previous correct answer is always correct). In this case, we have to get the solutin from the database instead.

All Tests pass! Let's remove the module changes and apply them in 🐛 Correct answer is blocked Fixed !

The tests should fail now again! Please review :)

Well done, thanks for the additional tests! :)

Automatically closed - issue fixed for 2 weeks with no activity.