Drupal 10 compatibility

Created on 17 October 2022, over 1 year ago
Updated 26 April 2024, 2 months ago

Problem/Motivation

Release https://www.drupal.org/project/better_exposed_filters/releases/6.0.x-dev โ†’ is supposed to work with Drupal 10 according to release notes. However, it has a dependency on jquery_ui that doesn't have a Drupal 10 release.

Steps to reproduce

composer require drupal/better_exposed_filters on a Drupal 10 project.

We should either remove Drupal 10 support here of add Drupal 10 support in jquery_ui.

๐Ÿ› Bug report
Status

Fixed

Version

6.0

Component

Code

Created by

๐Ÿ‡ต๐Ÿ‡ฑPoland Graber

Live updates comments and jobs are added and updated live.
Sign in to follow issues

Comments & Activities

Not all content is available!

It's likely this issue predates Contrib.social: some issue and comment data are missing.

  • ๐Ÿ‡ท๐Ÿ‡ดRomania Andras_Szilagyi

    Nobody noticed the failing test in D10?

  • ๐Ÿ‡จ๐Ÿ‡ฆCanada nicole.harnish Halifax

    This wont work as "Because patching occurs after Composer calculates dependencies and installs packages, changes to an underlying dependencyโ€™s composer.json file introduced in a patch will have no effect on installed packages."

    https://drupal.stackexchange.com/a/277858

  • ๐Ÿ‡จ๐Ÿ‡ฆCanada alienzed

    A bit confused, as I seem to be blocked from upgrading. How is this marked as compatible with D10 if I cannot effectively install it's dependencies using composer?

  • ๐Ÿ‡บ๐Ÿ‡ธUnited States inversed

    For anyone having trouble getting to 6.0.3, this is the command I used. Essentially, I needed to update the out of date supporting jquery_ui dependencies at the same time as BEF.

    composer require drupal/better_exposed_filters:^6.0.3 drupal/jquery_ui_datepicker:^2.0 drupal/jquery_ui_slider:^2.0 -W

    Otherwise, I kept ending up on BEF 6.0.2 which does not include the fix from this issue. I had those packages required specifically so they were locked and composer was not able to update BEF, even when specifying the with-all-dependencies argument.

  • ๐Ÿ‡จ๐Ÿ‡ฆCanada awasson

    Thanks @inversed #21 ๐Ÿ› Drupal 10 compatibility Fixed ,

    Perhaps a maintainer can post that suggestion to the module page under preparing for Drupal 10 to save time and frustration for those running into this issue.

    I too have run into it multiple times in the last weeks while preparing sites for upgrading D9 -> D10

    I've been editing composer.json manually for:

    "drupal/better_exposed_filters": "^6.0.3",
    "drupal/jquery_ui_datepicker": "^2.0",

    Then composer update.

    I think your method is a cleaner way to do it.

    Cheers,
    Andrew

  • ๐Ÿ‡ฌ๐Ÿ‡งUnited Kingdom joehuggans Harrogate, UK

    #21 - legendary, thank you!

  • ๐Ÿ‡ต๐Ÿ‡ฐPakistan adilsarwar1

    I was trying to update to Drupal 10. but the issue was of BEF and jQuery UI Slider compatibility. I manually updated the following lines in composer file and then run the composer update command.
    - "drupal/better_exposed_filters": "^6.0.3"
    - "drupal/jquery_ui_datepicker": "^2.0"
    - "drupal/jquery_ui_slider": "^2.0"

    after running composer update command both the modules updated successfully.

  • ๐Ÿ‡ฎ๐Ÿ‡นItaly Kris77

    #21 works for me too.

    Thanks @inversed

Production build 0.69.0 2024