Use CAPTCHA permission instead of own permission

2 Tests are failing. @Grevil could you take a look?

For some reason, "administer CAPTCHA settings" isn't inside the admin permission array. I'll fix it.

Fixed, please review! Otherwise, LGTM!

Ok, I actually adjusted it once against, to be 100% sure, the right permission is used for the settings form.

Thanks @Grevil! RTBC! Code LGTM, I don't think we should make changes in an update hook here, we *could* just inform users about the changed permission in an update hook notification (comment), without technical effect.

Should we do that? Leaving the question or commit to @webflo! :)

Please review again! We forgot to revoke the old permission. I created an appropriate update hook. webflo seems to be busy, so after review and manual testing of the hook we should merge this.

Well done @Grevil!

Could you add a simple permission testcase for the settings page so we can be 100% safe it works after this change?
Hopefully that's easy?

RTBC once it goes green!

sure

Done, let's wait for them to be green. Then we can merge.

All green!

Automatically closed - issue fixed for 2 weeks with no activity.