Drupal 10 Compatibility Issue

I tested on drupal 10 and it works fine. MR looks also good.

+1 RTBC. The patch applied cleanly and fixed all D10 compatibility issues.

Thanks y'all. Merged into a new branch (3.0.x). Will have a release out later today

The new branch name is wrong. It needs to be 3.x-dev. With 3.0.x-dev you would be able to only have patch version releases.

Per https://www.drupal.org/node/3108648 → either form is acceptable. One of the biggest audience Drupal modules - Webform → also uses #.#.x branches (aside, I think 6.1.x to 6.2.x should've gone to 7.0.x instead because removing supported core versions is a BC change that should be a Major version not a minor version but not really relevant).

Do you have some documentation/other projects that make you think there is a significant standardization around #.x branches for contrib modules? Drupal core goes for #.#.x branches - definitely, core has a lot more patch releases with no new features than most modules. Eh I can see your point after writing all that out. hah. Thanks for the thought. Given the velocity of this project I'm not really concerned - but will think about it for other modules for sure.

Automatically closed - issue fixed for 2 weeks with no activity.

nickdickinsonwilde → closed merge request !1