Include/exclude roles from purge is not optional

Created on 28 September 2022, about 2 years ago
Updated 12 May 2023, over 1 year ago

Problem/Motivation

Include/exclude roles to purge is not optional

Steps to reproduce

Go into Auto Purge Users settings, and try to save without selecting roles to include and exclude in purge

Proposed resolution

Make include/exclude roles fields optional

Remaining tasks

Fix

🐛 Bug report
Status

Postponed

Version

4.0

Component

Code

Created by

Live updates comments and jobs are added and updated live.
Sign in to follow issues

Comments & Activities

Not all content is available!

It's likely this issue predates Contrib.social: some issue and comment data are missing.

  • 🇩🇪Germany Anybody Porta Westfalica

    @dawid_cyron that's fixed in 🐛 Query condition 'ur.roles_target_id IN ()' cannot be empty Fixed

    @immaculatexavier could you please provide your patch as MR to mark it RTBC?

  • Status changed to Needs work over 1 year ago
  • 🇩🇪Germany Anybody Porta Westfalica

    @immaculatexavier any plans?

  • First commit to issue fork.
  • Status changed to Postponed over 1 year ago
  • 🇩🇪Germany Grevil

    Let's postpone this for now.

    For me at least, the expected result of not including nor excluding a user role would suggest deleting all users, which are targeted by the purge.

    1. We should make sure, that in this case, users with the admin role are excluded
    2. Check what the outcome of "$exist_query->condition('ur.roles_target_id',[], 'IN');" will be, as the fallback value of the user roles is currently an empty array. And I am in doubt that conditioning an empty array, will lead to selecting all user roles.
Production build 0.71.5 2024