- 🇷🇺Russia sorlov
You forgot to fix usage of $redirect_config->get('suppress_admin') in _redirect_after_registration_user_register_submit()
- Status changed to Needs work
about 1 month ago 7:31am 16 October 2024 - 🇩🇪Germany Anybody Porta Westfalica
Could someone please turn this into a MR?
- First commit to issue fork.
- 🇮🇳India pankaj_bit
pankaj_bit → changed the visibility of the branch 1.x to hidden.
- 🇩🇪Germany Anybody Porta Westfalica
Well, some of the changes look strange to me. Either it never worked correctly or it's broken now?
I think this needs an overhaul with cleaned up settings and tests to ensure it works as expected. Should not be too hard.
For the new settings structure, please look into similar widely used modules or core and use an update hook to migrate the old values. - Merge request !10Issue #3307311: Fix schema, module and config cleanup → (Merged) created by Anybody
- 🇩🇪Germany Anybody Porta Westfalica
Ok, did a lot of refactoring, added tests, standardized the config structure and values... this is ready to be reviewed and merged!
- 🇩🇪Germany Grevil
Added a few comments. After the composer fixes, the tests should go green as well.
Please also change the MR title to the Drupal generated git message. Thanks! 👍
- 🇩🇪Germany Anybody Porta Westfalica
Tests fail as gitlab-ci tries to use Drupal 11... no idea why, but 📌 Automated Drupal 11 compatibility fixes for redirect_after_registration Needs review will solve that...
- 🇩🇪Germany Grevil
Thanks! RTBC!
Tests fail as gitlab-ci tries to use Drupal 11
Interesting! They probably changed it fairly recently!
Changes LGTM! Tests are green locally, so they should get fixed in the follow-up D11 issue: 📌 Automated Drupal 11 compatibility fixes for redirect_after_registration Needs review .
Automatically closed - issue fixed for 2 weeks with no activity.