Properly Create/Update field indexes when importing updated field config

This issue is being reviewed by the kind folks in Slack, #needs-review-queue-initiative. We are working to keep the size of Needs Review queue [2700+ issues] to around 400 (1 month or less), following Review a patch or merge request → as a guide.

As a bug it will need a test case also.

Patch #6 allowed me to import field storage config where I had added an index. Thanks.

Based on the patch this is not a database system issue, strictly speaking.

I also tested the patch and it fixed the described issue.

9.5.x is EOL, bumping to 11.x. This could really do with test coverage to ensure we don't break it again in the future.

On latest D10:

I added the following to the field.storage.node.field… file:

indexes:
  field_last_status_change__value:
    - value

Then see before and after:

$ ddev drush sql:query "show indexes from node__field_last_status_change;"
node__field_last_status_change  0       PRIMARY 1       entity_id       A       4875    NULL    NULL            BTREE           
node__field_last_status_change  0       PRIMARY 2       deleted A       4875    NULL    NULL            BTREE           
node__field_last_status_change  0       PRIMARY 3       delta   A       4875    NULL    NULL            BTREE           
node__field_last_status_change  0       PRIMARY 4       langcode        A       4875    NULL    NULL            BTREE           
node__field_last_status_change  1       bundle  1       bundle  A       2       NULL    NULL            BTREE           
node__field_last_status_change  1       revision_id     1       revision_id     A       4875    NULL    NULL            BTREE           

$ ddev drush cim
+------------+---------------------------------------------+-----------+
| Collection | Config                                      | Operation |
+------------+---------------------------------------------+-----------+
|            | field.storage.node.field_last_status_change | Update    |
+------------+---------------------------------------------+-----------+

 Import the listed configuration changes? (yes/no) [yes]:
 > 

 [notice] Synchronized configuration: update field.storage.node.field_last_status_change.
 [notice] Finalizing configuration synchronization.
 [success] The configuration was imported successfully.

$ ddev drush sql:query "show indexes from node__field_last_status_change;"
node__field_last_status_change  0       PRIMARY 1       entity_id       A       4875    NULL    NULL            BTREE           
node__field_last_status_change  0       PRIMARY 2       deleted A       4875    NULL    NULL            BTREE           
node__field_last_status_change  0       PRIMARY 3       delta   A       4875    NULL    NULL            BTREE           
node__field_last_status_change  0       PRIMARY 4       langcode        A       4875    NULL    NULL            BTREE           
node__field_last_status_change  1       bundle  1       bundle  A       2       NULL    NULL            BTREE           
node__field_last_status_change  1       revision_id     1       revision_id     A       4875    NULL    NULL            BTREE           
node__field_last_status_change  1       field_last_status_change_field_last_status_change__value        1       field_last_status_change_value  A       4875    NULL      NULL            BTREE           

I didn't get any exceptions or warnings or errors in the status report.