Convert TokenReplaceTest to a kernel test

Revolved the comment, back to RTBC.

I am doing RTBC triage.

The issue summary is clear on what this is doing. I see that all the questions have been answered except for the one about sanitization.

@joachim, thanks for pointing out that $term2 is not reloaded! For me, that is a sign that this test has not worked as expected for some time.

I looked at the commit that added the <blink>Blinking Text</blink>. The comments there suggest that the intent is to test sanitization. Whether that worked originally I don't know, but it is not now and that needs a solution. It certainly doesn't work as expected when $term2 is not reloaded.

I do agree with #11 that some research is needed before this can be committed is some form. I did a very brief search for a token test that checked sanitization but didn't spot one. That does not mean it is not there.

I've updated the IS and I am returning this to needs work.

> I looked at the commit that added the Blinking Text. The comments there suggest that the intent is to test sanitization. Whether that worked originally I don't know, but it is not now and that needs a solution. It certainly doesn't work as expected when $term2 is not reloaded.

I was about to say that the issue that commit belongs to, #701818: Several tokens are broken, especially file tokens; test coverage of every core token → was on D7 and that in the glorious world of D10, tokens are derived centrally from the field system that that magically takes care of sanitising... but then I looked at the token code and WTF. Nope.

So yeah, we do need to add coverage for sanitizing, but as there is no coverage in the test affected by this MR, I'd rather do it in a follow-up issue -- a bug -- than here, which is just a task that's converting the test while keeping current coverage the same.

The Needs Review Queue Bot → tested this issue. It no longer applies to Drupal core. Therefore, this issue status is now "Needs work".

This does not mean that the patch needs to be re-rolled or the MR rebased. Read the Issue Summary, the issue tags and the latest discussion here to determine what needs to be done.

Consult the Drupal Contributor Guide → to find step-by-step guides for working with issues.

Rebased.

This looks OK to commit but I'd like the followup suggested in #15 to exist first so we don't forget that we need additional test coverage.

Done: 🐛 TokenReplaceTest is missing coverage of sanitization of tokens Postponed .

The MR itself looks good and follow-up has been filed. Triggering a re-test just to make sure that there aren't conflicts with any of the recent validation additions. This could be committed if tests are passing.

1) Drupal\Tests\taxonomy\Kernel\TokenReplaceTest::testTaxonomyTokenReplacement
Drupal\Core\Config\Schema\SchemaIncompleteException: Schema errors for node.type.article with the following errors: 0 [name] This value should not be blank.

Fixed.

Tests pass, so setting back to RTBC.

Committed 9b62b23 and pushed to 11.x. Thanks!

lauriii → closed merge request !2671

Automatically closed - issue fixed for 2 weeks with no activity.