I have a site that was installed. Then I went ahead and changed its site name. This in turn updated the language config, so the diff looks like so:
--- a/config/common/language.negotiation.yml
+++ b/config/common/language.negotiation.yml
@@ -6,6 +6,7 @@ url:
prefixes:
en: en
nb: ''
+ '': null
This is because the following logic:
if ($saved_config->getName() == 'system.site' && $event->isChanged('default_langcode')) {
Well, the saved config was indeed system.site. But the default_langcode was not changed. Only the system.site.name config was changed. So why is it that $event->isChanged('default_langcode') returns true? Well it's because the $config->original is not equal to the $config->data. Because $config->original is empty, since that is initialized after the config object creates this event (from Config.php):
$this->eventDispatcher->dispatch(new ConfigCrudEvent($this), ConfigEvents::SAVE);
$this->originalData = $this->data;
This is not true if you change the config through the site information config form. But if you import a config change for system.site, naturally a save event for the config will happen, and then $config->original will be empty. It should be possible to write a test for this, but I have at least confirmed it with a clean install on 9.5.x.
Check that there is original config? Or just check that the old default language is not falsy?
Decide on an approach. Write tests
none
none
none
Needs work
10.1 ✨
Used to track the progress of issues reviewed by the Drupal Needs Review Queue Initiative.
The change is currently missing an automated test that fails when run with the original code, and succeeds when the bug has been fixed.
Not all content is available!
It's likely this issue predates Contrib.social: some issue and comment data are missing.
This issue is being reviewed by the kind folks in Slack, #needs-review-queue-initiative. We are working to keep the size of Needs Review queue [2700+ issues] to around 400 (1 month or less), following Review a patch or merge request → as a guide.
As a bug this needs a test case
In the issue summary the proposed solution seems like a question, is that the solution that was taken?