- 🇺🇸United States luke.leber Pennsylvania
We'll want the IIFE to take this form:
(function (Drupal) { ... })(Drupal);
I think all that #2 needs is to pass the
Drupal
object from outer scope to the IIFE inner scope in this fashion and it should be good to go.Thanks!
- Status changed to Needs review
almost 2 years ago 6:56am 9 May 2023 - 🇮🇳India mrinalini9 New Delhi
Updated patch #2 by addressing #9, please review it.
Thanks!
- last update
almost 2 years ago 1 pass - 🇺🇸United States luke.leber Pennsylvania
This is going to sound ironic, but I am actually not on any social media platforms!
I'm tagging this as needing manual testing. If the community can successfully perform an end-to-end test with the Facebook Send functionality with #10 applied and confirm here, I'll gladly merge it.
Thanks!