Fix dependencies in social_media.libraries.yml

Created on 3 August 2022, over 2 years ago
Updated 11 May 2023, almost 2 years ago

Problem/Motivation

The facebook library definition is defined in social_media.libraries.yml.
But this library definition has two problems.

  1. The library definition configures core/jquery as a dependency. But, no jQuery functions are used in facebook.js.
  2. The facebook.js file uses Drupal.behaviors that is defined in the core/drupal. But core/drupal is not included as a dependency in the library definition.

Proposed resolution

Fix the library dependencies and remove jQuery variable from the facebook.js.

🐛 Bug report
Status

Needs review

Version

2.0

Component

Code

Created by

🇯🇵Japan tom konda Kanagawa, Japan

Live updates comments and jobs are added and updated live.
  • Needs manual testing

    The change/bugfix cannot be fully demonstrated by automated testing, and thus requires manual testing in a variety of environments.

Sign in to follow issues

Comments & Activities

Not all content is available!

It's likely this issue predates Contrib.social: some issue and comment data are missing.

Production build 0.71.5 2024