- 🇺🇸United States emptyvoid
External resource throwing a 503 error and blocking all requests.
This causes over 20 second hang to render every single screen on all drupal sites using this module.https://unpkg.com/slide-element@2/dist/index.umd.js
- 🇺🇸United States emptyvoid
patch against 4.x dev branch including external js to remove 20-30 error timeout and page draw holds.
-
darvanen →
authored 9da8291a on 4.x
Issue #3299717 by emptyvoid, maxilein, darvanen: Collapsiblock Make...
-
darvanen →
authored 9da8291a on 4.x
- 🇦🇺Australia darvanen Sydney, Australia
I'm not comfortable with including the package directly in the module. I've taken a lead from the Webform module and kept the CDN as a fallback while allowing people to install the library in their project in an appropriate location. Thanks for your nudges to get this done.
- Status changed to Fixed
almost 2 years ago 1:19pm 21 April 2023 - 🇮🇳India chandu7929 Pune
Due to this changes ExistingSiteJavascript test are failing, its seems that libraries is not available during test.
Note: I have not downloaded the lib locally. - 🇦🇺Australia darvanen Sydney, Australia
Thanks for calling that out, shouldn't be too difficult to solve, I might have time this weekend but I'm very happy for someone else to take a look at it too. I'm out or I would open a new ticket for this.
- 🇮🇳India chandu7929 Pune
Created child issue 🐛 Due to the change in library, ExistingSiteJavascript tests are failing. Closed: works as designed for the same.
Automatically closed - issue fixed for 2 weeks with no activity.